Source: jabberd2
Version: 2.7.0-4.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240319 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):

make[3]: Entering directory '/<<PKGBUILDDIR>>/sx'
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-callback.lo `test -f 'callback.c' || echo './'`callback.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-chain.lo `test -f 'chain.c' || echo './'`chain.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-client.lo `test -f 'client.c' || echo './'`client.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-env.lo `test -f 'env.c' || echo './'`env.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-error.lo `test -f 'error.c' || echo './'`error.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-io.lo `test -f 'io.c' || echo './'`io.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-server.lo `test -f 'server.c' || echo './'`server.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-sx.lo `test -f 'sx.c' || echo './'`sx.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-sasl.lo `test -f 'sasl.c' || echo './'`sasl.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-ack.lo `test -f 'ack.c' || echo './'`ack.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-ssl.lo `test -f 'ssl.c' || echo './'`ssl.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-compress.lo `test -f 'compress.c' || echo './'`compress.c

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-

protection -Wformat -Werror=format-security -fcf-protection -funsigned-char -fdiagnostics-color -c -o libsx_la-websocket.lo `test -f 'websocket.c' || echo './'`websocket.c

websocket.c: In function ‘_sx_websocket_http_header_field’: websocket.c:256:38: warning: passing argument 2 of ‘strunescape’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
256 | strunescape(sc->p, spool_print(sc->field)),
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from sx.h:31,
from websocket.c:25:
../util/util.h:135:48: note: expected ‘char *’ but argument is of type ‘const char *’
135 | JABBERD2_API char *strunescape(pool_t p, char* buf);
| ~~~~~~^~~ websocket.c:257:38: warning: passing argument 2 of ‘strunescape’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
257 | strunescape(sc->p, spool_print(sc->value)));
| ^~~~~~~~~~~~~~~~~~~~~~ ../util/util.h:135:48: note: expected ‘char *’ but argument is of type ‘const char *’
135 | JABBERD2_API char *strunescape(pool_t p, char* buf);
| ~~~~~~^~~
websocket.c: In function ‘_sx_websocket_rio’:
websocket.c:344:80: error: implicit declaration of function ‘strcasestr’; did you mean ‘strcasecmp’? [-Werror=implicit-function-declaration]
344 | if(j_strcmp(upgrade, "websocket") || connection == NULL || strcasestr(connection, "Upgrade") == NULL || j_strcmp(proto, "xmpp") || version != 13) {
| ^~~~~~~~~~
| strcasecmp
websocket.c:344:114: warning: comparison between pointer and integer
344 | if(j_strcmp(upgrade, "websocket") || connection == NULL || strcasestr(connection, "Upgrade") == NULL || j_strcmp(proto, "xmpp") || version != 13) {
| ^~
websocket.c:357:21: warning: ‘SHA1_Init’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
357 | sha1_init(&sha1);
| ^~~~~~~~~
In file included from ../util/sha1.h:41,
from ../util/util.h:102:
/usr/include/openssl/sha.h:49:27: note: declared here
49 | OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c);
| ^~~~~~~~~
websocket.c:358:21: warning: ‘SHA1_Update’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
358 | sha1_append(&sha1, key, j_strlen(key));
| ^~~~~~~~~~~
/usr/include/openssl/sha.h:50:27: note: declared here
50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
| ^~~~~~~~~~~
websocket.c:359:21: warning: ‘SHA1_Update’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
359 | sha1_append(&sha1, websocket_guid, sizeof(websocket_guid) -1);
| ^~~~~~~~~~~
/usr/include/openssl/sha.h:50:27: note: declared here
50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
| ^~~~~~~~~~~
websocket.c:360:21: warning: ‘SHA1_Final’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
360 | sha1_finish(&sha1, hash);
| ^~~~~~~~~~~
/usr/include/openssl/sha.h:51:27: note: declared here
51 | OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
| ^~~~~~~~~~
ssl.c: In function ‘sx_ssl_get_DHparams’:
ssl.c:97:1: warning: ‘PEM_read_bio_DHparams’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
97 | DECLARE_sx_ssl_getparams(DHparams, DH)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/ssl.h:36,
from plugins.h:60,
from sx.h:418,
from ssl.c:26:
/usr/include/openssl/pem.h:472:1: note: declared here
472 | DECLARE_PEM_rw_attr(OSSL_DEPRECATEDIN_3_0, DHparams, DH)
| ^~~~~~~~~~~~~~~~~~~
ssl.c: In function ‘sx_ssl_get_ECPKParameters’:
ssl.c:98:1: warning: ‘PEM_read_bio_ECPKParameters’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
98 | DECLARE_sx_ssl_getparams(ECPKParameters, EC_GROUP)
| ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/pem.h:464:1: note: declared here
464 | DECLARE_PEM_rw_attr(OSSL_DEPRECATEDIN_3_0, ECPKParameters, EC_GROUP)
| ^~~~~~~~~~~~~~~~~~~
ssl.c: In function ‘sx_ssl_make_dh_params’:
ssl.c:114:5: warning: ‘DH_new’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
114 | DH *dh = DH_new();
| ^~
In file included from /usr/include/openssl/dsa.h:31,
from /usr/include/openssl/x509.h:37,
from /usr/include/openssl/ssl.h:31: /usr/include/openssl/dh.h:206:27: note: declared here
206 | OSSL_DEPRECATEDIN_3_0 DH *DH_new(void);
| ^~~~~~
ssl.c:131:9: warning: ‘DH_set0_pqg’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
131 | if (p == NULL || g == NULL || !DH_set0_pqg(dh, p, NULL, g)) {
| ^~
/usr/include/openssl/dh.h:262:27: note: declared here
262 | OSSL_DEPRECATEDIN_3_0 int DH_set0_pqg(DH *dh, BIGNUM *p, BIGNUM *q, BIGNUM *g);
| ^~~~~~~~~~~
ssl.c:132:13: warning: ‘DH_free’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
132 | DH_free(dh);
| ^~~~~~~
/usr/include/openssl/dh.h:207:28: note: declared here
207 | OSSL_DEPRECATEDIN_3_0 void DH_free(DH *dh);
| ^~~~~~~
ssl.c: In function ‘sx_ssl_free_dh_params’:
ssl.c:145:9: warning: ‘DH_free’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
145 | DH_free(dhparams[i].dh);
| ^~~~~~~
/usr/include/openssl/dh.h:207:28: note: declared here
207 | OSSL_DEPRECATEDIN_3_0 void DH_free(DH *dh);
| ^~~~~~~
ssl.c: In function ‘sx_ssl_server_addcert’:
ssl.c:1088:5: warning: ‘SSL_CTX_set_tmp_dh_callback’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
1088 | SSL_CTX_set_tmp_dh_callback(ctx, _sx_ssl_tmp_dh_callback);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/openssl/ssl.h:2230:6: note: declared here
2230 | void SSL_CTX_set_tmp_dh_callback(SSL_CTX *ctx,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
ssl.c:1096:9: warning: ‘DH_bits’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
1096 | _sx_debug(ZONE, "custom DH parameters loaded from certificate", DH_bits(dhparams));
| ^~~~~~~~~
/usr/include/openssl/dh.h:209:27: note: declared here
209 | OSSL_DEPRECATEDIN_3_0 int DH_bits(const DH *dh);
| ^~~~~~~
ssl.c:1101:5: warning: ‘EC_KEY_new_by_curve_name’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
1101 | if((ecparams = sx_ssl_get_ECPKParameters(pemfile)) && (nid = EC_GROUP_get_curve_name(ecparams)) && (eckey = EC_KEY_new_by_curve_name(nid))) {
| ^~
In file included from /usr/include/openssl/x509.h:33: /usr/include/openssl/ec.h:1001:31: note: declared here
1001 | OSSL_DEPRECATEDIN_3_0 EC_KEY *EC_KEY_new_by_curve_name(int nid);
| ^~~~~~~~~~~~~~~~~~~~~~~~
ssl.c:1116:5: warning: ‘EC_KEY_free’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
1116 | EC_KEY_free(eckey);
| ^~~~~~~~~~~
/usr/include/openssl/ec.h:1006:28: note: declared here
1006 | OSSL_DEPRECATEDIN_3_0 void EC_KEY_free(EC_KEY *key);
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [Makefile:538: libsx_la-websocket.lo] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/19/jabberd2_2.7.0-4.1_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240319;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240319&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing control commands:

tags -1 patch

Bug #1067259 [src:jabberd2] jabberd2: FTBFS: make[3]: *** [Makefile:538: libsx_la-websocket.lo] Error 1
Added tag(s) patch.

--
1067259: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067259
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: jabberd2
Followup-For: Bug #1067259
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

--
Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

diff -Nru jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch
--- jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.000000000 -0800
+++ jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch 2024-04-10 15:03:46.000000000 -0700
@@ -0,0 +1,81 @@
+Description: add missing includes and disable conflicting crypt_r()
+ Nothing uses crypt_r() externally, it should use the glibc one; so disable
+ the conflicting prototype in the internal header.
+Author: Steve Langasek <steve.langasek@canonical.com>
+Bug-Debian: https://bugs.debian.org/1067259
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: jabberd2-2.7.0/storage/authreg_sqlite.c +===================================================================
+--- jabberd2-2.7.0.orig/storage/authreg_sqlite.c
++++ jabberd2-2.7.0/storage/authreg_sqlite.c
+@@ -32,6 +32,7 @@
+ #define _XOPEN_SOURCE 500
+ #include "c2s.h"
+ #include <sqlite3.h>
++#include <crypt.h>
+
+ /* Windows does not have the crypt() function, let's take DES_crypt from OpenSSL instead */
+ #if defined(HAVE_OPENSS

This is a multi-part message in MIME format...

Your message dated Thu, 11 Apr 2024 06:35:01 +0000
with message-id <E1ruo1V-008k4N-4Q@fasolo.debian.org>
and subject line Bug#1067259: fixed in jabberd2 2.7.0-5
has caused the Debian Bug report #1067259,
regarding jabberd2: FTBFS: make[3]: *** [Makefile:538: libsx_la-websocket.lo] Error 1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1067259: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067259
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 20 Mar 2024 21:06:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-105.5 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
FROMDEVELOPER,FVGT_m_MULTI_ODD,SPF_HELO_NONE,SPF_NONE,
T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,
USER_IN_DKIM_WHITELIST autolearn=ham autolearn_force=no
version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 209; hammy, 150; neutral, 252; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:108, 0.000-+--H*RT:311
Return-path: <lucas@debian.org>
Received: from stravin