Source: kcemu
Version: 0.5.2+dfsg-1
Severity: serious
Tags: ftbfs sid trixie
Justification: fails to build from source (but built successfully in the past)

Hi,

kcemu FTBFS with -Werror=implicit-function-declaration which was
recently enabled by default in dpkg 1.22.6 to support the 64-bit time_t transition. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

gcc -DHAVE_CONFIG_H -I. -I../../../include/kc -I../../../include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/kcemu-0.5.2+dfsg=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=
format-security -fcf-protection -c -o sys_socket_create.o sys_socket_create.c sys_socket_create.c: In function 'sys_socket_create':
sys_socket_create.c:44:9: error: implicit declaration of function 'perror' [-Werror=implicit-function-declaration]
44 | perror("setsockopt() failed");
| ^~~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:518: sys_socket_create.o] Error 1


Andreas

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing control commands:

tags -1 patch

Bug #1067141 [src:kcemu] kcemu: FTBFS with -Werror=implicit-function-declaration
Added tag(s) patch.

--
1067141: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067141
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: kcemu
Followup-For: Bug #1067141
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

* debian/patches/add-missing-includes.patch: Add missing includes.
Closes LP: #2060887.


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
APT prefers jammy-updates
APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru kcemu-0.5.2+dfsg/debian/control kcemu-0.5.2+dfsg/debian/control
--- kcemu-0.5.2+dfsg/debian/control 2024-03-07 22:13:42.000000000 -0700
+++ kcemu-0.5.2+dfsg/debian/control 2024-04-10 17:17:16.000000000 -0600
@@ -1,8 +1,7 @@
Source: kcemu
Section: contrib/otherosfs
Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> -XSBC-Original-Maintainer: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
+Maintainer: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Build-Depends: debhelper-compat (= 13), libz80ex-dev, libsdl1.2-dev, libsndfile-dev, libvncserver-dev, libtheora-dev,
libgtk2.0-dev, automake, autoconf, libxmu-dev, libncurses5-dev, netpbm, imagemagick, dh-autoreconf
Standards-Version: 4.6.1
diff -Nru kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch
--- kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch 1969-12-31 17:00:00.000000000 -0700
+++ kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch 2024-04-10 1

This is a multi-part message in MIME format...

Your message dated Sat, 13 Apr 2024 09:06:27 +0000
with message-id <E1rvZL9-003LeQ-Pf@fasolo.debian.org>
and subject line Bug#1067141: fixed in kcemu 0.5.2+dfsg-2
has caused the Debian Bug report #1067141,
regarding kcemu: FTBFS with -Werror=implicit-function-declaration
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1067141: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067141
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 19 Mar 2024 10:10:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-6.0 required=4.0 tests=BAYES_00,FROMDEVELOPER,
SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 17; hammy, 146; neutral, 25; spammy,
0. spammytokens: hammytokens:0.000-+--H*F:U*anbe, 0.000-+--trixie,
0.000-+--H*rp:U*anbe, 0.000-+--Hx-spam-relays-external:anbe@debian.org,
0.000-+--H*RU:anbe@debian.org
Return-path: <anbe@debian.org>
Received: from lambdaproxy.unixos.de ([87.106.170.14]:42954)
by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
(Exim 4.94.2)
(envelope-from <anbe@d