Package: dpkg-dev
Version: 1.22.6
Severity: serious
X-Debbugs-Cc: Steve Langasek <vorlon@debian.org>

There are at least 3 different ways how -Werror=implicit-function-declaration breaks packages:

1. Code that did emit implicit-function-declaration warnings during
compilation before and does FTBFS now

2. Code that does FTBFS now due to other breakage caused by
-Werror=implicit-function-declaration, e.g. in autoconf tests

3. Code that does still compile with -Werror=implicit-function-declaration
but behaves differently, e.g. due to failing autoconf tests silently
disabling features


Cases from point 1 were always(?) bugs and it is good that
they get fixed.

The real-world effect of these bugs can be everywhere from
"completely harmless" to "that was always broken".

Debian has automation listing implicit-function-declaration warnings
in all packages already running for several years: https://qa.debian.org/bls/bytag/W-implicit-declaration.html


My main worry is point 3, issues like #1066394.

#1066394 was found due to causing a FTBFS in a different package,
but the more common case is likely that a program has some
feature/plugin disabled and this won't be spotted until much later.

"Much later" might be after the release of trixie a user upgrading
to bookworm who uses this feature.

Or it might result in a program silently using an insecure legacy codepath, e.g. after a test for getentropy() failed.


A large part of the packages in unstable might not get recompiled
between now and the release of trixie, creating the additional
issue that any such problem might occur only after a security update
or point release update if this is the next rebuild of the package
in trixie.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Wed, 20 Mar 2024 00:06:15 +0100
with message-id <ZfoaZ19brpoY_YPY@thunder.hadrons.org>
and subject line Re: Bug#1066952: Defaulting to -Werror=implicit-function-declaration might not be a good idea
has caused the Debian Bug report #1066952,
regarding Defaulting to -Werror=implicit-function-declaration might not be a good idea
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1066952: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066952
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 16 Mar 2024 00:18:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-118.2 required=4.0 tests=BAYES_00,
BODY_INCLUDES_PACKAGE,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,HAS_PACKAGE,SPF_HELO_NONE,
SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,
USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,XMAILER_REPORTBUG
autolearn=ham autolearn_force=no
version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 22; hammy, 150; neutral, 85; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: <bunk@debian.o