• Bug#1066473: multitail: FTBFS: mt.c:707:25: error: implicit declaration

    From Rene Engelhard@21:1/5 to All on Wed Mar 13 19:30:01 2024
    tag 1066473: + pending

    thanks

    Hi,

    Am 13.03.24 um 12:53 schrieb Lucas Nussbaum:
    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    Interesting. I almost wanted to tag it unreproducible since it didn't
    happen in my already-existing chroot... But it definitely does fail in cowbuilder build <.dsc> :/


    Nope. Just works here. Yes, with dpkg-dev 1.22.6. In a manual chroot I
    have here and upgraded and in a cowbuilder build multitail_6.5.0-1.dsc


    Relevant part (hopefully):
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wno-unused-parameter -funsigned-char -O3 -DLinux -DVERSION=\"
    6.5.0\" -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DCONFIG_FILE=\"/etc/multitail.conf\" -MMD -MP -DUTF8_SUPPORT -c
    -o mt.o mt.c
    mt.c: In function ‘do_color_print’:
    mt.c:707:25: error: implicit declaration of function ‘waddnwstr’; did you mean ‘waddnstr’? [-Werror=implicit-function-declaration]
    707 | waddnwstr(win -> win, &wcur, 1);
    | ^~~~~~~~~
    | waddnstr
    mt.c: In function ‘update_statusline’:
    mt.c:1467:126: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 5 has type ‘off64_t’ {aka ‘long int’} [-Wformat=]
    1467 | mvwprintw(status -> win, 0, win_width - (strlen(timestamp) + cur_len), "%10lld - %s", fsize, timestamp);
    | ~~~~~^ ~~~~~
    | | |
    | | off64_t {aka long int}
    | long long int
    | %10ld
    cc1: some warnings being treated as errors
    make[2]: *** [<builtin>: mt.o] Error 1

    Actually upstream has

    #if defined(UTF8_SUPPORT) && defined(NCURSES_WIDECHAR)
    // FIXME warning: implicit declaration of function �~@~Xwaddnwstr�~@~Y
    is invalid in C99 [-Wimplicit-function-declaration]
    // see /usr/include/ncurses.h
                            waddnwstr(win -> win, &wcur, 1);
    #else
                            wprintw(win -> win, "%c", wcur);
    #endif

    so is aware...


    Actually (thanks to discussion on IRC) it seems that

    CPPFLAGS:=$(shell pkg-config --cflags ncurses)
    NCURSES_LIB:=$(shell pkg-config --libs ncurses)

    is empty even though it shouldn't be. So fix is to add that missing
    build-dep.


    Regards,


    Rene

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)