• Bug#1066707: ifupdown-ng: FTBFS: libifupdown/interface.c:28:9: error: i

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 15:00:02 2024
    Source: ifupdown-ng
    Version: 0.12.1-3
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/environment.o libifupdown/environment.c
    libifupdown/interface.c: In function ‘lif_address_parse’: libifupdown/interface.c:28:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
    28 | strlcpy(buf, presentation, sizeof buf);
    | ^~~~~~~
    | strncpy
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/execute.o libifupdown/execute.c
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/lifecycle.o libifupdown/lifecycle.c
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/config-parser.o libifupdown/config-parser.c
    libifupdown/interface-file.c: In function ‘maybe_remap_token’: libifupdown/interface-file.c:129:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
    129 | strlcpy(tokbuf, tok != NULL ? tok->alternative : token, sizeof tokbuf);
    | ^~~~~~~
    | strncpy
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/config-file.o libifupdown/config-file.c
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/compat.o libifupdown/compat.c
    libifupdown/lifecycle.c: In function ‘query_dependents_from_executors’: libifupdown/lifecycle.c:116:17: error: implicit declaration of function ‘strlcat’; did you mean ‘strncat’? [-Werror=implicit-function-declaration]
    116 | strlcat(buf, " ", bufsize);
    | ^~~~~~~
    | strncat
    libifupdown/lifecycle.c: In function ‘lif_lifecycle_query_dependents’: libifupdown/lifecycle.c:265:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
    265 | strlcpy(deps, entry->data, sizeof deps);
    | ^~~~~~~
    | strncpy
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/yaml-base.o libifupdown/yaml-base.c
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o libifupdown/yaml-writer.o libifupdown/yaml-writer.c
    cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes -
    Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" -DPACKAGE_
    NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\" -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML -c -o cmd/multicall.o cmd/multicall.c
    libifupdown/compat.c: In function ‘compat_ifupdown2_bridge_ports_inherit_vlans’:
    libifupdown/compat.c:54:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
    54 | strlcpy(bridge_ports_str, bridge_ports_entry->data, sizeof bridge_ports_str);
    | ^~~~~~~
    | strncpy
    cc1: all warnings being treated as errors
    make[2]: *** [<builtin>: libifupdown/interface.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/ifupdown-ng_0.12.1-3_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Daniel =?UTF-8?Q?Gr=C3=B6ber?=@21:1/5 to Lucas Nussbaum on Wed Mar 13 16:40:01 2024
    On Wed, Mar 13, 2024 at 12:51:44PM +0100, Lucas Nussbaum wrote:
    Source: ifupdown-ng

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    Thanks Lucas, I'm uploading a fix right now.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    It was due to a hardcoded path to libbsd's include directory which seems to have moved to to a multiarch location.

    Thanks,
    --Daniel

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEV6G/FbT2+ZuJ7bKf05SBrh55rPcFAmXxwYkACgkQ05SBrh55 rPebag/+Ilw55IOfUEK5XElwYe74KoSLy7U7DrbPxPMWOqOnBcvDeti/kg0CFajn zoXolocBgWUkMnDxQmRX7z95XTCmWqEHOnZRomhqyyr1q5kgLT4jy+oZm0M2wiuP cht4wGePxNiqOVwxA5KV5TwkaDylWq86anTwmpBOrZ3u+DUbH8K3VugR3IK3Moow w23j7sZ/4URDjBy9MgvqX+pI+LQ+semzopO0MnT32ldK3ot/ZWCWCibLCdyId3O0 rR/JyQt+3+KWyy0ntTJDwXI++o+QmHcsMFluGwKTPD1lGxe5aY9+PjYQCjw+dF2s yiYvGNL4dVqVTJcXNQHq/YFVA9Xh/x5lCUb+2yB4oCezQ3rxU8NendbAotQ4y4PM jb4fsrMsL9Pa1keIgB/nUT0ET8hX5a693BDMXzSAthBWC5TPIzG4ghc8k3IlI/1E YgS96uFCH3FKimIav7nbk8RSmJSMLAl+i0skLOjbrC6IEy4O02la2t9K/2sCIVuL cVTyhIKJk3HhBfppf9vIdj6G+HZSawiKzKomsix3Um5GNcSr1Q2lZchPqyzB0I6B DyoN+QBNpRKzWIpgewitZ0bG+netITnH76TtamWr0q+bF+v4cAZwM8MxyhgCvNSc stv9UGAcHdTWxvYAoFvuaOBtQwhs2vyLw16eVCH3aEvsDmFqMWw=
    =TwIi
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Wed Mar 13 18:00:02 2024
    This is a multi-part message in MIME format...

    Your message dated Wed, 13 Mar 2024 16:52:08 +0000
    with message-id <E1rkRpo-007O2q-9H@fasolo.debian.org>
    and subject line Bug#1066707: fixed in ifupdown-ng 0.12.1-4
    has caused the Debian Bug report #1066707,
    regarding ifupdown-ng: FTBFS: libifupdown/interface.c:28:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1066707: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066707
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 13 Mar 2024 13:52:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-106.1 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
    FROMDEVELOPER,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
    UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST
    autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 53; hammy, 150; neutral, 221; spammy,
    0. spammytokens:
    hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
    0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
    0.000-+--H*RT:108, 0.000-+--H*RT:311
    Return-path: <lucas@debian.org>
    Received: from stravinsky.debian.org ([20