Source: knews
Version: 1.0b.1-36
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

gcc -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L -D_

POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -DFUNCPROTO=15 -DNARROWPROTO -Wdate-time -D_FORTIFY_SOURCE=2 -c -o
Menu.o Menu.c

In file included from /usr/include/x86_64-linux-gnu/sys/types.h:25,
from /usr/include/X11/Xlib.h:38,
from /usr/include/X11/Intrinsic.h:53,
from /usr/include/X11/IntrinsicP.h:51,
from Menu.c:5:
/usr/include/features.h:195:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
195 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
| ^~~~~~~
Menu.c: In function ‘MenuCreateGadget’:
Menu.c:347:9: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
347 | exit(1);
| ^~~~
Menu.c:11:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
10 | #include "MenuP.h"
+++ |+#include <stdlib.h>
11 |
Menu.c:347:9: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
347 | exit(1);
| ^~~~
Menu.c:347:9: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
cc1: some warnings being treated as errors
make[3]: *** [<builtin>: Menu.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/knews_1.0b.1-36_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tag -1 pending

Hello,

Bug #1066692 in knews reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/knews/-/commit/b76b51bc2091260c801ffc439d40cdf4658d0cfa

------------------------------------------------------------------------
Add missing #includes

Closes: #1066692 ------------------------------------------------------------------------

(this message was generated automatically)
--
Greetings

https://bugs.debian.org/1066692

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing control commands:

tag -1 pending

Bug #1066692 [src:knews] knews: FTBFS: Menu.c:347:9: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
Added tag(s) pending.

--
1066692: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066692
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Wed, 13 Mar 2024 14:49:52 +0000
with message-id <E1rkPvU-0074R6-Nv@fasolo.debian.org>
and subject line Bug#1066692: fixed in knews 1.0b.1-37
has caused the Debian Bug report #1066692,
regarding knews: FTBFS: Menu.c:347:9: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1066692: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066692
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 13 Mar 2024 13:47:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-106.2 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,
USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST autolearn=ham
autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 150; neutral, 199; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: <lucas@debian.org>
Received: from stravinsky.debian.org ([2001:41b8:2