• Bug#1066666: postmark: FTBFS: postmark-1.53.c:622:7: error: implicit de

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 14:40:01 2024
    Source: postmark
    Version: 1.53-2.1
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -O2 -g -Wall -pipe -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection postmark-1.53.c -o postmark
    postmark-1.53.c:113:20: warning: missing braces around initializer [-Wmissing-braces]
    113 | cmd command_list[]={ /* table of CLI commands */
    | ^
    postmark-1.53.c: In function ‘parse_weight’:
    postmark-1.53.c:287:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
    287 | if (split=strrchr(params,' '))
    | ^~~~~
    postmark-1.53.c: In function ‘add_location’:
    postmark-1.53.c:306:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
    306 | if (new_file_system=(file_system *)calloc(1,sizeof(file_system)))
    | ^~~~~~~~~~~~~~~
    postmark-1.53.c: In function ‘verbose_report’:
    postmark-1.53.c:535:19: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    535 | fprintf(fp,"\t%d seconds total\n",elapsed);
    | ~^ ~~~~~~~
    | | |
    | int time_t {aka long int}
    | %ld
    postmark-1.53.c:536:19: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    536 | fprintf(fp,"\t%d seconds of transactions (%d per second)\n",t_elapsed,
    | ~^ ~~~~~~~~~
    | | |
    | int time_t {aka long int}
    | %ld
    postmark-1.53.c:536:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    536 | fprintf(fp,"\t%d seconds of transactions (%d per second)\n",t_elapsed,
    | ~^
    | |
    | int
    | %ld
    537 | transactions/t_elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c:540:31: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    540 | fprintf(fp,"\t%d created (%d per second)\n",files_created,
    | ~^
    | |
    | int
    | %ld
    541 | files_created/elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c:546:56: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    546 | fprintf(fp,"\t\tMixed with transactions: %d files (%d per second)\n",
    | ~^
    | |
    | int
    | %ld
    547 | files_created-simultaneous,(files_created-simultaneous)/t_elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c:548:28: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    548 | fprintf(fp,"\t%d read (%d per second)\n",files_read,files_read/t_elapsed);
    | ~^ ~~~~~~~~~~~~~~~~~~~~
    | | |
    | int time_t {aka long int}
    | %ld
    postmark-1.53.c:549:32: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    549 | fprintf(fp,"\t%d appended (%d per second)\n",files_appended,
    | ~^
    | |
    | int
    | %ld
    550 | files_appended/t_elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c:551:31: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    551 | fprintf(fp,"\t%d deleted (%d per second)\n",files_deleted,
    | ~^
    | |
    | int
    | %ld
    552 | files_deleted/elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c:557:56: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    557 | fprintf(fp,"\t\tMixed with transactions: %d files (%d per second)\n",
    | ~^
    | |
    | int
    | %ld
    558 | files_deleted-deleted,(files_deleted-deleted)/t_elapsed);
    | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | time_t {aka long int}
    postmark-1.53.c: In function ‘terse_report’:
    postmark-1.53.c:577:17: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    577 | fprintf(fp,"%d %d %.2f ", elapsed, t_elapsed,
    | ~^ ~~~~~~~
    | | |
    | int time_t {aka long int}
    | %ld
    postmark-1.53.c:577:20: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
    577 | fprintf(fp,"%d %d %.2f ", elapsed, t_elapsed,
    | ~^ ~~~~~~~~~
    | | |
    | int time_t {aka long int}
    | %ld
    postmark-1.53.c: In function ‘write_blocks’:
    postmark-1.53.c:622:7: error: implicit declaration of function ‘write’; did you mean ‘fwrite’? [-Werror=implicit-function-declaration]
    622 | write(fd,file_source+offset,write_block_size);
    | ^~~~~
    | fwrite
    postmark-1.53.c:628:4: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
    628 | close(fd);
    | ^~~~~
    | pclose
    postmark-1.53.c: In function ‘create_file_name’:
    postmark-1.53.c:666:29: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
    666 | sprintf(conversion,"s%d%s",RND(subdirectories),SEPARATOR);
    | ~^
    | |
    | int
    | %ld
    postmark-1.53.c: In function ‘read_file’:
    postmark-1.53.c:751:13: error: implicit declaration of function ‘read’; did you mean ‘fread’? [-Werror=implicit-function-declaration]
    751 | read(fd,read_buffer,read_block_size);
    | ^~~~
    | fread
    postmark-1.53.c: In function ‘create_subdirectories’: postmark-1.53.c:76:18: error: implicit declaration of function ‘mkdir’ [-Werror=implicit-function-declaration]
    76 | #define MKDIR(x) mkdir(x,0700)
    | ^~~~~
    postmark-1.53.c:911:10: note: in expansion of macro ‘MKDIR’
    911 | MKDIR(dir_name);
    | ^~~~~
    postmark-1.53.c: In function ‘delete_subdirectories’: postmark-1.53.c:940:10: error: implicit declaration of function ‘rmdir’ [-Werror=implicit-function-declaration]
    940 | rmdir(dir_name);
    | ^~~~~
    postmark-1.53.c: In function ‘cli_load’:
    postmark-1.53.c:1056:7: error: implicit declaration of function ‘read_config_file’ [-Werror=implicit-function-declaration]
    1056 | read_config_file(param,buffer,0);
    | ^~~~~~~~~~~~~~~~
    postmark-1.53.c: In function ‘cli_read_line’:
    postmark-1.53.c:1154:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
    1154 | if (result=fgets(buffer,size,stdin)) /* read line safely */
    | ^~~~~~
    postmark-1.53.c: In function ‘read_config_file’:
    postmark-1.53.c:1204:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
    1204 | if (fp=fopen(filename,"r")) /* open config file */
    | ^~
    postmark-1.53.c: At top level:
    postmark-1.53.c:1224:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
    1224 | main(argc,argv)
    | ^~~~
    cc1: some warnings being treated as errors
    make[1]: *** [Makefile:11: postmark] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/postmark_1.53-2.1_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)