Source: mp3wrap
Version: 0.5-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"mp3wrap\" -DVERSION=\"0.5\" -DHAVE_MEMSET=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -

DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -I. -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -
fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c `test -f crc.c || echo './'`crc.c

wrap.c: In function ‘charat’:
wrap.c:36:17: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]
36 | if (pos<strlen(s))
| ^~~~~~
wrap.c:33:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
32 | #include "crc.h"
+++ |+#include <string.h>
33 |
wrap.c:36:17: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
36 | if (pos<strlen(s))
| ^~~~~~
wrap.c:36:17: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
wrap.c: In function ‘cindexsize’:
wrap.c:60:25: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
60 | size += strlen(argv[i+2+optoffset])+1;
| ^~~~~~
wrap.c:60:25: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
wrap.c:61:24: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
61 | return (size + strlen(TAG)+(files+2)*4 + PADDING + CRCLEN);
| ^~~~~~
wrap.c:61:24: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
wrap.c: In function ‘buildindex’:
wrap.c:70:9: error: implicit declaration of function ‘strncpy’ [-Werror=implicit-function-declaration]
70 | strncpy(wrapindex, TAG, strlen(TAG));
| ^~~~~~~
wrap.c:70:9: note: include ‘<string.h>’ or provide a declaration of ‘strncpy’
wrap.c:70:9: warning: incompatible implicit declaration of built-in function ‘strncpy’ [-Wbuiltin-declaration-mismatch]
wrap.c:70:9: note: include ‘<string.h>’ or provide a declaration of ‘strncpy’
wrap.c:70:33: warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
70 | strncpy(wrapindex, TAG, strlen(TAG));
| ^~~~~~
wrap.c:70:33: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
mp3wrap.c: In function ‘main’:
mp3wrap.c:314:25: warning: ‘__builtin___strncat_chk’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
314 | strncat (filename, ext, strlen(ext));
| ^
mp3wrap.c:314:25: note: length computed here
314 | strncat (filename, ext, strlen(ext));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [Makefile:176: wrap.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/mp3wrap_0.5-4_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)