• Bug#1066628: tlf: FTBFS: test_wwv.c:26:5: error: implicit declaration o

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 14:20:02 2024
    Source: tlf
    Version: 1.4.1-5
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DTOP_SRCDIR=\"..\" -DSRCDIR=\"/<<PKGBUILDDIR>>/test\" -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-
    map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o test_zone_nr.o test_zone_nr.c
    test_wwv.c: In function ‘test_wwv_check’:
    test_wwv.c:26:5: error: implicit declaration of function ‘g_strchomp’; did you mean ‘strcmp’? [-Werror=implicit-function-declaration]
    26 | g_strchomp(lastwwv);
    | ^~~~~~~~~~
    | strcmp
    gcc -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -flto=auto -ffat-lto-objects -
    Wl,-z,relro -Wl,-z,now -u __wrap_refreshp -o run_addcall run_addcall.o test_addcall.o data.o functions.o ../src/addcall.o ../src/addmult.o ../src/bands.o ../src/dxcc.o ../src/focm.o ../src/getctydata.o ../src/getpx.o ../src/get_time.o ../src/
    locator2longlat.o ../src/log_utils.o ../src/qrb.o ../src/score.o ../src/searchcallarray.o ../src/zone_nr.o -lm -lglib-2.0 -lpanelw -lncursesw -ltinfo -lcmocka -Wl,-wrap=sleep -Wl,-wrap=key_get -Wl,-wrap=key_poll -Wl,-wrap=wgetch -Wl,-wrap=refreshp
    gcc -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -flto=auto -ffat-lto-objects -
    Wl,-z,relro -Wl,-z,now -u __wrap_refreshp -o run_addmult run_addmult.o test_addmult.o data.o functions.o ../src/addmult.o ../src/bands.o -lm -lglib-2.0 -lpanelw -lncursesw -ltinfo -lcmocka -Wl,-wrap=sleep -Wl,-wrap=key_get -Wl,-wrap=key_poll -Wl,-wrap=
    wgetch -Wl,-wrap=refreshp
    gcc -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -flto=auto -ffat-lto-objects -
    Wl,-z,relro -Wl,-z,now -u __wrap_refreshp -o run_addpfx run_addpfx.o test_addpfx.o data.o functions.o ../src/addpfx.o ../src/bands.o -lm -lglib-2.0 -lpanelw -lncursesw -ltinfo -lcmocka -Wl,-wrap=sleep -Wl,-wrap=key_get -Wl,-wrap=key_poll -Wl,-wrap=
    wgetch -Wl,-wrap=refreshp
    gcc -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -flto=auto -ffat-lto-objects -
    Wl,-z,relro -Wl,-z,now -u __wrap_refreshp -o run_bands run_bands.o test_bands.o data.o functions.o ../src/bands.o -lm -lglib-2.0 -lpanelw -lncursesw -ltinfo -lcmocka -Wl,-wrap=sleep -Wl,-wrap=key_get -Wl,-wrap=key_poll -Wl,-wrap=wgetch -Wl,-wrap=
    refreshp
    cc1: some warnings being treated as errors
    ../src/addpfx.h:24:5: warning: type of ‘add_pfx’ does not match original declaration [-Wlto-type-mismatch]
    24 | int add_pfx(char *pxstr, unsigned int bandindex);
    | ^
    test_addcall.c:36:5: note: type mismatch in parameter 2
    36 | int add_pfx(char *call) {
    | ^
    test_addcall.c:36:5: note: type ‘void’ should match type ‘unsigned int’
    test_addcall.c:36:5: note: ‘add_pfx’ was previously declared here make[3]: *** [Makefile:907: test_wwv.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/tlf_1.4.1-5_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Tony Mancill@21:1/5 to All on Fri Mar 15 06:40:02 2024
    Control: tag -1 pending

    Hello,

    Bug #1066628 in tlf reported by you has been fixed in the
    Git repository and is awaiting an upload. You can see the commit
    message below and you can check the diff of the fix at:

    https://salsa.debian.org/debian-hamradio-team/tlf/-/commit/2ad251e045d3841e84128fbf8bce6987b3ea9962

    ------------------------------------------------------------------------
    Update warnings-as-errors.patch (Closes: #1066628) ------------------------------------------------------------------------

    (this message was generated automatically)
    --
    Greetings

    https://bugs.debian.org/1066628

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)