• Bug#1066573: dnstop: FTBFS: dnstop.c:1891:10: error: implicit declarati

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 14:00:01 2024
    Source: dnstop
    Version: 20120611-2
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DUSE_IPV6=1 -Wdate-time -D_FORTIFY_SOURCE=2 -c -o dnstop.o dnstop.
    c
    dnstop.c: In function ‘main’:
    dnstop.c:1891:10: error: implicit declaration of function ‘strcasestr’; did you mean ‘strcasecmp’? [-Werror=implicit-function-declaration]
    1891 | if (!strcasestr(bpf_program_str, "port "))
    | ^~~~~~~~~~
    | strcasecmp
    dnstop.c: In function ‘allocate_anonymous_address’:
    dnstop.c:350:13: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    350 | read(entropy_fd, buf, 4);
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    dnstop.c:355:13: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    355 | read(entropy_fd, buf, 16);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~
    dnstop.c: In function ‘Table_report’:
    dnstop.c:1306:65: warning: ‘s
    ’ directive output may be truncated writing 2 bytes into a region of size between 0 and 40 [-Wformat-truncation=]
    1306 | snprintf(fmt1, 64, "%%-%d.%ds %%-%d.%ds %%%ds %%%ds %%%ds\n", W1, W1, W2, W2, WC, WP, WP);
    | ^~~ In file included from /usr/include/stdio.h:906,
    from /usr/include/pcap/pcap.h:136,
    from /usr/include/pcap.h:43,
    from dnstop.c:21:
    In function ‘snprintf’,
    inlined from ‘Table_report’ at dnstop.c:1306:2: /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 27 and 67 bytes into a destination of size 64
    54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    55 | __glibc_objsize (__s), __fmt,
    | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    56 | __va_arg_pack ());
    | ~~~~~~~~~~~~~~~~~
    dnstop.c: In function ‘Table_report’:
    dnstop.c:1307:63: warning: ‘%%’ directive output may be truncated writing 1 byte into a region of size between 0 and 40 [-Wformat-truncation=]
    1307 | snprintf(fmt2, 64, "%%-%d.%ds %%-%d.%ds %%%dd %%%d.1f %%%d.1f\n", W1, W1, W2, W2, WC, WP, WP);
    | ^~
    In function ‘snprintf’,
    inlined from ‘Table_report’ at dnstop.c:1307:2: /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 31 and 71 bytes into a destination of size 64
    54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    55 | __glibc_objsize (__s), __fmt,
    | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    56 | __va_arg_pack ());
    | ~~~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors
    make[1]: *** [<builtin>: dnstop.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/dnstop_20120611-2_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)