Source: epic5
Version: 2.1.6-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -I../include -c

functions.c

functions.c: In function ‘function_strptime’:
functions.c:7547:15: error: implicit declaration of function ‘strptime’; did you mean ‘strftime’? [-Werror=implicit-function-declaration]
7547 | if (!(strptime(input, format, &timeptr)))
| ^~~~~~~~
| strftime
functions.c: In function ‘function_realpath’:
functions.c:6496:14: warning: ‘normalize_filename’ accessing 4097 bytes in a region of size 4096 [-Wstringop-overflow=]
6496 | if (!normalize_filename(input, resolvedname))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ functions.c:6496:14: note: referencing argument 2 of type ‘char[4097]’
In file included from ./../include/alias.h:10,
from functions.c:46:
./../include/ircaux.h:49:9: note: in a call to function ‘normalize_filename’
49 | int normalize_filename (const char *, Filename);
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [Makefile:34: functions.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/epic5_2.1.6-1_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing control commands:

tags -1 patch

Bug #1066505 [src:epic5] epic5: FTBFS: functions.c:7547:15: error: implicit declaration of function ‘strptime’; did you mean ‘strftime’? [-Werror=implicit-function-declaration]
Added tag(s) patch.

--
1066505: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066505
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: epic5
Followup-For: Bug #1066505
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hudson@ubuntu.com
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

* d/patches/define-xopen-bsd-source.patch: #define _XOPEN_SOURCE and
_BSD_SOURCE to get access to the declaration of strptime, strlcat and some
other symbols.

Thanks for considering the patch.

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
APT prefers mantic-updates
APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch
--- epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch 1970-01-01 12:00:00.000000000 +1200
+++ epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch 2024-04-10 14:07:56.000000000 +1200
@@ -0,0 +1,17 @@
+--- a/include/irc_std.h
++++ b/include/irc_std.h
+@@ -12,6 +12,14 @@
+ #include "defs.h"
+
+ /*
++ * Define _XOPEN_SOURCE to get access to prototype of strptime() and
++ * _BSD_SOURCE to get access to prototype of strl{cat,cpy} and declaration of ++ * h_errno.
++ */
++#define _XOPEN_SOURCE 700
++#define _BSD_SOURCE
++
++/*
+ * Try to turn back the IPv6 monster at the gate
+ */
+ #ifdef DO_NOT_USE_IPV6
diff -Nru epic5-2.1.6/debian/patches/series epic5-2.1.6/debian/patches/series --- epic5-2.1.6/debian/patches/series 2021-10-10 00:04:08.000000000 +1300
+++ epic5-2.1.6/debian/patches/series 2024-04-10 14:07:56.000000000 +1200
@@ -2,3 +2,4 @@
manual.patch
path.patch
reproducible-build.patch
+define-xopen-bsd-source.patch

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet