gcc -DHAVE_CONFIG_H -I. -I../../common -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security-fcf-protection -Wall -pedantic -DSQLITE3_SONAME=\"libsqlite3.so.0\" -pedantic -rdynamic -c -o scheduler/worker.o ../../common/scheduler/worker.c
../../common/cmdhandler.c: In function ‘cmdhandler_accept_client’: ../../common/cmdhandler.c:386:9: warning: unused variable ‘err’ [-Wunused-variable]
386 | int err;
| ^~~
../../common/cmdhandler.c: In function ‘cmdhandler_start’: ../../common/cmdhandler.c:509:13: warning: unused variable ‘i’ [-Wunused-variable]
509 | ssize_t i;
| ^
../../common/cmdhandler.c: In function ‘self_pipe_trick’: ../../common/cmdhandler.c:596:35: warning: zero-length gnu_printf format string [-Wformat-zero-length]
596 | client_printf(sockfd, "");
| ^~
../../common/cmdhandler.c: In function ‘cmdhandler_perform_command’: ../../common/cmdhandler.c:173:13: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
173 | asprintf(&statusstr, "unknown generic arguments");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../common/cmdhandler.c:202:17: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
202 | asprintf(&statusstr, "memory error");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../common/cmdhandler.c:209:21: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
209 | asprintf(&statusstr, "Error parsing arguments %s command line %s", command->name, arg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/cmdhandler.c:232:25: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
232 | asprintf(&statusstr, "no help for command %s.", arg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../common/cmdhandler.c:246:13: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
246 | asprintf(&statusstr, "Unknown command %s.", arg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../common/scheduler/schedule.c: In function ‘schedule_get_first_task’: ../../common/scheduler/schedule.c:81:20: warning: unused variable ‘node’ [-Wunused-variable]
81 | ldns_rbnode_t* node = LDNS_RBTREE_NULL;
| ^~~~
../../common/scheduler/task.c: In function ‘task_perform’: ../../common/scheduler/task.c:137:25: error: implicit declaration of function ‘clamp’ [-Werror=implicit-function-declaration]
137 | task->backoff = clamp(task->backoff * 2, 60, ODS_SE_MAX_BACKOFF);
| ^~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:601: scheduler/task.o] Error 1
This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
../../common/scheduler/task.c: In function ‘task_perform’: ../../common/scheduler/task.c:137:25: error: implicit declaration of function ‘clamp’ [-Werror=implicit-function-declaration]
137 | task->backoff = clamp(task->backoff * 2, 60, ODS_SE_MAX_BACKOFF);
| ^~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:601: scheduler/task.o] Error 1
tag -1 patch pendingBug #1066479 [src:opendnssec] opendnssec: FTBFS: ../../common/scheduler/task.c:137:25: error: implicit declaration of function ‘clamp’ [-Werror=implicit-function-declaration]
Control: tag -1 patch pending
Lucas Nussbaum <lucas@debian.org> (2024-03-13):
This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
../../common/scheduler/task.c: In function ‘task_perform’: ../../common/scheduler/task.c:137:25: error: implicit declaration of function ‘clamp’ [-Werror=implicit-function-declaration]
137 | task->backoff = clamp(task->backoff * 2, 60, ODS_SE_MAX_BACKOFF);
| ^~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:601: scheduler/task.o] Error 1
I thought there would be several things but apparently that's just the
one. A quick look upstream shows there are more PRs and more fixups
needed for even newer compilers, but I'm limiting my patch to the bare minimum.
Since that's been open for 10+ days, and since reverse dependencies
could get kicked out of testing, I'm uploading an NMU right now so that
I don't forget, but to DELAYED/2 so there's some room to do things differently if desired. I'm happy to reschedule/cancel if needed.
| Sysop: | Keyop |
|---|---|
| Location: | Huddersfield, West Yorkshire, UK |
| Users: | 297 |
| Nodes: | 16 (2 / 14) |
| Uptime: | 01:45:07 |
| Calls: | 6,666 |
| Calls today: | 4 |
| Files: | 12,212 |
| Messages: | 5,335,487 |