• Bug#1066371: ukwm: FTBFS: default.c:667:15: error: implicit declaration

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 13:10:03 2024
    Source: ukwm
    Version: 1.2.0-2.2
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    /bin/bash ../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/
    freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.
    0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gsettings-desktop-schemas -I/usr/include/json-glib-1.0 -I/
    usr/include/libupower-glib -I/usr/include/gnome-desktop-3.0 -I/usr/include/libxml2 -I/usr/include/startup-notification-1.0 -D_REENTRANT -pthread -I/usr/include/libwacom-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libevdev-1.0/ -I/usr/include/gobject-
    introspection-1.0 -I../../../src -I../../../src -I../../../src/core -I../../../src/ui -I../../../src/backends -I../../../cogl -I../../../cogl -I../../../cogl/cogl -I../../../clutter -I../../../clutter -I../../../clutter/clutter -DUKWM_LIBEXECDIR=\"/usr/
    lib/ukwm\" -DUKWM_LOCALEDIR=\"/usr/share/locale\" -DUKWM_PKGDATADIR=\"/usr/share/ukwm\" -DUKWM_DATADIR=\"/usr/share\" -DG_LOG_DOMAIN=\"ukwm\" -DSN_API_NOT_YET_FROZEN=1 -DUKWM_PLUGIN_DIR=\"/usr/lib/x86_64-linux-gnu/ukwm/plugins\" -Wdate-time -D_FORTIFY_
    SOURCE=2 -fPIC -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-
    prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -c -o default_la-ukui_plugin_generated.lo `test -f 'ukui_plugin_generated.c' || echo './'`ukui_plugin_generated.c
    libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/
    include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/
    include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gsettings-desktop-schemas -I/usr/include/json-glib-1.0 -I/usr/include/libupower-glib -I/usr/
    include/gnome-desktop-3.0 -I/usr/include/libxml2 -I/usr/include/startup-notification-1.0 -D_REENTRANT -pthread -I/usr/include/libwacom-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libevdev-1.0/ -I/usr/include/gobject-introspection-1.0 -I../../../src -I../.
    ./../src -I../../../src/core -I../../../src/ui -I../../../src/backends -I../../../cogl -I../../../cogl -I../../../cogl/cogl -I../../../clutter -I../../../clutter -I../../../clutter/clutter -DUKWM_LIBEXECDIR=\"/usr/lib/ukwm\" -DUKWM_LOCALEDIR=\"/usr/share/
    locale\" -DUKWM_PKGDATADIR=\"/usr/share/ukwm\" -DUKWM_DATADIR=\"/usr/share\" -DG_LOG_DOMAIN=\"ukwm\" -DSN_API_NOT_YET_FROZEN=1 -DUKWM_PLUGIN_DIR=\"/usr/lib/x86_64-linux-gnu/ukwm/plugins\" -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -g -O2 -Werror=implicit-
    function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-
    arith -Wcast-align -Wsign-compare -c default.c -fPIC -DPIC -o .libs/default_la-default.o
    libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/
    include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/
    include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gsettings-desktop-schemas -I/usr/include/json-glib-1.0 -I/usr/include/libupower-glib -I/usr/
    include/gnome-desktop-3.0 -I/usr/include/libxml2 -I/usr/include/startup-notification-1.0 -D_REENTRANT -pthread -I/usr/include/libwacom-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libevdev-1.0/ -I/usr/include/gobject-introspection-1.0 -I../../../src -I../.
    ./../src -I../../../src/core -I../../../src/ui -I../../../src/backends -I../../../cogl -I../../../cogl -I../../../cogl/cogl -I../../../clutter -I../../../clutter -I../../../clutter/clutter -DUKWM_LIBEXECDIR=\"/usr/lib/ukwm\" -DUKWM_LOCALEDIR=\"/usr/share/
    locale\" -DUKWM_PKGDATADIR=\"/usr/share/ukwm\" -DUKWM_DATADIR=\"/usr/share\" -DG_LOG_DOMAIN=\"ukwm\" -DSN_API_NOT_YET_FROZEN=1 -DUKWM_PLUGIN_DIR=\"/usr/lib/x86_64-linux-gnu/ukwm/plugins\" -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -g -O2 -Werror=implicit-
    function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-
    arith -Wcast-align -Wsign-compare -c ukui_plugin_generated.c -fPIC -DPIC -o .libs/default_la-ukui_plugin_generated.o
    In file included from ../../../src/core/screen-private.h:35,
    from ../../../src/core/window-private.h:40,
    from default.c:38: ../../../src/core/display-private.h:225:3: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
    225 | GTimeVal grab_last_moveresize_time;
    | ^~~~~~~~
    In file included from /usr/include/glib-2.0/glib/galloca.h:34,
    from /usr/include/glib-2.0/glib.h:32,
    from ../../../src/meta/compositor.h:23,
    from ../../../src/meta/meta-plugin.h:27,
    from default.c:24: /usr/include/glib-2.0/glib/gtypes.h:580:8: note: declared here
    580 | struct _GTimeVal
    | ^~~~~~~~~
    default.c: In function ‘meta_default_plugin_class_init’:
    default.c:248:3: warning: ‘g_type_class_add_private’ is deprecated [-Wdeprecated-declarations]
    248 | g_type_class_add_private (gobject_class, sizeof (MetaDefaultPluginPrivate));
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    In file included from /usr/include/glib-2.0/gobject/gobject.h:26,
    from /usr/include/glib-2.0/gobject/gbinding.h:31,
    from /usr/include/glib-2.0/glib-object.h:24,
    from ../../../src/meta/boxes.h:25,
    from ../../../src/meta/compositor.h:27: /usr/include/glib-2.0/gobject/gtype.h:1495:10: note: declared here
    1495 | void g_type_class_add_private (gpointer g_class,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    default.c: In function ‘meta_default_plugin_init’:
    default.c:256:13: warning: Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"
    256 | self->priv = priv = META_DEFAULT_PLUGIN_GET_PRIVATE (self);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    default.c: In function ‘ukwm_plugin_get_alt_tab_list’:
    default.c:493:41: warning: passing argument 1 of ‘ukwm_plugin_complete_get_alt_tab_list’ from incompatible pointer type [-Wincompatible-pointer-types]
    493 | ukwm_plugin_complete_get_alt_tab_list(object, invocation, count, gva);
    | ^~~~~~
    | |
    | MetaPlugin * {aka struct _MetaPlugin *}
    In file included from default.c:58:
    ./ukui_plugin_generated.h:52:17: note: expected ‘UkwmPlugin *’ {aka ‘struct _UkwmPlugin *’} but argument is of type ‘MetaPlugin *’ {aka ‘struct _MetaPlugin *’}
    52 | UkwmPlugin *object,
    | ~~~~~~~~~~~~^~~~~~
    default.c: In function ‘ukwm_plugin_activate_window_by_tab_list_index’: default.c:512:62: warning: passing argument 1 of ‘ukwm_plugin_complete_activate_window_by_tab_list_index’ from incompatible pointer type [-Wincompatible-pointer-types]
    512 | ukwm_plugin_complete_activate_window_by_tab_list_index(object, invocation);
    | ^~~~~~
    | |
    | MetaPlugin * {aka struct _MetaPlugin *}
    ./ukui_plugin_generated.h:58:17: note: expected ‘UkwmPlugin *’ {aka ‘struct _UkwmPlugin *’} but argument is of type ‘MetaPlugin *’ {aka ‘struct _MetaPlugin *’}
    58 | UkwmPlugin *object,
    | ~~~~~~~~~~~~^~~~~~
    default.c:522:62: warning: passing argument 1 of ‘ukwm_plugin_complete_activate_window_by_tab_list_index’ from incompatible pointer type [-Wincompatible-pointer-types]
    522 | ukwm_plugin_complete_activate_window_by_tab_list_index(object, invocation);
    | ^~~~~~
    | |
    | MetaPlugin * {aka struct _MetaPlugin *}
    ./ukui_plugin_generated.h:58:17: note: expected ‘UkwmPlugin *’ {aka ‘struct _UkwmPlugin *’} but argument is of type ‘MetaPlugin *’ {aka ‘struct _MetaPlugin *’}
    58 | UkwmPlugin *object,
    | ~~~~~~~~~~~~^~~~~~
    default.c:548:58: warning: passing argument 1 of ‘ukwm_plugin_complete_activate_window_by_tab_list_index’ from incompatible pointer type [-Wincompatible-pointer-types]
    548 | ukwm_plugin_complete_activate_window_by_tab_list_index(object, invocation);
    | ^~~~~~
    | |
    | MetaPlugin * {aka struct _MetaPlugin *}
    ./ukui_plugin_generated.h:58:17: note: expected ‘UkwmPlugin *’ {aka ‘struct _UkwmPlugin *’} but argument is of type ‘MetaPlugin *’ {aka ‘struct _MetaPlugin *’}
    58 | UkwmPlugin *object,
    | ~~~~~~~~~~~~^~~~~~
    default.c:526:23: warning: unused variable ‘tv2’ [-Wunused-variable]
    526 | struct timeval tv1, tv2;
    | ^~~
    default.c:526:18: warning: unused variable ‘tv1’ [-Wunused-variable]
    526 | struct timeval tv1, tv2;
    | ^~~
    default.c: At top level:
    default.c:601:6: warning: no previous prototype for ‘InitUkwmPluginDBusCommServer’ [-Wmissing-prototypes]
    601 | bool InitUkwmPluginDBusCommServer(void)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    default.c:619:6: warning: no previous prototype for ‘ukui_window_switch_monitor’ [-Wmissing-prototypes]
    619 | void ukui_window_switch_monitor(void)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    default.c: In function ‘ukui_window_switch_monitor’:
    default.c:667:15: error: implicit declaration of function ‘waitpid’ [-Werror=implicit-function-declaration]
    667 | waitpid(-1, NULL, WNOHANG);
    | ^~~~~~~
    default.c:667:15: warning: nested extern declaration of ‘waitpid’ [-Wnested-externs]
    default.c: In function ‘start’:
    default.c:701:47: warning: passing argument 3 of ‘pthread_create’ from incompatible pointer type [-Wincompatible-pointer-types]
    701 | err = pthread_create(&monitor_thread, NULL, ukui_window_switch_monitor, NULL);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | void (*)(void)
    In file included from /usr/include/glib-2.0/glib/deprecated/gthread.h:126,
    from /usr/include/glib-2.0/glib.h:115: /usr/include/pthread.h:204:36: note: expected ‘void * (*)(void *)’ but argument is of type ‘void (*)(void)’
    204 | void *(*__start_routine) (void *),
    | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ default.c: In function ‘on_dialog_closed’:
    default.c:1167:3: warning: ‘g_spawn_check_exit_status’ is deprecated: Use 'g_spawn_check_wait_status' instead [-Wdeprecated-declarations]
    1167 | ok = g_spawn_check_exit_status (status, NULL);
    | ^~
    In file included from /usr/include/glib-2.0/glib.h:84: /usr/include/glib-2.0/glib/gspawn.h:315:10: note: declared here
    315 | gboolean g_spawn_check_exit_status (gint wait_status,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~
    default.c: At top level:
    default.c:1112:1: warning: ‘kill_switch_workspace’ defined but not used [-Wunused-function]
    1112 | kill_switch_workspace (MetaPlugin *plugin)
    | ^~~~~~~~~~~~~~~~~~~~~
    default.c:708:1: warning: ‘switch_workspace’ defined but not used [-Wunused-function]
    708 | switch_workspace (MetaPlugin *plugin,
    | ^~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors
    make[5]: *** [Makefile:560: default_la-default.lo] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/ukwm_1.2.0-2.2_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Tue Mar 26 08:30:01 2024
    This is a multi-part message in MIME format...

    Your message dated Tue, 26 Mar 2024 07:19:54 +0000
    with message-id <E1rp16A-00HIos-Ss@fasolo.debian.org>
    and subject line Bug#1066371: fixed in ukwm 1.2.2-1
    has caused the Debian Bug report #1066371,
    regarding ukwm: FTBFS: default.c:667:15: error: implicit declaration of function ‘waitpid’ [-Werror=implicit-function-declaration]
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1066371: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066371
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 13 Mar 2024 11:49:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-106.1 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
    FROMDEVELOPER,FVGT_m_MULTI_ODD,SPF_HELO_NONE,SPF_NONE,
    T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,
    USER_IN_DKIM_WHITELIST autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 63; hammy, 150; neutral, 385; spammy,
    0. spammytokens:
    hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
    0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
    0.000-+--H*RT:311, 0.000-+--H*RT:108
    Return-path: <lucas@debian.org>
    Received: from stravins