Source: silo-llnl
Version: 4.11-3.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

/bin/sh ../../libtool --tag=CC --mode=compile mpicc -DHAVE_CONFIG_H -I. -I../.. -I./../silo -I./../silo -I./../fpzip -DH5_HAVE_FILTER_ZFP -DH5Z_ZFP_AS_LIB -DAS_SILO_BUILTIN -I./../zfp-0.5.5/include -I/usr/include/hdf5/openmpi -I/usr/include/x86_

64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/lib/openmpi/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -
ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wdeclaration-after-statement -c -o silo_hdf5.
lo silo_hdf5.c

libtool: compile: mpicc -DHAVE_CONFIG_H -I. -I../.. -I./../silo -I./../silo -I./../fpzip -DH5_HAVE_FILTER_ZFP -DH5Z_ZFP_AS_LIB -DAS_SILO_BUILTIN -I./../zfp-0.5.5/include -I/usr/include/hdf5/openmpi -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/

x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/lib/openmpi/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=
. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wdeclaration-after-statement -c silo_hdf5.c -fPIC -DPIC -o .libs/silo_hdf5.o

silo_hdf5.c:61:2: warning: #warning DO WE NEED THIS HEADER FILE [-Wcpp]
61 | #warning DO WE NEED THIS HEADER FILE
| ^~~~~~~
In file included from silo_hdf5.c:74:
silo_hdf5_private.h:110:2: warning: #warning REMOVE db_hdf5_CpListedObjects [-Wcpp]
110 | #warning REMOVE db_hdf5_CpListedObjects
| ^~~~~~~
In file included from silo_hdf5_private.h:67:
silo_hdf5.c: In function ‘db_hdf5_get_obj_dsnames’:
silo_hdf5.c:1812:45: warning: passing argument 1 of ‘_db_safe_strdup’ makes pointer from integer without a cast [-Wint-conversion]
1812 | (*dsnames)[i] = strdup(m.MEMNAME[i]); \
| ~~~~~~~~~^~~
| |
| char ./../silo/silo_private.h:939:35: note: in definition of macro ‘strdup’
939 | #define strdup(s) _db_safe_strdup(s)
| ^
silo_hdf5.c:1869:13: note: in expansion of macro ‘DB_OBJ_CASE’
1869 | DB_OBJ_CASE(DB_CURVE, DBcurve_mt, npts?1:1, yvarname)
| ^~~~~~~~~~~
In file included from ./../silo/silo_private.h:79:
./../silo/silo.h:2214:56: note: expected ‘const char *’ but argument is of type ‘char’
2214 | SILO_API extern char * _db_safe_strdup(const char *);
| ^~~~~~~~~~~~ silo_hdf5.c: In function ‘db_hdf5_init’:
silo_hdf5.c:2173:5: error: implicit declaration of function ‘zfp_init_zfp’ [-Werror=implicit-function-declaration]
2173 | zfp_init_zfp();
| ^~~~~~~~~~~~
silo_hdf5.c: In function ‘db_hdf5_InitCallbacks’:
silo_hdf5.c:2799:2: warning: #warning GET RID OF CPLISTEDOBJECTS [-Wcpp]
2799 | #warning GET RID OF CPLISTEDOBJECTS
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_set_compression’:
silo_hdf5.c:3347:2: warning: #warning WHAT ABOUT NULL RETURN FROM DBGETCOMPRESSION [-Wcpp]
3347 | #warning WHAT ABOUT NULL RETURN FROM DBGETCOMPRESSION
| ^~~~~~~
silo_hdf5.c:3378:2: warning: #warning FIX MISSING .compressionMinsize member [-Wcpp]
3378 | #warning FIX MISSING .compressionMinsize member
| ^~~~~~~
silo_hdf5.c:3396:2: warning: #warning QUERY FILE LEVEL COMPRESSION PARAMS HERE [-Wcpp]
3396 | #warning QUERY FILE LEVEL COMPRESSION PARAMS HERE
| ^~~~~~~
silo_hdf5.c: In function ‘load_toc’:
silo_hdf5.c:4121:2: warning: #warning REVISIT THIS CODE BLOCK [-Wcpp]
4121 | #warning REVISIT THIS CODE BLOCK
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_resolvename’:
silo_hdf5.c:4736:2: warning: #warning HARD CODED SIZE HERE [-Wcpp]
4736 | #warning HARD CODED SIZE HERE
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_process_file_options’: silo_hdf5.c:4960:2: warning: #warning FIX ME...THIS NEEDS TO BE CONDITION ON COMPAT MODE WORKS FOR 1.8.0 [-Wcpp]
4960 | #warning FIX ME...THIS NEEDS TO BE CONDITION ON COMPAT MODE WORKS FOR 1.8.0
| ^~~~~~~
silo_hdf5.c:4967:2: warning: #warning SET FRIENDLY NAMES TO 2 but only at file level [-Wcpp]
4967 | #warning SET FRIENDLY NAMES TO 2 but only at file level
| ^~~~~~~
silo_hdf5.c:5004:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]
5004 | #warning REMOVED WINDOWS SPECIFIC CHECK
| ^~~~~~~
silo_hdf5.c:5094:2: warning: #warning DO WE STILL NEED THIS [-Wcpp]
5094 | #warning DO WE STILL NEED THIS
| ^~~~~~~
silo_hdf5.c:5158:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]
5158 | #warning REMOVED WINDOWS SPECIFIC CHECK
| ^~~~~~~
silo_hdf5.c:5433:2: warning: #warning DO WE STILL NEED THIS [-Wcpp]
5433 | #warning DO WE STILL NEED THIS
| ^~~~~~~
silo_hdf5.c:5517:2: warning: #warning FIX THIS [-Wcpp]
5517 | #warning FIX THIS
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_Create’:
silo_hdf5.c:5971:2: warning: #warning BACKWARD COMPAT ISSUE FOR HDF5 [-Wcpp]
5971 | #warning BACKWARD COMPAT ISSUE FOR HDF5
| ^~~~~~~
silo_hdf5.c:6006:2: warning: #warning FIX FILE SCOPE GLOBAL INITIALIZATION [-Wcpp]
6006 | #warning FIX FILE SCOPE GLOBAL INITIALIZATION
| ^~~~~~~
silo_hdf5.c: In function ‘copy_obj’:
silo_hdf5.c:6470:2: warning: #warning WHY THIS SIZE [-Wcpp]
6470 | #warning WHY THIS SIZE
| ^~~~~~~
silo_hdf5.c: At top level:
silo_hdf5.c:6639:2: warning: #warning REMOVE THIS MAYBE [-Wcpp]
6639 | #warning REMOVE THIS MAYBE
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_WriteObject’:
silo_hdf5.c:7376:2: warning: #warning COMPATABILITY ISSUE [-Wcpp]
7376 | #warning COMPATABILITY ISSUE
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_get_var_byte_length’: silo_hdf5.c:7749:2: warning: #warning REMOVED db_perror CALLS [-Wcpp]
7749 | #warning REMOVED db_perror CALLS
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_WriteCKZ’:
silo_hdf5.c:8395:2: warning: #warning WHAT IF EXISTING DATASET WAS COMPRESSED [-Wcpp]
8395 | #warning WHAT IF EXISTING DATASET WAS COMPRESSED
| ^~~~~~~
silo_hdf5.c:8437:2: warning: #warning COMPARE TO -1 OR TO NEGATIVE [-Wcpp]
8437 | #warning COMPARE TO -1 OR TO NEGATIVE
| ^~~~~~~
silo_hdf5.c:8459:2: warning: #warning COMPARE TO -1 OR NEGATIVE [-Wcpp]
8459 | #warning COMPARE TO -1 OR NEGATIVE
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_GetObject’:
silo_hdf5.c:8684:2: warning: #warning THIS IFDEFD CODE IS IN TRANSITION TO BETTER GENERIC OBJECTS [-Wcpp]
8684 | #warning THIS IFDEFD CODE IS IN TRANSITION TO BETTER GENERIC OBJECTS
| ^~~~~~~
silo_hdf5.c:8781:2: warning: #warning REVISIT THIS CLEANUP CODE. IS THERE A BETTER SYMBOLIC VALUE THAN -1 [-Wcpp]
8781 | #warning REVISIT THIS CLEANUP CODE. IS THERE A BETTER SYMBOLIC VALUE THAN -1
| ^~~~~~~
silo_hdf5.c:8786:2: warning: #warning USE FREE() MACRO HERE [-Wcpp]
8786 | #warning USE FREE() MACRO HERE
| ^~~~~~~
silo_hdf5.c:8798:2: warning: #warning USE FREE() MACRO HERE [-Wcpp]
8798 | #warning USE FREE() MACRO HERE
| ^~~~~~~
silo_hdf5.c: In function ‘db_hdf5_PutMultimat’:
silo_hdf5.c:14304:2: warning: #warning REPLACE WITH STRING UTILITIES [-Wcpp] 14304 | #warning REPLACE WITH STRING UTILITIES
| ^~~~~~~
silo_hdf5.c:14342:2: warning: #warning IS THIS TAKEN CARE OF ELSEWHERE [-Wcpp]
14342 | #warning IS THIS TAKEN CARE OF ELSEWHERE
| ^~~~~~~
silo_hdf5.c:14352:2: warning: #warning IS THIS TAKEN CARE OF ELSEWHERE [-Wcpp]
14352 | #warning IS THIS TAKEN CARE OF ELSEWHERE
| ^~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:521: silo_hdf5.lo] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/silo-llnl_4.11-3.1_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Wed, 13 Mar 2024 17:55:06 +0000
with message-id <E1rkSok-007XRq-5N@fasolo.debian.org>
and subject line Bug#1066336: fixed in silo-llnl 4.11-4
has caused the Debian Bug report #1066336,
regarding silo-llnl: FTBFS: silo_hdf5.c:2173:5: error: implicit declaration of function ‘zfp_init_zfp’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1066336: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066336
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 13 Mar 2024 11:49:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-106.1 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
FROMDEVELOPER,FVGT_m_MULTI_ODD,SPF_HELO_NONE,SPF_NONE,
T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,
USER_IN_DKIM_WHITELIST autolearn=ham autolearn_force=no
version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 87; hammy, 150; neutral, 342; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: <lucas@debian.org>
Received: from stravins