1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.RC

  • Bug#1066247: uhub: FTBFS: adcclient.c:178:33: error: implicit declarati

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 13:00:07 2024
    Source: uhub
    Version: 0.4.1-3.2
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/list.c.o -MF CMakeFiles/utils.dir/src/util/list.c.o.d -o CMakeFiles/utils.dir/src/util/list.c.o -c /<<PKGBUILDDIR>>/src/util/list.c
    /<<PKGBUILDDIR>>/src/tools/adcclient.c: In function ‘event_callback’: /<<PKGBUILDDIR>>/src/tools/adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]
    178 | ADC_client_connect_internal(client);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    | ADC_client_connect
    [ 9%] Building C object CMakeFiles/utils.dir/src/util/log.c.o
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/log.c.o -MF CMakeFiles/utils.dir/src/util/log.c.o.d -o CMakeFiles/utils.dir/src/util/log.c.o -c /<<PKGBUILDDIR>>/src/util/log.c
    [ 10%] Building C object CMakeFiles/utils.dir/src/util/memory.c.o
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/memory.c.o -MF CMakeFiles/utils.dir/src/util/memory.c.o.d -o CMakeFiles/utils.dir/src/util/memory.c.o -c /<<PKGBUILDDIR>>/src/util/
    memory.c
    [ 11%] Building C object CMakeFiles/utils.dir/src/util/misc.c.o
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/misc.c.o -MF CMakeFiles/utils.dir/src/util/misc.c.o.d -o CMakeFiles/utils.dir/src/util/misc.c.o -c /<<PKGBUILDDIR>>/src/util/misc.c
    [ 13%] Building C object CMakeFiles/utils.dir/src/util/rbtree.c.o
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/rbtree.c.o -MF CMakeFiles/utils.dir/src/util/rbtree.c.o.d -o CMakeFiles/utils.dir/src/util/rbtree.c.o -c /<<PKGBUILDDIR>>/src/util/
    rbtree.c
    [ 14%] Building C object CMakeFiles/utils.dir/src/util/threads.c.o /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/threads.c.o -MF CMakeFiles/utils.dir/src/util/threads.c.o.d -o CMakeFiles/utils.dir/src/util/threads.c.o -c /<<PKGBUILDDIR>>/src/util/
    threads.c
    [ 15%] Building C object CMakeFiles/utils.dir/src/util/tiger.c.o
    /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<<PKGBUILDDIR>>/src -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -
    Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT CMakeFiles/utils.dir/src/util/tiger.c.o -MF CMakeFiles/utils.dir/src/util/tiger.c.o.d -o CMakeFiles/utils.dir/src/util/tiger.c.o -c /<<PKGBUILDDIR>>/src/util/tiger.c
    cc1: some warnings being treated as errors
    make[3]: *** [CMakeFiles/adcclient.dir/build.make:79: CMakeFiles/adcclient.dir/src/tools/adcclient.c.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/uhub_0.4.1-3.2_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Zixing Liu@21:1/5 to All on Mon Apr 15 21:40:01 2024
    This is a multi-part MIME message sent by reportbug.


    Package: uhub
    Followup-For: Bug #1066247
    User: ubuntu-devel@lists.ubuntu.com
    Usertags: origin-ubuntu noble ubuntu-patch
    Control: tags -1 patch

    Dear Maintainer,

    In Ubuntu, the attached patch was applied to achieve the following:

    * debian/patches/implicit-declarations.patch: Add missing function
    prototypes. (LP: #2061039).
    * debian/patches/riscv64-fix-ftbfs.patch: Add RISC-V architecture to
    CPU list. Thanks to Eric Long <i@hack3r.moe>. (LP: #2061039).


    Thanks for considering the patch.


    -- System Information:
    Debian Release: bookworm/sid
    APT prefers jammy-updates
    APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
    Architecture: amd64 (x86_64)
    Foreign Architectures: i386

    Kernel: Linux 6.5.0-27-generic (SMP w/10 CPU threads; PREEMPT)
    Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
    Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en
    Shell: /bin/sh linked to /usr/bin/dash
    Init: systemd (via /run/systemd/system)
    LSM: AppArmor: enabled

    diff -Nru uhub-0.4.1/debian/patches/implicit-declarations.patch uhub-0.4.1/debian/patches/implicit-declarations.patch
    --- uhub-0.4.1/debian/patches/implicit-declarations.patch 1969-12-31 17:00:00.000000000 -0700
    +++ uhub-0.4.1/debian/patches/implicit-declarations.patch 2024-04-15 12:08:31.000000000 -0600
    @@ -0,0 +1,20 @@
    +Description: Add missing function prototypes
    + This fixes FTBFS on armhf
    +Author: Zixing Liu <zixing.liu@canonical.com>
    +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066247 +Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/uhub/+bug/2061039 +Forwarded: no
    +Last-Update: 2024-04-15
    +---
    +Index: uhub/src/tools/adcclient.c +===================================================================
    +--- uhub.orig/src/tools/adcclient.c
    ++++ uhub/src/tools/adcclient.c
    +@@ -88,6 +88,7 @@ static void ADC_client_on_login(struct A
    + static int ADC_client_parse_address(struct ADC_client* client, const char* arg);
    + static int ADC_client_on_recv_line(struct ADC_client* client, const char* line, size_t length);
    + static int ADC_client_send_queue(struct ADC_client* client);
    ++int ADC_cli
  • From Debian Bug Tracking System@21:1/5 to All on Mon Apr 15 21:40:02 2024
    Processing control commands:

    tags -1 patch
    Bug #1066247 [src:uhub] uhub: FTBFS: adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]
    Added tag(s) patch.

    --
    1066247: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066247
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)