Source: gtk-chtheme
Version: 0.3.1-6.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/

include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/
include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 -pthread -DGTK_DISABLE_BROKEN -DGTK_DISABLE_DEPRECATED -DPROJNAME='"Gtk+ 2.0 Change Theme"' -DVERSION='"0.3.1"'
-c -o main.o main.c

In file included from font_sel.c:19:
main.h:29:13: warning: ‘backup_gtkrc’ declared ‘static’ but never defined [-Wunused-function]
29 | static void backup_gtkrc(gchar *path_to_gtkrc);
| ^~~~~~~~~~~~
In file included from mainwin.c:19:
main.h:29:13: warning: ‘backup_gtkrc’ declared ‘static’ but never defined [-Wunused-function]
29 | static void backup_gtkrc(gchar *path_to_gtkrc);
| ^~~~~~~~~~~~
theme_sel.c: In function ‘create_theme_sel’:
theme_sel.c:113:5: error: implicit declaration of function ‘gtk_timeout_add’; did you mean ‘g_timeout_add’? [-Werror=implicit-function-declaration]
113 | gtk_timeout_add(0, (GSourceFunc)theme_list_focus, theme_list);
| ^~~~~~~~~~~~~~~
| g_timeout_add
In file included from theme_sel.c:20:
main.h: At top level:
main.h:29:13: warning: ‘backup_gtkrc’ declared ‘static’ but never defined [-Wunused-function]
29 | static void backup_gtkrc(gchar *path_to_gtkrc);
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [<builtin>: theme_sel.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/gtk-chtheme_0.3.1-6.1_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: gtk-chtheme
Followup-For: Bug #1066222
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

--
Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

diff -Nru gtk-chtheme-0.3.1/debian/patches/no-implicit-declarations.patch gtk-chtheme-0.3.1/debian/patches/no-implicit-declarations.patch
--- gtk-chtheme-0.3.1/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.000000000 -0800
+++ gtk-chtheme-0.3.1/debian/patches/no-implicit-declarations.patch 2024-04-09 22:44:20.000000000 -0700
@@ -0,0 +1,19 @@
+Description: don't set GTK_DISABLE_DEPRECATED, deprecated APIs in use. +Author: Steve Langasek <steve.langasek@canonical.com>
+Bug-Debian: https://bugs.debian.org/1066222
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: gtk-chtheme-0.3.1/Makefile +===================================================================
+--- gtk-chtheme-0.3.1.orig/Makefile
++++ gtk-chtheme-0.3.1/Makefile
+@@ -5,7 +5,7 @@
+
+ LDFLAGS = $(shell $(PKG_CONFIG) --libs gtk+-2.0)
+ CFLAGS += -Wall
+-CFLAGS += $(shell $(PKG_CONFIG) --cflags gtk+-2.0) -DGTK_DISABLE_BROKEN -DGTK_DISABLE_DEPRECATED
++CFLAGS += $(shell $(PKG_CONFIG) --cflags gtk+-2.0) -DGTK_DISABLE_BROKEN
+ CFLAGS += -DPROJNAME='"$(PROJNAME)"' -DVERSION='"$(VERSION)"'
+ CPPFLAGS =
+ CXXFLAGS =
diff -Nru gtk-chtheme-0.3.1/debian/patc

Processing control commands:

tags -1 patch

Bug #1066222 [src:gtk-chtheme] gtk-chtheme: FTBFS: theme_sel.c:113:5: error: implicit declaration of function ‘gtk_timeout_add’; did you mean ‘g_timeout_add’? [-Werror=implicit-function-declaration]
Added tag(s) patch.

--
1066222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066222
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Thu, 18 Apr 2024 15:20:16 +0000
with message-id <E1rxTYe-002AFn-JS@fasolo.debian.org>
and subject line Bug#1066222: fixed in gtk-chtheme 0.3.1-6.2
has caused the Debian Bug report #1066222,
regarding gtk-chtheme: FTBFS: theme_sel.c:113:5: error: implicit declaration of function ‘gtk_timeout_add’; did you mean ‘g_timeout_add’? [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1066222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066222
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 13 Mar 2024 11:48:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-106.2 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,
USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST autolearn=ham
autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 150; neutral, 189; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: <lucas@debian.org>
Received: from stravinsky.debian.org ([2001:41b8:2