• Bug#1066215: soundmodem: FTBFS: kisspkt.c:762:9: error: implicit declar

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 13:00:04 2024
    Source: soundmodem
    Version: 0.20-6
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libxml2 -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -
    fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o audiofilein.o audiofilein.c
    kisspkt.c: In function ‘kiss_input’:
    kisspkt.c:505:14: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
    505 | endp = chan->pkt.kiss.ibuf + chan->pkt.kiss.ibufptr;
    | ^
    kisspkt.c:514:38: warning: pointer targets in passing argument 2 of ‘kiss_decode’ differ in signedness [-Wpointer-sign]
    514 | kiss_decode(chan, cp1+1, cp2-cp1-1);
    | ~~~^~
    | |
    | char *
    kisspkt.c:451:62: note: expected ‘u_int8_t *’ {aka ‘unsigned char *’} but argument is of type ‘char *’
    451 | static void kiss_decode(struct modemchannel *chan, u_int8_t *b, int len)
    | ~~~~~~~~~~^ kisspkt.c: In function ‘p3dreceive’:
    kisspkt.c:597:22: warning: unused variable ‘i’ [-Wunused-variable]
    597 | unsigned int i;
    | ^
    kisspkt.c: In function ‘pktinit’:
    kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration]
    762 | fchmod(slave, 0660);
    | ^~~~~~
    gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libxml2 -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -
    fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o chansim.o chansim.c
    gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libxml2 -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -
    fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o ptt.o ptt.c
    audioio.c: In function ‘iotransmitstop’:
    audioio.c:669:25: warning: unused variable ‘j’ [-Wunused-variable]
    669 | unsigned int i, j;
    | ^
    audioio.c:669:22: warning: unused variable ‘i’ [-Wunused-variable]
    669 | unsigned int i, j;
    | ^
    audioio.c:668:15: warning: unused variable ‘sbuf’ [-Wunused-variable]
    668 | short sbuf[256];
    | ^~~~
    alsaio.c: In function ‘open_alsa’:
    alsaio.c:256:9: warning: ‘snd_pcm_sw_params_set_xfer_align’ is deprecated [-Wdeprecated-declarations]
    256 | err = snd_pcm_sw_params_set_xfer_align(pcm_handle, swparams, 1);
    | ^~~
    In file included from /usr/include/alsa/asoundlib.h:56,
    from alsaio.c:55:
    /usr/include/alsa/pcm.h:1389:5: note: declared here
    1389 | int snd_pcm_sw_params_set_xfer_align(snd_pcm_t *pcm, snd_pcm_sw_params_t *params, snd_pcm_uframes_t val) __attribute__((deprecated));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    audioio.c: In function ‘iotxend’:
    audioio.c:293:9: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    293 | read(audioio->audiofd, &s, sizeof(s));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    audioio.c: In function ‘iotxstart’:
    audioio.c:302:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    302 | write(audioio->audiofd, &s, sizeof(s));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ptt.c: In function ‘pttinit_sysfsgpio’:
    ptt.c:134:25: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    134 | write(fd, "low", 3);
    | ^~~~~~~~~~~~~~~~~~~
    ptt.c: In function ‘pttsetptt’:
    ptt.c:397:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    397 | write(state->u.fd, state->ptt ? "1" : "0", 1);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libxml2 -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -
    fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o pktberr.o pktberr.c
    ptt.c: In function ‘pttinit’:
    ptt.c:207:17: warning: ‘__builtin_strncpy’ specified bound 512 equals destination size [-Wstringop-truncation]
    207 | strncpy(state->u.rig_ptr->state.rigport.pathname, path, FILPATHLEN);
    | ^
    rm -f libcommon.a
    ar cru libcommon.a simd.o snprintpkt.o
    ar: `u' modifier ignored since `D' is the default (see `U')
    ranlib libcommon.a
    rm -f liblog.a
    ar cru liblog.a log.o
    ar: `u' modifier ignored since `D' is the default (see `U')
    ranlib liblog.a
    rm -f libpttio.a
    ar cru libpttio.a ptt.o
    ar: `u' modifier ignored since `D' is the default (see `U')
    ranlib libpttio.a
    rm -f libaudioio.a
    ar cru libaudioio.a audioio.o alsaio.o audiofilein.o chansim.o
    ar: `u' modifier ignored since `D' is the default (see `U')
    ranlib libaudioio.a
    gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -Wl,-z,relro -o chansim simd.o pktsimple.o main.o ../
    afsk/libafsk.a ../fsk/libfsk.a ../pammodem/libpam.a ../pskmodem/libpsk.a ../newqpsk/libnewqpsk.a ../p3dmodem/libp3d.a liblog.a libaudioio.a libpttio.a ../matlib/libmat.a ../libmisc/libmisc.a -lxml2 -lpthread -lutil -laudiofile -lhamlib -lasound -lm -
    ldl -lpthread -lm
    gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -Wl,-z,relro -o chansimberr simd.o pktberr.o main.o ../
    afsk/libafsk.a ../fsk/libfsk.a ../pammodem/libpam.a ../pskmodem/libpsk.a ../newqpsk/libnewqpsk.a ../p3dmodem/libp3d.a liblog.a libaudioio.a libpttio.a ../matlib/libmat.a ../libmisc/libmisc.a -lxml2 -lpthread -lutil -laudiofile -lhamlib -lasound -lm -
    ldl -lpthread -lm
    kisspkt.c:750:9: warning: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
    750 | strncpy(chan->pkt.kiss.ifname, file, sizeof(chan->pkt.kiss.ifname));
    | ^
    kisspkt.c: In function ‘pktinitmkiss’:
    kisspkt.c:844:9: warning: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
    844 | strncpy(chan->pkt.kiss.ifname, params[0], sizeof(chan->pkt.kiss.ifname));
    | ^
    cc1: some warnings being treated as errors
    make[3]: *** [Makefile:604: kisspkt.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/soundmodem_0.20-6_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 25 05:30:01 2024
    Processing control commands:

    tag -1 pending
    Bug #1066215 [src:soundmodem] soundmodem: FTBFS: kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration]
    Added tag(s) pending.

    --
    1066215: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066215
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Tony Mancill@21:1/5 to All on Mon Mar 25 05:30:01 2024
    Control: tag -1 pending

    Hello,

    Bug #1066215 in soundmodem reported by you has been fixed in the
    Git repository and is awaiting an upload. You can see the commit
    message below and you can check the diff of the fix at:

    https://salsa.debian.org/debian-hamradio-team/soundmodem/-/commit/a90a68aa72b15f277f08fbef758c08fbbeed04e8

    ------------------------------------------------------------------------
    Add patch for implicit-declaration warning (Closes: #1066215) ------------------------------------------------------------------------

    (this message was generated automatically)
    --
    Greetings

    https://bugs.debian.org/1066215

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Mon Mar 25 07:00:01 2024
    This is a multi-part message in MIME format...

    Your message dated Mon, 25 Mar 2024 05:17:29 +0000
    with message-id <E1roci9-00BXN8-TT@fasolo.debian.org>
    and subject line Bug#1066215: fixed in soundmodem 0.20-7
    has caused the Debian Bug report #1066215,
    regarding soundmodem: FTBFS: kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration]
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1066215: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066215
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 13 Mar 2024 11:48:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-106.2 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
    FVGT_m_MULTI_ODD,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
    UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST
    autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 152; hammy, 150; neutral, 274; spammy,
    0. spammytokens:
    hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
    0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
    0.000-+--H*RT:311, 0.000-+--H*RT:108
    Return-path: <lucas@debian.org>
    Received: from stravinsky.debi