• Bug#1066264: cdrkit: FTBFS: genisoimage.c:1512:17: error: implicit decl

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 13:00:03 2024
    Source: cdrkit
    Version: 9:1.1.11-3.4
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    make[5]: Entering directory '/<<PKGBUILDDIR>>/build'
    [ 59%] Building C object genisoimage/CMakeFiles/isodump.dir/diag/isodump.o
    [ 59%] Building C object genisoimage/CMakeFiles/isoinfo.dir/diag/isoinfo.o
    [ 59%] Building C object genisoimage/CMakeFiles/genisoimage.dir/genisoimage.o [ 59%] Building C object wodim/CMakeFiles/wodim.dir/wodim.o
    [ 59%] Building C object genisoimage/CMakeFiles/isodebug.dir/diag/isodebug.o [ 60%] Building C object icedax/CMakeFiles/icedax.dir/aifc.o
    [ 61%] Building C object genisoimage/CMakeFiles/isovfy.dir/diag/isovfy.o
    [ 61%] Building C object genisoimage/CMakeFiles/devdump.dir/diag/dump.o /<<PKGBUILDDIR>>/genisoimage/genisoimage.c: In function ‘main’: /<<PKGBUILDDIR>>/genisoimage/genisoimage.c:1512:17: error: implicit declaration of function ‘parse_checksum_algo’ [-Werror=implicit-function-declaration]
    1512 | if (parse_checksum_algo(optarg, &checksum_algo_iso))
    | ^~~~~~~~~~~~~~~~~~~
    [ 61%] Building C object genisoimage/CMakeFiles/isodebug.dir/scsi.o
    [ 61%] Building C object icedax/CMakeFiles/icedax.dir/aiff.o
    [ 61%] Building C object genisoimage/CMakeFiles/devdump.dir/scsi.o
    [ 61%] Building C object icedax/CMakeFiles/icedax.dir/base64.o
    [ 62%] Building C object genisoimage/CMakeFiles/isodump.dir/scsi.o
    [ 63%] Linking C executable isodebug
    [ 64%] Linking C executable devdump
    [ 65%] Building C object icedax/CMakeFiles/icedax.dir/icedax.o
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 65%] Building C object genisoimage/CMakeFiles/isovfy.dir/scsi.o
    [ 65%] Built target isodebug
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 66%] Building C object wodim/CMakeFiles/wodim.dir/audiosize.o
    [ 66%] Built target devdump
    make[5]: Entering directory '/<<PKGBUILDDIR>>/build'
    [ 66%] Linking C executable isodump
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    make[5]: Entering directory '/<<PKGBUILDDIR>>/build'
    [ 67%] Building C object readom/CMakeFiles/readom.dir/io.o
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 68%] Building C object genisoimage/CMakeFiles/isoinfo.dir/scsi.o
    [ 68%] Linking C executable isovfy
    [ 68%] Built target isodump
    make[5]: Entering directory '/<<PKGBUILDDIR>>/build'
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    make[5]: Entering directory '/<<PKGBUILDDIR>>/build'
    [ 68%] Building C object wodim/CMakeFiles/wodim.dir/auinfo.o
    [ 69%] Building C object netscsid/CMakeFiles/netscsid.dir/netscsid.o
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 69%] Built target isovfy
    [ 69%] Building C object wodim/CMakeFiles/wodim.dir/cdr_drv.o
    [ 69%] Linking C executable isoinfo
    [ 69%] Building C object readom/CMakeFiles/readom.dir/readom.o
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 69%] Built target isoinfo
    [ 70%] Building C object wodim/CMakeFiles/wodim.dir/cdtext.o
    [ 70%] Building C object wodim/CMakeFiles/wodim.dir/clone.o
    [ 70%] Linking C executable netscsid
    [ 71%] Building C object wodim/CMakeFiles/wodim.dir/crc16.o
    make[5]: Leaving directory '/<<PKGBUILDDIR>>/build'
    [ 71%] Building C object wodim/CMakeFiles/wodim.dir/cue.o
    [ 71%] Built target netscsid
    [ 71%] Building C object wodim/CMakeFiles/wodim.dir/diskid.o
    [ 71%] Building C object wodim/CMakeFiles/wodim.dir/drv_jvc.o
    [ 72%] Building C object wodim/CMakeFiles/wodim.dir/drv_7501.o
    [ 73%] Building C object wodim/CMakeFiles/wodim.dir/drv_mmc.o /<<PKGBUILDDIR>>/wodim/cue.c: In function ‘parse_file.isra’: /<<PKGBUILDDIR>>/wodim/cue.c:477:39: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
    477 | "%s/%s", cname, word);
    | ^ /<<PKGBUILDDIR>>/wodim/cue.c:476:25: note: ‘snprintf’ output 2 or more bytes (assuming 1025) into a destination of size 1024
    476 | snprintf(newname, sizeof (newname),
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    477 | "%s/%s", cname, word);
    | ~~~~~~~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors
    make[5]: *** [genisoimage/CMakeFiles/genisoimage.dir/build.make:76: genisoimage/CMakeFiles/genisoimage.dir/genisoimage.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/cdrkit_1.1.11-3.4_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Debian Bug Tracking System@21:1/5 to All on Thu Mar 14 18:00:01 2024
    Processing control commands:

    tags 1066264 + patch
    Bug #1066264 [src:cdrkit] cdrkit: FTBFS: genisoimage.c:1512:17: error: implicit declaration of function ‘parse_checksum_algo’ [-Werror=implicit-function-declaration]
    Added tag(s) patch.
    tags 1066264 + pending
    Bug #1066264 [src:cdrkit] cdrkit: FTBFS: genisoimage.c:1512:17: error: implicit declaration of function ‘parse_checksum_algo’ [-Werror=implicit-function-declaration]
    Added tag(s) pending.

    --
    1066264: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066264
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andrey Rakhmatullin@21:1/5 to All on Thu Mar 14 18:00:01 2024
    --45jEbdlLuNStGuLd
    Content-Type: text/plain; charset=utf-8
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    Control: tags 1066264 + patch
    Control: tags 1066264 + pending

    Dear maintainer,

    I've prepared an NMU for cdrkit (versioned as 9:1.1.11-3.5) and
    uploaded it to DELAYED/4. Please feel free to tell me if I
    should delay it longer.

    Regards.


    --
    WBR, wRAR

    --45jEbdlLuNStGuLd
    Content-Type: text/x-diff; charset=utf-8
    Content-Disposition: attachment; filename="cdrkit-1.1.11-3.5-nmu.diff" Content-Transfer-Encoding: quoted-printable

    diff -Nru cdrkit-1.1.11/debian/changelog cdrkit-1.1.11/debian/changelog
    --- cdrkit-1.1.11/debian/changelog 2022-06-24 19:56:39.000000000 +0500
    +++ cdrkit-1.1.11/debian/changelog 2024-03-14 21:53:13.000000000 +0500
    @@ -1,3 +1,10 @@
    +cdrkit (9:1.1.11-3.5) unstable; urgency=medium
    +
    + * Non-maintainer upload.
    + * Fix FTBFS with -Werror=implicit-function-declaration (Closes: #1066264).
    +
    + -- Andrey Rakhmatullin <wrar@debian.org> Thu, 14 Mar 2024 21:53:13 +0500
    +
    cdrkit (9:1.1.11-3.4) unstable; urgency=low

    * Non-maintainer upload.
    diff -Nru cdrkit-1.1.11/debian/patches/fix-implicit-function-declaration.patch cdrkit-1.1.11/debian/patches/fix-implicit-function-declaration.patch
    --- cdrkit-1.1.11/debian/patches/fix-implicit-function-declaration.patch 1970-01-01 05:00:00.000000000 +0500
    +++ cdrkit
  • From Debian Bug Tracking System@21:1/5 to All on Fri Mar 15 07:30:01 2024
    This is a multi-part message in MIME format...

    Your message dated Fri, 15 Mar 2024 06:19:12 +0000
    with message-id <E1rl0uO-00Fe8D-4H@fasolo.debian.org>
    and subject line Bug#1066264: fixed in cdrkit 9:1.1.11-3.5
    has caused the Debian Bug report #1066264,
    regarding cdrkit: FTBFS: genisoimage.c:1512:17: error: implicit declaration of function ‘parse_checksum_algo’ [-Werror=implicit-function-declaration]
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1066264: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066264
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 13 Mar 2024 11:49:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-106.2 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
    SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,
    USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST autolearn=ham
    autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 122; hammy, 150; neutral, 170; spammy,
    0. spammytokens:
    hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
    0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
    0.000-+--H*RT:311, 0.000-+--H*RT:108
    Return-path: <lucas@debian.org>
    Received: from stravinsky.debian.org ([2001:41b8: