Source: vde2
Version: 2.3.2+r586-9.1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramacher@debian.org

https://buildd.debian.org/status/fetch.php?pkg=vde2&arch=armel&ver=2.3.2%2Br586-9.1%2Bb1&stamp=1709997351&raw=0

libvdetap.c:147:31: warning: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Wformat-truncation=]
147 | snprintf(buf,16,"%s_%s",ifr->ifr_name,suffix);
| ^
In file included from /usr/include/stdio.h:906,
from libvdetap.c:6:
In function ‘snprintf’,
inlined from ‘getvdeopt’ at libvdetap.c:147:2: /usr/include/arm-linux-gnueabi/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output 2 or more bytes (assuming 17) into a destination of size 16
54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
55 | __glibc_objsize (__s), __fmt,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
56 | __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~
/tmp/ccwOo5J4.s: Assembler messages:
/tmp/ccwOo5J4.s:341: Error: symbol `open64' is already defined
make[3]: *** [Makefile:530: libvdetap_la-libvdetap.lo] Error 1

Cheers
--
Sebastian Ramacher

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: vde2
Version: 2.3.2+r586-9.1
Followup-For: Bug #1065951
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hudson@ubuntu.com
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

* Undefine _FILE_OFFSET_BITS and _TIME_BITS in libvdetap.c so the library's
interposition of open/open64 still works.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
APT prefers mantic-updates
APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-25-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru vde2-2.3.2+r586/debian/patches/interposition-vs-lfs.patch vde2-2.3.2+r586/debian/patches/interposition-vs-lfs.patch
--- vde2-2.3.2+r586/debian/patches/interposition-vs-lfs.patch 1970-01-01 12:00:00.000000000 +1200
+++ vde2-2.3.2+r586/debian/patches/interposition-vs-lfs.patch 2024-03-20 09:33:55.000000000 +1300
@@ -0,0 +1,22 @@
+Description: Undo lfs/time64 defines in libvdetap.c
+ Building with these macros defines interferes with this files attempt to
+ interpose both open and open64
+Author: Michael Hudson-Doyle <michael.hudson@ubuntu.com>
+Forwarded: no
+Last-Update: 2024-03-20
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/vdetaplib/libvdetap.c
++++ b/src/vdetaplib/libvdetap.c
+@@ -1,6 +1,11 @@
+ /* Copyright 2004 Renzo Davoli
+ * Reseased under the GPLv2 */
+
++/* Building with these macros defines interferes with this files attempt to ++ interpose both open and open64 */
++#undef _FILE_OFFSET_BITS
++#undef _TIME_BITS
++
+ #define _GNU_SOURCE
+ #include <dlfcn.h>
+ #include <stdio.h>
diff -Nru vde2-2.3.2+r586/debian/patches/series vde2-2.3.2+r586/debian/p

Processing control commands:

tags -1 patch

Bug #1065951 [src:vde2] vde: FTBFS on arm{el,hf}: /tmp/ccwOo5J4.s:341: Error: symbol `open64' is already defined
Added tag(s) patch.

--
1065951: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065951
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing commands for control@bugs.debian.org:

found 1065951 vde2/2.3.2+r586-9

Bug #1065951 [src:vde2] vde: FTBFS on arm{el,hf}: /tmp/ccwOo5J4.s:341: Error: symbol `open64' is already defined
Marked as found in versions vde2/2.3.2+r586-9.

End of message, stopping processing here.

Please contact me if you need assistance.
--
1065951: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065951
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi,

Just in case it helps, I've applied Michael's patch, and opened an MR on salsa:

https://salsa.debian.org/virtualsquare-team/vde2/-/merge_requests/6

Cheers, Phil.
--
Philip Hands -- https://hands.com/~phil

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Mon, 15 Apr 2024 05:04:44 +0000
with message-id <E1rwEWK-002YOJ-8T@fasolo.debian.org>
and subject line Bug#1065951: fixed in vde2 2.3.2+r586-10
has caused the Debian Bug report #1065951,
regarding vde: FTBFS on arm{el,hf}: /tmp/ccwOo5J4.s:341: Error: symbol `open64' is already defined
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1065951: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065951
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 10 Mar 2024 21:19:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-106.2 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROMDEVELOPER,
SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,
USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST autolearn=ham
autolearn_force=no version=3.4.6-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 150; neutral, 48; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:311, 0.000-+--H*RT:108
Return-path: <sramacher@debian.org>
Received: from stravinsky.debian.org ([2001:41b