Source: libspf2
Version: 1.2.10-8.1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramacher@debian.org

https://buildd.debian.org/status/fetch.php?pkg=libspf2&arch=armhf&ver=1.2.10-8.1&stamp=1709162644&raw=0

/bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/include -I../../src -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -
ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -Wall -MT spf_utils.lo -MD -MP -MF .deps/spf_utils.Tpo -c -o spf_utils.lo spf_utils.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/include -I../../src -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -Wall -MT spf_utils.lo -MD -MP -MF .deps/spf_utils.Tpo -c spf_utils.c -fPIC -DPIC -o .libs/spf_utils.o
spf_utils.c: In function ‘SPF_recalloc’:
spf_utils.c:207:9: error: implicit declaration of function ‘memset’ [-Werror=implicit-function-declaration]
207 | memset(*bufp, '\0', *buflenp);
| ^~~~~~
spf_utils.c:32:1: note: include ‘<string.h>’ or provide a declaration of ‘memset’
31 | #include "spf_internal.h"
+++ |+#include <string.h>
32 |
spf_utils.c:207:9: warning: incompatible implicit declaration of built-in function ‘memset’ [-Wbuiltin-declaration-mismatch]
207 | memset(*bufp, '\0', *buflenp);
| ^~~~~~
spf_utils.c:207:9: note: include ‘<string.h>’ or provide a declaration of ‘memset’
cc1: some warnings being treated as errors
make[5]: *** [Makefile:549: spf_utils.lo] Error 1

Cheers
--
Sebastian Ramacher

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Processing control commands:

tags -1 patch

Bug #1065792 [src:libspf2] libspf2: FTBFS on arm{el,hf}: spf_utils.c:207:9: error: implicit declaration of function ‘memset’ [-Werror=implicit-function-declaration]
Added tag(s) patch.

--
1065792: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065792
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: libspf2
Followup-For: Bug #1065792
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hudson@ubuntu.com
Control: tags -1 patch

Dear Maintainer,


In Ubuntu, I just uploaded the following rather than try to be in any
way clever:


* d/patches/fix-include.patch: Include string.h in spf_utils.c to get a
declaration for memset(). (Closes: #1065792, #1066276)


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
APT prefers mantic-updates
APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-25-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru libspf2-1.2.10/debian/patches/fix-include.patch libspf2-1.2.10/debian/patches/fix-include.patch
--- libspf2-1.2.10/debian/patches/fix-include.patch 1970-01-01 12:00:00.000000000 +1200
+++ libspf2-1.2.10/debian/patches/fix-include.patch 2024-03-20 13:27:19.000000000 +1300
@@ -0,0 +1,10 @@
+--- a/src/libspf2/spf_utils.c
++++ b/src/libspf2/spf_utils.c
+@@ -19,6 +19,7 @@
+ #ifdef STDC_HEADERS
+ # include <stdlib.h> /* malloc / free */
+ # include <ctype.h> /* isupper / tolower */
++# include <string.h> /* memset */
+ #endif
+
+ #ifdef HAVE_MEMORY_H
diff -Nru libspf2-1.2.10/debian/patches/series libspf2-1.2.10/debian/patches/series
--- libspf2-1.2.10/debian/patches/series 2023-10-23 05:33:14.000000000 +1300
+++ libspf2-1.2.10/debian/patches/series 2024-03-20 13:27:01.000000000 +1300
@@ -7,3 +7,4 @@
Fixed-reverse-macro-modifier.patch
no-libreplace.patch
spf_compile.c-more-correct-size-of-ds_avail.patch
+fix-include.patch

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Mon, 25 Mar 2024 11:05:40 +0000
with message-id <E1roi96-00Cyme-4F@fasolo.debian.org>
and subject line Bug#1065792: fixed in libspf2 1.2.10-8.2
has caused the Debian Bug report #1065792,
regarding libspf2: FTBFS on arm{el,hf}: spf_utils.c:207:9: error: implicit declaration of function ‘memset’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1065792: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065792
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 9 Mar 2024 21:42:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-105.7 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,
FROMDEVELOPER,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
UNPARSEABLE_RELAY,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST
autolearn=ham autolearn_force=no
version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 26; hammy, 150; neutral, 63; spammy,
0. spammytokens:
hammytokens:0.000-+--Hx-spam-relays-external:sk:stravin,
0.000-+--H*RT:sk:stravin, 0.000-+--Hx-spam-relays-external:311,
0.000-+--H*RT:108, 0.000-+--H*RT:311
Return-path: <sramacher@debian.org>
Received: from stravinsky.debian.org ([