• Bug#1065046: ace-of-penguins: FTBFS on armhf with implicit function dec

    From Steve Langasek@21:1/5 to All on Thu Feb 29 11:10:01 2024
    This is a multi-part MIME message sent by reportbug.


    Package: ace-of-penguins
    Version: 1.5~rc2-5
    Followup-For: Bug #1065046
    User: ubuntu-devel@lists.ubuntu.com
    Usertags: origin-ubuntu noble ubuntu-patch
    Control: tags -1 patch

    Oops, after this failure there was a second one. Updated patch attached.

    This time build-tested locally with DEB_CFLAGS_APPEND=-Werror=implicit-function-declaration before submitting...

    --
    Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

    diff -Nru ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
    --- ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch 1969-12-31 16:00:00.000000000 -0800
    +++ ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch 2024-02-28 23:00:15.000000000 -0800
    @@ -0,0 +1,43 @@
    +Description: fix missing function declaration
    + 64-bit time_t requires use of -Werror=implicit-function-declaration,
    + and we have one here - isgraph(). Include the standard header to fix
    + the build failure.
    +Author: Steve Langasek <steve.langasek@canonical.com>
    +Last-Update: 2024-02-28
    +Forwarded: no
    +Index: ace-of-penguins-1.5~rc2/lib/make-imglib.c +===================================================================
    +--- ace-of-penguins-1.5~rc2.orig/lib/make-imglib.c
    ++++ ace-of-penguins-1.5~rc2/lib/make-imglib.c
    +@@ -5,6 +5,7 @@
    + #include <sys/stat.h>
    + #include <unistd.h>
    + #include <dirent.h>
    ++#include <ctype.h>
    +
    + #include <png.h>
    +
    +Index: ace-of-penguins-1.5~rc2/lib/imagelib.c +===============================================