Control: tags -1 + moreinfo

Hi Helmut,

iproute2 is Priority: important, which according to Policy §2.5 means
that it is generally expected to be present on a Debian system. Do you
have a specific use case where for some reason you don't have iproute2 installed?

I'm initially reluctant to explicitly list iproute2 as a dependency
for Incus unless there's some very compelling reason.

Mathias

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE1Bp60H32xfynSJ8cKe7i1uz0QvkFAmXdO9UACgkQKe7i1uz0 QvnfSQ/+Nms+lY2KuIu76ZH9lnxgbm82Ssl1t1yy+mlntSyfoIavCc7EVNg4WJAB wDciB5xVtkB0hh/q6ucXvOFjCqsv/twYrWQqBtDJ9KRis6YjeymBwwF81J7h9EeE /P134uhEu+fy3zhUJFDJxa8rD9vdUw0tor5Sv2nZSo2Eh5Bq9L6oxNPd1w0ldrf3 +sqghdojSvMMEU54Kn/uMWDH/zQgoDUjw3j1v7bdsem7pzKiaS5NoVJx0qw/cYbL GSk0v7Bg7lCRZE9vVFbLBoEAfV+Tm4kGpLIOM3Q/fVQaO8zzIM1AyxZ5qCGF0HZf ijnPJ41LfKmTQPvSIjhRwXXszxRV+Gh7EMzfDTcYS2e9kvSrUgD7riJGciUPcCzo s+IfT47+2JZ5PLi6rMvpIdV41e6fjP2mqdy8RZtepGzqHJoQaSYgYJHTtW44DCs1 Xgsnl+l+FK3RW71eLGf+y0jqfDwET5lvEmA1VMiY9Iiu/hAN32F4GP/RiRaKpnKi 3JhmQWKHgDBxUrmxOxD9+n7HhuwyJ0VEcB2jtJvTx3R/IyMO2++vIiQcGlr5XeDk B2AnmhqnEo6B0YZm9U08QkON5it4epsleBbm9UL7X7vLmHgKR1lY7m+spRLuQ6bS HNeP0R8Ezr2tQceL2vRlbgo7Z77/C6hccKIkR9XifoElWigzMSA=
=XMy3
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, Feb 27, 2024 at 01:33:08AM +0000, Mathias Gibbens wrote:

iproute2 is Priority: important, which according to Policy §2.5 means
that it is generally expected to be present on a Debian system. Do you
have a specific use case where for some reason you don't have iproute2 installed?

Would you mind reassessing your view in light of Policy 3.5 (https://www.debian.org/doc/debian-policy/ch-binary.html#dependencies)?
I think it's quite straightforward and unambiguous.

Section 2.5 has traditionally not been what controls decisions about
when dependencies ought to be specified, and this particular case is one
that I'm surprised to find being controversial. The fine distinction
between "Priority: required" and "Essential: yes" has sometimes confused
people in the past and has needed some discussion, but it's always been
my experience that if one package needs another "Priority: important"
package for proper functioning then it's been quite uncontroversial that
the first package must declare a dependency.

Thanks,

--
Colin Watson (he/him) [cjwatson@debian.org]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tags -1 + pending

It's easy enough to add iproute2 as a dependency, so I've done so.
Incus already has quite a number of dependencies, and I'd like to keep
that list as small as possible, which is why I was initially reluctant
to add iproute2. I would be interested to know more about what
environment Incus is being used in that doesn't have the `ip` command available.

My normal testing setup for Incus is a fresh, minimal expert install
of sid via the netinst iso. During the install of the VM, I only
install the base system and deselect the "standard system utilities"
group. I do use DHCP, which looks like that might be responsible for
pulling in iproute2 for me. If there's a way to create an even more
minimal install, I'd be happy to incorporate that into my testing
routine.

Mathias

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE1Bp60H32xfynSJ8cKe7i1uz0QvkFAmXnCU8ACgkQKe7i1uz0 QvncyhAAkodxEhpf1btikZuPoxoAfryBTaHRdraIidKE8TtQy1C+N2f78wX80G/t qG/aA3MloY9rITnzJOTR3MOWxNpFnMQxlpuipUzEEKI+ngr8HtXe2cmXDGOxgOgT WZH/DgIWgt3wDil7ajSHINL7fYfQbZ/qIeQ6hhSrektFS1njvIK+7FADgI3PTcSu q5Nq/LGQFIbFV6CPc6PXq1VSwPxU1Doc0xjSz1KCSsHEQy8PwYdLYNzO5Vjr2coF NLre5gMu/TMTGjfCsf0/KM9kRt3xhhh2uHxydAQsY8BGdraw+Etirmy9Z7nWTHlA HMu6KzlCOZ+BpoLpvkfw2g5ArAukmuKlRx8ia2f7QuoBCNrAlE1iy5+DmjnK//vm I14cG16Rmthdbhh/PjUSdqaB1c5BbmpxWBJdqAYClgMzW2EocOrOKbZTuVXATfL3 sK/SRKMI55GPVErXKnPAtmVxzgPKzuLKRAgUgsxI7VLkCV/kJeMbVZBIkFYraFat I0PaTwa+xge4KCm5KfZ5vlb1HAr8CDcSgBOicAtDwzQ0OsScBoxSo6uBgtHlsEPz QNqGx6hnBYRi/5irc9SDAPE10+9h2oCOAtDoJT0BHgPrZTyXi2ZpqxqF4OfmMKuy GwoPHQ6SR4r8q11aw39qGzE6nxL00gF9Ate97ErqXg7yq4OogT4=
=e4zD
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, Mar 05, 2024 at 12:00:15PM +0000, Mathias Gibbens wrote:

to add iproute2. I would be interested to know more about what
environment Incus is being used in that doesn't have the `ip` command available.

debvm-create --include=incus
# This should have created a file named rootfs.ext4.
debvm-run

My normal testing setup for Incus is a fresh, minimal expert install
of sid via the netinst iso. During the install of the VM, I only
install the base system and deselect the "standard system utilities"
group. I do use DHCP, which looks like that might be responsible for
pulling in iproute2 for me. If there's a way to create an even more
minimal install, I'd be happy to incorporate that into my testing
routine.

Turns out your minimal expert install is not so minimal. debvm tends to
give you a smaller but still functional installation. I think adding --variant=important to debvm-create roughly gets you the minimal expert installation, but creating the machine takes slightly longer and uses
more disk space of course.

Rather than adding debvm on top of your testing, I think adding
autopkgtests with isolation-machine should get you more automatic
coverage. Possibly such tests need to be explicitly allowed by debci
folks and currently are only available on amd64.

Helmut

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, 2024-03-05 at 14:19 +0100, Helmut Grohne wrote:

debvm-create --include=incus
# This should have created a file named rootfs.ext4.
debvm-run

Thanks for sharing that!

Rather than adding debvm on top of your testing, I think adding
autopkgtests with isolation-machine should get you more automatic
coverage. Possibly such tests need to be explicitly allowed by debci
folks and currently are only available on amd64.

Yes, it would be nice to get better autopkgtest coverage for incus,
lxc, and lxcfs. I'll add it to my todo list for these packages. :)

Mathias

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE1Bp60H32xfynSJ8cKe7i1uz0QvkFAmXn3OwACgkQKe7i1uz0 Qvl9rhAAirxyJfRr8GO/ahIq3wbamQKVN6TDu6aYr/YVj8z6YPnJVnFheI3KsmeQ 6v+7CQEvR0ldDwRJ6dEDJUoWjQqjTkEyvRF5MGn9uv8G196QJo58GVq6Ff/naq4P /GMCM6LOnK4XY7rgYnN53J3KePqtt01WhuUrypYnsVNsbW4BeFm7KzZtQpn+2SNo UMSpPq+bTb6Nx5oyP3zPKUp7tYUV/g7O/GfHMvDg69UU/CmdTCLxAAAV5AUvmlUf U5OeKVg5O8WRA0K8BBKBoRVjDgv0Y++hk/urxZLvOAmqlPSl7HAJHqdTjQMUffv1 Mn+j2vNombz2P/1747y45XXrpDZfW+C//U5M2fBbdbDyNDImmqmvSPviFCnguLNF QnRV1aBGT2Wr+KxeBtgsVXJpYF+mAMYzW1/PLdEZYkDMhj8v3IB+nycnOPF3VG44 ggnkEW6aqiY5c79Xm04JJ1FtOQxo/W1m+Xuj0jTHkNfGTIr5v9lb+nUJ5ia+HjgP PW7h7Tnl8ZSGVXSBRDD0+3jNsfBqyDD5M5aS9Q2Za3rz8iYu52u8C89ZoeETY9fi aD5tcvZjS9ABff3hsKAzuJSxGnupTlUAO6/K8nK8+/2UJrWzgjJ9fdVEV1Pgse0v G00HzgVRjVsnBaSjH3usx3K+9raJqUiId5r/wBCLKv/vge0MSt4=
=F8i8
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)