• Bug#1061884: allegro4.4: NMU diff for 64-bit time_t transition

    From Steve Langasek@21:1/5 to All on Tue Jan 30 00:50:01 2024
    This is a multi-part MIME message sent by reportbug.


    Source: allegro4.4
    Version: 2:4.4.3.1-4
    Severity: serious
    Tags: patch pending
    Justification: library ABI skew on upgrade
    User: debian-arm@lists.debian.org
    Usertags: time-t

    Dear maintainer,

    As part of the 64-bit time_t transition required to support 32-bit architectures in 2038 and beyond (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified allegro4.4 as a source package shipping runtime libraries whose ABI
    either is affected by the change in size of time_t, or could not be
    analyzed via abi-compliance-checker (and therefore to be on the safe
    side we assume is affected).

    To ensure that inconsistent combinations of libraries with their reverse-dependencies are never installed together, it is necessary to
    have a library transition, which is most easily done by renaming the
    runtime library package.

    Since turning on 64-bit time_t is being handled centrally through a change
    to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is important that libraries affected by this ABI change all be uploaded close together in time. Therefore I have prepared a 0-day NMU for allegro4.4
    which will initially be uploaded to experimental if possible, then to
    unstable after packages have cleared binary NEW.

    Please find the patch for this NMU attached.

    If you have any concerns about this patch, please reach out ASAP. Although this package will be uploaded to experimental immediately, there will be a period of several days before we begin uploads to unstable; so if information becomes available that your package should not be included in the transition, there is time for us to amend the planned uploads.



    -- System Information:
    Debian Release: trixie/sid
    APT prefers unstable
    APT policy: (500, 'unstable'), (1, 'experimental')
    Architecture: amd64 (x86_64)

    Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
    Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
    Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
    Shell: /bin/sh linked to /usr/bin/dash
    Init: systemd (via /run/systemd/system)

    diff -Nru allegro4.4-4.4.3.1/debian/changelog allegro4.4-4.4.3.1/debian/changelog
    --- allegro4.4-4.4.3.1/debian/changelog 2023-08-28 13:02:32.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/changelog 2024-01-29 23:44:39.000000000 +0000
    @@ -1,3 +1,10 @@
    +allegro4.4 (2:4.4.3.1-4.1) experimental; urgency=medium
    +
    + * Non-maintainer upload.
    + * Rename libraries for 64-bit time_t transition.
    +
    + -- Steve Langasek <vorlon@debian.org> Mon, 29 Jan 2024 23:44:39 +0000
    +
    allegro4.4 (2:4.4.3.1-4) unstable; urgency=medium

    * Add a clean dh target to remove CHANGES - fixes building after a
    diff -Nru allegro4.4-4.4.3.1/debian/control allegro4.4-4.4.3.1/debian/control --- allegro4.4-4.4.3.1/debian/control 2023-08-28 13:02:32.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/control 2024-01-29 23:44:39.000000000 +0000
    @@ -26,15 +26,16 @@
    Vcs-Browser: https://salsa.debian.org/games-team/allegro4.4
    Vcs-Git: https://salsa.debian.org/games-team/allegro4.4.git

    -Package: liballegro4.4
    +Package: liballegro4.4t64
    +Provides: ${t64:Provides}
    Section: libs
    Architecture: any
    Multi-Arch
  • From Simon McVittie@21:1/5 to Steve Langasek on Tue Jan 30 11:00:02 2024
    On Mon, 29 Jan 2024 at 23:45:11 +0000, Steve Langasek wrote:
    Dear maintainer,

    (I am a games team member but not a maintainer of this particular package)

    diff -Nru allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install
    --- allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install 2023-08-28 13:02:32.000000000 +0000

    Should this have been liballeggl4.4t64.install, without the last ".4"?

    diff -Nru allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.lintian-overrides allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.lintian-overrides
    --- allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.lintian-overrides 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.lintian-overrides 2024-01-29 23:44:39.000000000 +0000

    Similarly this, and:

    --- allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.examples 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.examples 2023-08-28 13:02:32.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.install 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.install 2023-08-28 13:02:32.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.lintian-overrides 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballegro4.4t64.4.lintian-overrides 2024-01-29 23:44:39.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/libjpgalleg4.4t64.4.install 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/libjpgalleg4.4t64.4.install 2023-08-28 13:02:32.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/libjpgalleg4.4t64.4.lintian-overrides 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/libjpgalleg4.4t64.4.lintian-overrides 2024-01-29 23:44:39.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/libloadpng4.4t64.4.lintian-overrides 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/libloadpng4.4t64.4.lintian-overrides 2024-01-29 23:44:39.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/liblogg4.4t64.4.install 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liblogg4.4t64.4.install 2023-08-28 13:02:32.000000000 +0000

    --- allegro4.4-4.4.3.1/debian/liblogg4.4t64.4.lintian-overrides 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liblogg4.4t64.4.lintian-overrides 2024-01-29 23:44:39.000000000 +0000

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Steve Langasek@21:1/5 to Simon McVittie on Tue Jan 30 17:40:01 2024
    --Qdm452frvHWaYhOe
    Content-Type: text/plain; charset=us-ascii
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    On Tue, Jan 30, 2024 at 09:49:40AM +0000, Simon McVittie wrote:
    On Mon, 29 Jan 2024 at 23:45:11 +0000, Steve Langasek wrote:
    Dear maintainer,

    (I am a games team member but not a maintainer of this particular package)

    diff -Nru allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install
    --- allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install 1970-01-01 00:00:00.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/liballeggl4.4t64.4.install 2023-08-28 13:02:32.000000000 +0000

    Should this have been liballeggl4.4t64.install, without the last ".4"?

    Yes, sorry! Found a bug in the 'time-t-me' conversion script yesterday (handling of ${foo#pattern} vs ${foo##pattern}, sigh) because it had caused
    a build failure in another package, but hadn't noticed it already broke any other packages before this that were wrong but didn't ftbfs.

    Please find an updated patch which picks up this fix, and also some relevant fixes to strict versioned dependency references in debian/control.

    And fixed NMU uploaded to experimental.

    --
    Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

    --Qdm452frvHWaYhOe
    Content-Type: text/plain; charset=us-ascii
    Content-Disposition: attachment; filename="nmu_allegro4.4.debdiff" Content-Transfer-Encoding: quoted-printable

    diff -Nru allegro4.4-4.4.3.1/debian/changelog allegro4.4-4.4.3.1/debian/changelog
    --- allegro4.4-4.4.3.1/debian/changelog 2023-08-28 13:02:32.000000000 +0000
    +++ allegro4.4-4.4.3.1/debian/changelog 2024-01-30 16:25:24.000000000 +0000
    @@ -1,3 +1,10 @@
    +allegro4.4 (2:4.4.3.1-4.1) experimental; urgency=medium
    +
    + * Non-maintainer upload.
    + * Rename libraries for 64-bit time_t transition.
    +
    + -- Steve Langasek <vorlon@debian.org> Tue, 30 Jan 2024 16:25:24 +0000
    +
    allegro4.4 (2:4.4.3.1-4) unstable; urgency=medium
  • From Debian Bug Tracking System@21:1/5 to All on Thu Feb 29 10:50:02 2024
    This is a multi-part message in MIME format...

    Your message dated Thu, 29 Feb 2024 10:44:54 +0100
    with message-id <trinity-aa88ed45-b50a-4d9f-ae2c-e0fee829d339-1709199894653@3c-app-gmx-bs31>
    and subject line allegro4.4: NMU diff for 64-bit time_t transition
    has caused the Debian Bug report #1061884,
    regarding allegro4.4: NMU diff for 64-bit time_t transition
    to be marked as done.

    This means that you claim that the problem has been dealt with.
    If this is not the case it is now your responsibility to reopen the
    Bug report if necessary, and/or fix the problem forthwith.

    (NB: If you are a system administrator and have no idea what this
    message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
    immediately.)


    --
    1061884: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061884
    Debian Bug Tracking System
    Contact owner@bugs.debian.org with problems

    Received: (at submit) by bugs.debian.org; 29 Jan 2024 23:45:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
    (2021-04-09) on buxtehude.debian.org
    X-Spam-Level:
    X-Spam-Status: No, score=-111.1 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
    DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FOURLA,FROMDEVELOPER,
    HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE,
    T_SCC_BODY_TEXT_LINE,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,
    XMAILER_REPORTBUG autolearn=ham autolearn_force=no
    version=3.4.6-bugs.debian.org_2005_01_02
    X-Spam-Bayes: score:0.0000 Tokens: new, 81; hammy, 150; neutral, 374; spammy,
    0. spammytokens: hammytokens:0.000-+--sk:taint_o, 0.000-+--sk:TAINT_O,
    0.000-+--trixie, 0.000-+--langasek, 0.000-+--Langasek
    Return-path: <vorlon@homer.dodds.net>
    Received: from becquer.dodds.net ([207.224.24.209]:34091)
    by buxtehude