Hi,

Anthony Iliopoulos <ailiop@suse.com> (2023-10-30):

On Mon, Oct 30, 2023 at 04:19:32PM +0100, Philip Hands wrote:

Anthony Iliopoulos <ailiop@suse.com> writes:

On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:

...

error: invalid XFS directory entry.

...

This issue exists independently of the large extent counter, and it is related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
fuzzing the XFS filesystem"). That's actually the issue described in #1051543.

Ah, yes -- good point.

There's a proposed fix at [1], and it works as expected with that patch applied.

...

[1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/

I can confirm that having applied both patches:

https://salsa.debian.org/philh/grub2/-/pipelines/596346

it now succeeds at both installing grub, and then booting the system:

https://openqa.debian.net/tests/200503#details

Thanks for confirming, perhaps then you can add your tested-by in the respective patches upstream.

BTW, another handy way to test if this works is via grub-mount.

Any chance we could have an updated grub2 package to fix this?


Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmWHWyYACgkQ/5FK8MKz VSDlcQ//bebYGgaG/H0Ik1eEEhYPMFREqDa1W26Oqj9VYKpmDt7ptIVSOt6/G/TL Dmtyifh5lsur48HySILVUvCe8Skw/swsTLnQl35x+asOoEg4aVrFveyUmUIo8oKZ DzMWYcgurgHraK5IksQCtOAhr+FuO1K+uJmBHDHPNrqYhln3HRtbwVmd6FmQqiPo 3R1l+XAtHprqArvbOKdd01pverze2VrEMf9ZP/oYPGsVmWktq8DRqlGxPY78exaK +Caz5cdEuqF8dwswIUtpBc7k/Bn7BAKz7cNXBnLEgxIxnkyNw0hflRAjUP1pdVXh nLDE1E+sNKse8zPZpDwJ6pGLxq1jHGK4njJEXrgmxYDTg0VLYVpthr+JsWAF/kV8 2mIUS9PMN9vFjUyFd3XVQJMELibK6S3iMrLrCRIteijeE0vlBhjRtFV3pzsBOk8j zMDpnO1amWtt4cxOcdoHntjFfr2m8qFdWt6cBrqNURn05S8cC962cQBAxyhFPnnM DsPBrCoKuvicTXZMTcOaDJ1OCg4BPqjnwpfEXdvi8YMaVclnbwOePngF32CENuUH omh4dTAlFroD2F3RMm+CIfUygsMrW5g4m6Gkrdg7xF+yrt4hbgsEpDgbT2pgNCn6 Dhw7dKYmFFKklM4GEhXrRQ3PdkWs+ag/baVIZsUw+0F1fUo8aZs=
=OWys
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
*

Julian Andres Klode <julian.klode@canonical.com> (2023-12-25):

We picked the previous XFS patch for extent parsing but did not pick
this one because it had not been merged at that point yet, the fix
only got merged two weeks or so ago, and we didn't want to take chances
and pick it ahead of time as it's security critical code (filesystem
parsing is where all the security bugs live!).

The release was supposed to be out 2 weeks ago but got pushed back
another week to last week's release, sadly.

Thanks for all the details, and sorry if it appeared I was chasing you
down; I just stumbled upon this again while re-testing various things,
and was merely wondering whether things were.


Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmWJo1wACgkQ/5FK8MKz VSC6Pg//YYYlaIVFyUDN2bfShLi0dmA2VF4B7LQJDHfvPBAcSeyVIZeYeuO4ANly f+Ql+PQTPSYUuVBkVZ0wZGNcUBSlnrhXxVulnvqQ0saRhQKITVcrmujvTSoZJgKZ gVyHOIMpSnC7bh73oEjPNOun0OY9Zyi0la0kWfS6b8um6HTZY23oc7SGbFcNURRk 0Qkvnljj4a+GPTN4YebelSDD7iv8gnP9zBs37pDSckfMRXv4JHxTe28Qy3OrJyis xGva2JcFW9RW6iUH/DtjBTbLKZ+XB4VS79otn6gHCEmwy/nRJJCIxlo+rjzkUvwa RYSNr5GE04MdZRbqjABi/hL69rjwwpvdRT6WHe3TPompPZ5ybh89IABfHhH9KPfl AvKMLXASxvuu6/9D4Z6h3p0szY6DFlc1lFbfV2xcH+QAYw5Dhagsg1ETTVdraY0F ZIdKEsB2f6sEaWUmNqJnb9jzYxYcZqgrg5FhYBg9A7M7By0pm65xaIGc6nR+OIaX 6gMl7cvgcG/ZjDhlYPZCQO9aUXPJ9vvr8oaKwMP23Mh1XrbvimvhAZcdpD7qaOKM Fht75oNYeI2fZpxlHT05TdN8CHSjXXLwXnfZnmB0PCJXsDUOwZYu2Kbr8SfwE1rl O3Jxj83YaQFU4nduxSTi/q+Jd8DxJQGkjcaK+XAUlRIMzGDtKDY=
=aS6e
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
*