Newbie looking for review before first upload.

project: libxml-hash-xs-perl

I have created my first project for the Debian Perl team, and would greatly appreciate a review on two fronts:


*1. first time review of the package*
I have followed the policy and git pages to get this far
Amended copyright etc.
And ensured the rules includes hardening

*2. am I doing the right thing*
Found no real answer for adding a package that is not from the upstream maintainer.
That is, it is not my package on CPAN, but I need it for a project.
Not sure if I need to still raise a Request for package (RFA).

Please advise

Regards
--
Ken Ibbotson
E: keni@computer.org

*"Reality is merely an illusion, albeit a very persistent one."*
- Albert Einstein (1879-1955)

<div dir="ltr"><div>Newbie looking for review before first upload.</div><div><br></div><div>project:    libxml-hash-xs-perl</div><div><br></div><div>I have created my first project for the Debian Perl team, and would greatly appreciate a review on two
fronts:</div><div><br></div><div><b>1. first time review of the package<br></b></div><div>I have followed the policy and git pages to get this far</div><div>Amended copyright etc.</div><div>And ensured the rules includes hardening</div><div><br></div><

<b>2. am I doing the right thing</b></div><div>Found no real answer for adding a package that is not from the upstream maintainer.<br></div><div>That is, it is not my package on CPAN, but I need it for a project.</div><div>Not sure if I need to still

raise a Request for package (RFA).</div><div><br></div><div>Please advise<br></div><div><br></div><div>Regards<br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <
a href="mailto:keni@computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div></div></


--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Le 28/09/2020 à 07:30, Ken Ibbotson a écrit :

Newbie looking for review before first upload.

project:    libxml-hash-xs-perl

I have created my first project for the Debian Perl team, and would
greatly appreciate a review on two fronts:

*1. first time review of the package
*
I have followed the policy and git pages to get this far
Amended copyright etc.
And ensured the rules includes hardening

*2. am I doing the right thing*
Found no real answer for adding a package that is not from the upstream maintainer.
That is, it is not my package on CPAN, but I need it for a project.
Not sure if I need to still raise a Request for package (RFA).

Please advise

Regards

Hi,

good job. Some few things:
* you should update debhelper-compat to 13
* you should add "Rules-Requires-Root: no" in debian/control
* copyright:
* *: years are 2012-2020, not 2012 (see README)
* inc/Devel/CheckLib.pm copyright is missing, copy it from
https://perl-team.pages.debian.net/copyright.html#Devel%3A%3ACheckLib
* src/ppport.h copyright is missing also, copy it from
https://perl-team.pages.debian.net/copyright.html#Devel%3A%3APPPort

I think you should also exclude "inc" directory from import and use libdevel-checklib-perl build-dependency instead (not tested)

Cheers,
Xavier

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, 28 Sep 2020 15:00:05 +0930, Ken Ibbotson wrote:

*2. am I doing the right thing*
Found no real answer for adding a package that is not from the upstream maintainer.
That is, it is not my package on CPAN, but I need it for a project.

That's the typical case - Debian packaging and distributing software
written by others.

Not sure if I need to still raise a Request for package (RFA).

You should file an ITP (Intent To Package) bug (against the wnpp pseudo-package) when starting to work on a new package.
dpt-gen-itp(1) can help.


On Mon, 28 Sep 2020 08:46:15 +0200, Xavier wrote:

I think you should also exclude "inc" directory from import and use libdevel-checklib-perl build-dependency instead (not tested)

I wouldn't mess around with importing, but using the packaged version
instead of what's in inc/ is indeed a good idea. There are some
example packages on salsa; a simple and typical one would be

https://sources.debian.org/src/libexporter-tiny-perl/1.002002-1/debian/rules/


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- BOFH excuse #177: sticktion

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Le 28/09/2020 à 12:41, Ken Ibbotson a écrit :

Thanks for the feedback.
Appreciate the head up, and done.

Did you push your changes ?

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Thanks for the feedback.
Appreciate the head up, and done.
--
Ken Ibbotson
E: keni@computer.org

*"Reality is merely an illusion, albeit a very persistent one."*
- Albert Einstein (1879-1955)


On Mon, 28 Sep 2020 at 16:16, Xavier <yadd@debian.org> wrote:

Le 28/09/2020 à 07:30, Ken Ibbotson a écrit :

Newbie looking for review before first upload.

project: libxml-hash-xs-perl

I have created my first project for the Debian Perl team, and would
greatly appreciate a review on two fronts:

*1. first time review of the package
*
I have followed the policy and git pages to get this far
Amended copyright etc.
And ensured the rules includes hardening

*2. am I doing the right thing*
Found no real answer for adding a package that is not from the upstream maintainer.
That is, it is not my package on CPAN, but I need it for a project.
Not sure if I need to still raise a Request for package (RFA).

Please advise

Regards

Hi,

good job. Some few things:
* you should update debhelper-compat to 13
* you should add "Rules-Requires-Root: no" in debian/control
* copyright:
* *: years are 2012-2020, not 2012 (see README)
* inc/Devel/CheckLib.pm copyright is missing, copy it from
https://perl-team.pages.debian.net/copyright.html#Devel%3A%3ACheckLib
* src/ppport.h copyright is missing also, copy it from
https://perl-team.pages.debian.net/copyright.html#Devel%3A%3APPPort

I think you should also exclude "inc" directory from import and use libdevel-checklib-perl build-dependency instead (not tested)

Cheers,
Xavier

<div dir="ltr"><div>Thanks for the feedback. <br></div><div>Appreciate the head up, and done.<br></div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:keni@
computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div><br></div><br><div class="
gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 28 Sep 2020 at 16:16, Xavier &lt;<a href="mailto:yadd@debian.org">yadd@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,
204,204);padding-left:1ex">Le 28/09/2020 à 07:30, Ken Ibbotson a écrit :<br> &gt; Newbie looking for review before first upload.<br>
&gt; <br>
&gt; project:    libxml-hash-xs-perl<br>
&gt; <br>
&gt; I have created my first project for the Debian Perl team, and would<br> &gt; greatly appreciate a review on two fronts:<br>
&gt; <br>
&gt; *1. first time review of the package<br>
&gt; *<br>
&gt; I have followed the policy and git pages to get this far<br>
&gt; Amended copyright etc.<br>
&gt; And ensured the rules includes hardening<br>
&gt; <br>
&gt; *2. am I doing the right thing*<br>
&gt; Found no real answer for adding a package that is not from the upstream<br>
&gt; maintainer.<br>
&gt; That is, it is not my package on CPAN, but I need it for a project.<br> &gt; Not sure if I need to still raise a Request for package (RFA).<br>
&gt; <br>
&gt; Please advise<br>
&gt; <br>
&gt; Regards<br>

Hi,<br>

good job. Some few things:<br>
 * you should update debhelper-compat to 13<br>
 * you should add &quot;Rules-Requires-Root: no&quot; in debian/control<br>  * copyright:<br>
  * *: years are 2012-2020, not 2012 (see README)<br>
  * inc/Devel/CheckLib.pm copyright is missing, copy it from<br>
   <a href="https://perl-team.pages.debian.net/copyright.html#Devel%3A%3ACheckLib" rel="noreferrer" target="_blank">https://perl-team.pages.debian.net/copyright.html#Devel%3A%3ACheckLib</a><br>
  * src/ppport.h copyright is missing also, copy it from<br>
    <a href="https://perl-team.pages.debian.net/copyright.html#Devel%3A%3APPPort" rel="noreferrer" target="_blank">https://perl-team.pages.debian.net/copyright.html#Devel%3A%3APPPort</a><br>

I think you should also exclude &quot;inc&quot; directory from import and use<br>
libdevel-checklib-perl build-dependency instead (not tested)<br>

Cheers,<br>
Xavier<br>
</blockquote></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Yes, I did. Just now after raising a bug for ITP

I believe I covered everything
--
Ken Ibbotson
E: keni@computer.org

*"Reality is merely an illusion, albeit a very persistent one."*
- Albert Einstein (1879-1955)


On Mon, 28 Sep 2020 at 20:30, Xavier <yadd@debian.org> wrote:

Le 28/09/2020 à 12:41, Ken Ibbotson a écrit :

Thanks for the feedback.
Appreciate the head up, and done.

Did you push your changes ?

<div dir="ltr"><div>Yes, I did. Just now after raising a bug for ITP</div><div><br></div><div>I believe I covered everything<br></div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson<
/div>E: <a href="mailto:keni@computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div><

</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 28 Sep 2020 at 20:30, Xavier &lt;<a href="mailto:yadd@debian.org">yadd@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;

border-left:1px solid rgb(204,204,204);padding-left:1ex">Le 28/09/2020 à 12:41, Ken Ibbotson a écrit :<br>
&gt; Thanks for the feedback.<br>
&gt; Appreciate the head up, and done.<br>

Did you push your changes ?<br>
</blockquote></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Le 29/09/2020 à 04:23, Ken Ibbotson a écrit :

Yes, I did. Just now after raising a bug for ITP

I believe I covered everything

Hi,

1 - inc/*

you removed inc/* but without modifying debian/copyright, then if I try
to reproduce your download (using uscan), I won't have the same source.

When you want to exclude a file, use a "Files-Excluded: inc" in debian/copyright (and remove the paragraph related to it). In this case,
you should indicate that source was modified using a
"opts=repacksuffix=+ds" or "opts=repacksuffix=+dfsg" (if files were
removed due to Debian Free Software Guidelines). Then relaunch uscan and re-import.

Here it's probably too complex, don't modify upstream source (then keep
your "inc/*" paragraph in debian/copyright) and use the tips given by
Gregoa (https://sources.debian.org/src/libexporter-tiny-perl/1.002002-1/debian/rules/)

2 - ppport.h

typo: it's not ppport.h in debian/copyright but src/ppport.h

3 - changelog

you used "Initial release [see Bug#971341]". This is not the Debian
syntax and automates won't understand it (bug won't be closed on
upload). You must use the Debian syntax:

Initial release (Closes: #971341)

If you prefer, I can do it for you, then you'll be able to see the
change and understand what I tried to explain (I'm not fluent in
English, sorry).

Cheers,
Xavier

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)