In preparing to upload Request Tracker v5.0.4, I've had to prepare a number of new packages for CPAN
modules. Can I please have them reviewed, and hopefully uploaded?
libtest-snapshot-perl
---------------------
libbadger-perl
--------------
On Mon, 12 Jun 2023 23:32:07 +1200, Andrew Ruthven wrote:
In preparing to upload Request Tracker v5.0.4, I've had to prepare a
number of new packages for CPAN
modules. Can I please have them reviewed, and hopefully uploaded?
libtest-snapshot-perl
---------------------
Reviewed, and a few minor TODO items added to d/changelog.
libbadger-perl
--------------
Also reviewed, and my notes are also in d/changelog; mostly minor but
one real blocker as well this time …
I guess some of the notes also apply to the other packages, so I'll
stop here :)
All fixed.libtest-snapshot-perlReviewed, and a few minor TODO items added to d/changelog.
---------------------
I'll note that currently all of these packages will be team uploads, as
while I'm listed as a Maintainer, I'm not (yet) a DD, so I can't do the initial upload. Unless upload permissions can be granted before the packages are first uploaded.
libbadger-perl
--------------
Also reviewed, and my notes are also in d/changelog; mostly minor butHmm, this one is a bit more interesting. `make test` runs okay, but the autopkgtests to run -c against each module doesn't.
one real blocker as well this time …
I've patched the one with a syntax error.
There are two that still don't
compile. I haven't crawled into the code, and would rather not :). I've raised bug reports upstream[0][1].
Given the shipped tests pass, is it acceptable to filter these out of autopkgtests?
I've checked the others and updated with the provided feedback from the
first two.
On Tue, 27 Jun 2023 10:19:34 +1200, Andrew Ruthven wrote:
All fixed.libtest-snapshot-perlReviewed, and a few minor TODO items added to d/changelog.
---------------------
Thank you, looks good.
That's not what this "Team upload" line in d/changelog means, in my understanding. Let me try to explain:[snip]
libbadger-perl
--------------
Also reviewed, and my notes are also in d/changelog; mostly minor butHmm, this one is a bit more interesting. `make test` runs okay, but the autopkgtests to run -c against each module doesn't.
one real blocker as well this time …
Indeed more interesting/weird :)
I've patched the one with a syntax error.
I guess that's https://github.com/abw/Badger/pull/19
I you have the same as a debian/patches/ file please push it.
There are two that still don't
compile. I haven't crawled into the code, and would rather not :). I've raised bug reports upstream[0][1].
Thanks.
Given the shipped tests pass, is it acceptable to filter these out of autopkgtests?
If we have a reason to believe that the "-c" failures are harmless
then yes; that would require getting a deeper understanding of this
whole project that I currently have :)
libgraphviz2-perl
-----------------
GraphViz has been deprecated, long live GraphViz2! Request Tracker has moved
from GraphViz to using GraphViz2. ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037110 Repo: https://salsa.debian.org/perl-team/modules/packages/libgraphviz2- perl
as it's the next in the "dependency chain".
And I only found minor nitpicks, which I've again listed in
d/changelog.
libtest-snapshot-perl
---------------------
That's not what this "Team upload" line in d/changelog means, in my understanding. Let me try to explain:[snip]
Thank you for the great explanation.
Pushed.I guess that's https://github.com/abw/Badger/pull/19I've patched the one with a syntax error.libbadger-perl
--------------
I you have the same as a debian/patches/ file please push it.
I *think* that the modules aren't intended to be used standalone, so couldGiven the shipped tests pass, is it acceptable to filter these out of autopkgtests?If we have a reason to believe that the "-c" failures are harmless
then yes; that would require getting a deeper understanding of this
whole project that I currently have :)
be skipped.
All fixed, pushed.libgraphviz2-perlAnd I only found minor nitpicks, which I've again listed in
-----------------
d/changelog.
On Mon, 03 Jul 2023 11:49:40 +1200, Andrew Ruthven wrote:
And: libtest-snapshot-perl uploaded.
I *think* that the modules aren't intended to be used standalone, soGiven the shipped tests pass, is it acceptable to filter these outIf we have a reason to believe that the "-c" failures are harmless
of autopkgtests?
then yes; that would require getting a deeper understanding of this
whole project that I currently have :)
could be skipped.
Alright, in that case adding the 2 filenames to debian/tests/pkg-perl/syntax-skip should do the trick.
Thanks, uploaded as well.
[libbadger-perl]
Alright, in that case adding the 2 filenames to debian/tests/pkg-perl/syntax-skip should do the trick.I *think* that the modules aren't intended to be used standalone, so could be skipped.Given the shipped tests pass, is it acceptable to filter these outIf we have a reason to believe that the "-c" failures are harmless
of autopkgtests?
then yes; that would require getting a deeper understanding of this whole project that I currently have :)
Except that this file appears to apply to runtime-deps-and- recommends.d/syntax.t . The tests which are failing are in runtime- deps.d/use.t .
(And it seems that d/tests/pkg-perl/syntax-skip doesn't support comments, whereas the files for use.t do support comments.)
Would you be open to a merge request here?
On Wed, 12 Jul 2023 01:53:33 +1200, Andrew Ruthven wrote:
[snip]Alright, in that case adding the 2 filenames to debian/tests/pkg- perl/syntax-skip should do the trick.
(Just briefly, as I'm travelling):
Except that this file appears to apply to runtime-deps-and- recommends.d/syntax.t . The tests which are failing are in runtime- deps.d/use.t .
That doesn't match my memory, and luckily I still have a log:
[libbadger-perl]
That doesn't match my memory, and luckily I still have a log:[snip]
Hmm, I was obviously misreading things. Those modules, and two others are
now added to syntax-skip, autopkgtests now pass. Commit pushed.
[libbadger-perl]Uploaded (with three micro-commits).
On Wed, 12 Jul 2023 18:38:30 +0200, gregor herrmann wrote:
libhtml-query-perl
------------------
jQuery like interface for HTML::Element. Build dep for libcss-inliner-
perl
ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037246
Repo: https://salsa.debian.org/perl-team/modules/packages/libhtml-query- perl
Reviewed and some small TODO items added to d/changelog.
libcss-inliner-perl
-------------------
Library for converting CSS <style> blocks to inline styles. Used by
Request Tracker
for much more efficient HTML emails. It dropped the size of my test
emails by 500 kB.
ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037248
Repo: https://salsa.debian.org/perl-team/modules/packages/libcss- inliner-perl
Reviewed and some small TODO items added to d/changelog.
Fixed and commits pushed.libhtml-query-perlReviewed and some small TODO items added to d/changelog.
------------------
Fixed and commits pushed. Funnily enough I already had local fixes for twolibcss-inliner-perlReviewed and some small TODO items added to d/changelog.
-------------------
of them, I just hadn't pushed them before you reviewed. Ah well.
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 299 |
Nodes: | 16 (3 / 13) |
Uptime: | 67:06:43 |
Calls: | 6,693 |
Calls today: | 3 |
Files: | 12,228 |
Messages: | 5,345,995 |
Posted today: | 1 |