Hey,

I've updated libgd-graph-perl to v1.56, can I please get it reviewed?

It probably doesn't need to get into Bookworm, although that'd be nice
because this version is a dependency for the upcoming Request Tracker
5.0.4 release.

One thing I haven't done is remake the upstream tarball to remove samples/logo.gif which was done for the 1.54 release. Seems like a lot
of effort to save a 2.7 kB file. However, if the preference is to
continue to remove it, I can do that. The presence of this file does
cause this lintian error currently:

E: libgd-graph-perl source: source-ships-excluded-file samples/logo.gif [debian/copyright:8]

I didn't want to remove the exclusion before having this reviewed.

BTW, first time I've used the dpt tool, really nice.

Cheers,
Andrew

--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Tue, 25 Apr 2023 13:05:14 +1200, Andrew Ruthven wrote:

I've updated libgd-graph-perl to v1.56, can I please get it reviewed?

Yes, and sorry for the delay.

It probably doesn't need to get into Bookworm, although that'd be nice because this version is a dependency for the upcoming Request Tracker
5.0.4 release.

As we are in deep freeze currently, both packages will have to wait
for bookworm.

One thing I haven't done is remake the upstream tarball to remove samples/logo.gif which was done for the 1.54 release. Seems like a lot
of effort to save a 2.7 kB file. However, if the preference is to
continue to remove it, I can do that. The presence of this file does
cause this lintian error currently:
E: libgd-graph-perl source: source-ships-excluded-file samples/logo.gif [debian/copyright:8]
I didn't want to remove the exclusion before having this reviewed.

I wonder how you manged not to exlcude the file :)
as both dpt-import-orig (and the underlying gbp-import-orig) should,
with d/watch and d/copyright, exclude samples/logo.gif and create a
15.56~ds-1 version.

I'm not totally sure why samples/logo.gif was excluded, the various
notes say "avoiding/excluding pre-generated files". Either there were
worries about license or more likely preferred form f modification,
or problems when building twice. In any case, I'd personally stick
with the exclusion.

BTW, first time I've used the dpt tool, really nice.

I'm glad you like it; OOC: which subcommands did you use?
Ah, from looking at the commit messages it was dpt-fixup :)

I pushed some small fixes, cf. git log …

What's missing in the end is that you either add yourself to
Uploaders or add "Team upload." as the first line in d/changelog.


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmRssNVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZihw//Tao6JkiP7oFFUt3WwHB0krs1J802OK2qO12Da2sJvKhqBVJVb4yEbz1V J3dhBdqU4R1ZRpfjX4xAGmxFo53/vBLM8x5hA6YfOPvfL9iTtL0+vkvDGTrr5adm hnzTRDjG4jUFtkbpTBfbUjIeqK9mBL2iddOq59I3sKR039vqwDu+drF9ofv43v7m 1upwQe0dEU41ElZMBPYcHVJozLN8m6QyqhZ90XGJK138EXyGSqAZW71oPqr8w04H gpLhGNt+W4ok/1Pa/mZumub4rQebiqnlW+/xU3OCg+nUFlfjjWtxjTJdozohxljs B04Em5RbB05IUPmOMrVLN/AQzxs7p+U/YxCPfr38BN1Op6pG1CYgHg+rEEfXvWVB 5ZaCU6nPz0OPeZgZ2dXu2T3TJWuv7MHUq7M6BIfA19oNL/ATwtFm1Kn16omK52FH Huy1jboKidhttu9/eWdSV/jm1/s0bMXEVgTgm+5WhtFkRE3zQ62EyUhaZzpQcZfr
viD2pgpt

On Tue, 2023-05-23 at 14:25 +0200, gregor herrmann wrote:

On Tue, 25 Apr 2023 13:05:14 +1200, Andrew Ruthven wrote:

I've updated libgd-graph-perl to v1.56, can I please get it reviewed?

Yes, and sorry for the delay.

No problem.

One thing I haven't done is remake the upstream tarball to remove samples/logo.gif which was done for the 1.54 release. Seems like a lot
of effort to save a 2.7 kB file. However, if the preference is to
continue to remove it, I can do that. The presence of this file does
cause this lintian error currently:
E: libgd-graph-perl source: source-ships-excluded-file samples/logo.gif [debian/copyright:8]
I didn't want to remove the exclusion before having this reviewed.

I wonder how you manged not to exlcude the file :)
as both dpt-import-orig (and the underlying gbp-import-orig) should,
with d/watch and d/copyright, exclude samples/logo.gif and create a 15.56~ds-1 version.

Looks like I most likely downloaded the tarball manually rather than
use uscan.

I'm not totally sure why samples/logo.gif was excluded, the various
notes say "avoiding/excluding pre-generated files". Either there were
worries about license or more likely preferred form f modification,
or problems when building twice. In any case, I'd personally stick
with the exclusion.

I have made a 1.56~ds orig tarball without logo.gif and pushed it to Salsa.

BTW, first time I've used the dpt tool, really nice.

I'm glad you like it; OOC: which subcommands did you use?
Ah, from looking at the commit messages it was dpt-fixup :)

That and also now gen-itp and salsa pushrepo (to create new repos as well).

I pushed some small fixes, cf. git log …

Ta.

What's missing in the end is that you either add yourself to
Uploaders or add "Team upload." as the first line in d/changelog.

I'm currently a DM (just applied to become a DD), so even if I add myself to Uploaders, I cant upload. I have added "Team upload." to d/changelog.

Cheers,
Andrew

--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |


<html><head></head><body><div>On Tue, 2023-05-23 at 14:25 +0200, gregor herrmann wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>On Tue, 25 Apr 2023 13:05:14 +1200, Andrew Ruthven wrote:<

</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>I've updated libgd-graph-perl to v1.56, can I please get it reviewed?<br></div></blockquote><div><br></div><div>Yes, and sorry

for the delay.<br></div></blockquote><div><br></div><div>No problem.</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #
729fcf solid;padding-left:1ex"><div>One thing I haven't done is remake the upstream tarball to remove<

On Mon, 12 Jun 2023 00:25:40 +1200, Andrew Ruthven wrote:

On Tue, 2023-05-23 at 14:25 +0200, gregor herrmann wrote:

I wonder how you manged not to exlcude the file :)
as both dpt-import-orig (and the underlying gbp-import-orig) should,
with d/watch and d/copyright, exclude samples/logo.gif and create a 15.56~ds-1 version.

Looks like I most likely downloaded the tarball manually rather than
use uscan.

Oh I see.

I'm not totally sure why samples/logo.gif was excluded, the various
notes say "avoiding/excluding pre-generated files". Either there were worries about license or more likely preferred form f modification,
or problems when building twice. In any case, I'd personally stick
with the exclusion.

I have made a 1.56~ds orig tarball without logo.gif and pushed it to Salsa.

Great, thanks!

BTW, first time I've used the dpt tool, really nice.

I'm glad you like it; OOC: which subcommands did you use?
Ah, from looking at the commit messages it was dpt-fixup :)

That and also now gen-itp and salsa pushrepo (to create new repos as well).

Yay \o/

(dpt salsa pushrepo is really helpful to create standardized salsa
projects.)

What's missing in the end is that you either add yourself to
Uploaders or add "Team upload." as the first line in d/changelog.

I'm currently a DM (just applied to become a DD), so even if I add myself to Uploaders, I cant upload. I have added "Team upload." to d/changelog.

Good (and yes, in the end it's just about pleeasing lintian …; and
it needs a leading '* ' to really please lintian :))

Uploaded with 1 additonal commit.

Or 2; please change the distribution in d/changelog from UNRELEASED
to unstable if you believe a package is ready for upload.
(Cf. dpt-ready-for-upload and dpt-never-uploaded)


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmSLlA1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZW1RAAlMiwuvFxrYoZuf4FIBs2mx7h5CuwtbkQqnzUlRRjBq/ieJpV81dQQ2pd w3pv6e4RibWWddizdrJxWhxqbDkkyTi9XhqA1uottdJgisSbd5/XqzC4/xzDoU7n gvNhoPkgHlyBjo+jPX4wFAhanIB8Rjycy9SBEKD1LWn4GLzociZeOya7/ShD3rKj mkni1PRdHOjhXplJbPOZlDnjzylX0yghEdaY4b0mYB9SwLBeyblMmXv0GtBlGmOJ bXPzEr+LBa1KjX17OYsf327uJyUJ2LISXIZ4hAdwN4jO2u5p3XpnVX8EVlWPtVWu mTeY+up651y0Zv7nAceM/i/uEN047V+E2Mzd1itH4B0TI4DTHVTHJke7ngLQoZKv JVmZ7MakRjrPYZbz9RUQwULTz1sSKf9LsPbPsuryqnjtziQyAtQhdeasn/1a58lR +ORcIY86U3xJcr/LoQbaCDvvo85G94InZF0iJYMOw7x0yv37dY0S8HpOpqF54XCn
/fugePfh

On Fri, 2023-06-16 at 00:43 +0200, gregor herrmann wrote:

Good (and yes, in the end it's just about pleeasing lintian …; and
it needs a leading '* ' to really please lintian :))

Oops, thank you for fixing that. I've also ensured that I have that correct
in the five other packages I've recently asked to be reviewed/uploaded.

Uploaded with 1 additonal commit.

Thank you.

Gosh, I don't know how I missed that line. Actually, looking at the history
of that file, I see when it disappeared now. ;)

Or 2; please change the distribution in d/changelog from UNRELEASED
to unstable if you believe a package is ready for upload.
(Cf. dpt-ready-for-upload and dpt-never-uploaded)

Sure, I had figured that the person doing the upload would do that, but I'm happy to set that when I think it is ready in future.

Cheers,
Andrew


PS, I'd love to have some more advocates:  https://nm.debian.org/process/1190/advocate/

--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)