I've created a new package for InfluxDB::HTTP as the libinfluxdb-http-perl package and I don't have DM or DD access. I think that it should be mostly ready for review. https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl
Can I gently ask for some help with reviewing my work on this package?
One detail that I left out: there's a t/ directory with one file that contains tests. I've tried to add build-deps for running the test suite but
I ended up needing another library, Object::Result, which is not packaged in Debian and I didn't want to fall into a rabbit hole. So for now the package does not run tests with autopkgtest.
On Sun, 19 Jun 2022 16:13:00 -0400, Gabriel Filion wrote:
https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl
Some notes:
- I wouldn't install the README.pod as it is the same as the POD (and
the manpage)
% diff -u <(pod2text README.pod) <(pod2text lib/InfluxDB/HTTP.pm)
`perldoc InfluxDB::HTTP' and `man InfluxDB::HTTP' should be enough
:)
- W: libinfluxdb-http-perl source: no-nmu-in-changelog
W: libinfluxdb-http-perl source: source-nmu-has-incorrect-version-number 0.04-1
That's because you use a different mail adress in d/control and
d/changelog.
- I: libinfluxdb-http-perl: synopsis-is-a-sentence "Perl way to interact with InfluxDB."
--> remove full stop at the end
- I: libinfluxdb-http-perl: typo-in-manual-page usr/share/man/man3/InfluxDB::HTTP.3pm.gz line 151 reponse response
Upstream might be happy about a patch :)
So you can also remove the libtest-simple-perl build dependency
(coming from META.*; not that this changes anything, as it's provided
by src:perl).
As for autopkgtests, I'd still add the
"Testsuite: autopkgtest-pkg-perl"
field, as there are more tests than running the smoke tests.
# Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 13.
So libjson-maybexs-perl is missing in Depends (and the upstreamlib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 14.
metadata).
Next one:
# Can't locate LWP/UserAgent.pm in @INC (you may need to install the LWP::UserAgent module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/
So let's add libwww-perl to Depends.
And let's look at the actual code:
use JSON::MaybeXS;
use LWP::UserAgent;
use Object::Result;
use URI;
We have liburi-perl but *drumroll* we're back to packaging Object::Result which you wanted to avoid :)
I'm finally reaching out to this small project
Thanks again Gregor for the insightful feedback you sent me back in june!
- I: libinfluxdb-http-perl: typo-in-manual-page usr/share/man/man3/InfluxDB::HTTP.3pm.gz line 151 reponse responseI've sent a PR upstream to fix this typo.
Upstream might be happy about a patch :)
So you can also remove the libtest-simple-perl build dependencyok, the dependency is removed.
(coming from META.*; not that this changes anything, as it's provided
by src:perl).
As for autopkgtests, I'd still add theah yes ok, so this will run some basic perl smoke tests I guess?
"Testsuite: autopkgtest-pkg-perl"
field, as there are more tests than running the smoke tests.
lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 13.# Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/
lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 14.# Can't locate LWP/UserAgent.pm in @INC (you may need to install the LWP::UserAgent module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/
added both
And let's look at the actual code:
use JSON::MaybeXS;
use LWP::UserAgent;
use Object::Result;
use URI;
We have liburi-perl but *drumroll* we're back to packaging Object::Result which you wanted to avoid :)
oh blah you're totally right. the Object::Result is used at runtime in the library, so there's no escaping packaging it!
I took a quick look at the code from Object::Result and all dependencies are already packaged in debian.
I'll try and create another new package for that second lib soon.
liburi-perl is still missing in Depends.And let's look at the actual code:
use JSON::MaybeXS;
use LWP::UserAgent;
use Object::Result;
use URI;
We have liburi-perl but*drumroll* we're back to packaging Object::Result >>> which you wanted to avoid 🙂
Well, and the not-yet-packaged libobject-result-perl as well.
oh blah you're totally right. the Object::Result is used at runtime in the >> library, so there's no escaping packaging it!Ack.
I took a quick look at the code from Object::Result and all dependencies are >> already packaged in debian.Just shout when it's in git 🙂
I'll try and create another new package for that second lib soon.
I have a local branch where I started to look at enabling autopkgtest, which mostly just adds test-only dependencies to the control file.. However, when reading the source code of the file t/tests.pl I can see that it's expecting to contact a running InfluxDB instance.
So I'm wondering if getting libinfluxdb-http-perl into the archive without autopkgtest would be an option. If I can get some help it would still be possible to enable those tests later.
So I've added a patch that changes the rpc port in the test file and now I get a fully running build + autopkgtest process. I've also forwarded the patch upstream since I think it adds a bit of stability in their test suite.
So, I think that I am ready to request again some help with reviewing the work for the package libinfluxdb-http-perl and then if all seems in order, for sponsoring the push to NEW.
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 299 |
Nodes: | 16 (2 / 14) |
Uptime: | 61:06:35 |
Calls: | 6,690 |
Files: | 12,225 |
Messages: | 5,345,458 |