I am the maintainer of https://metacpan.org/dist/Test-JSON-Schema-Acceptance which is packaged as libtest-json-schema-acceptance-perl.
I've just noticed that its share/ directory is not being taken from the
cpan release, but rather copied directly from github.com/json-schema-org/JSON-Schema-Test-Suite. Please don't do that --
the data is not equivalent and downstream consumers may fail their tests if
the data does not match what was expected in the cpan release.

If there's anything I can do to make packaging easier, or any questions I
can answer, please let me know.

thanks,
Karen Etheridge
ether@cpan.org

<div dir="ltr"><div>I am the maintainer of <a href="https://metacpan.org/dist/Test-JSON-Schema-Acceptance">https://metacpan.org/dist/Test-JSON-Schema-Acceptance</a> which is packaged as libtest-json-schema-acceptance-perl.</div><div>I&#39;ve just noticed
that its share/ directory is not being taken from the cpan release, but rather copied directly from <a href="http://github.com/json-schema-org/JSON-Schema-Test-Suite">github.com/json-schema-org/JSON-Schema-Test-Suite</a>.  Please don&#39;t do that --
the data is not equivalent and downstream consumers may fail their tests if the data does not match what was expected in the cpan release.</div><div><br></div><div>If there&#39;s anything I can do to make packaging easier, or any questions I can answer,
please let me know.</div><div><br></div><div>thanks,<br></div><div>Karen Etheridge</div><div><a href="mailto:ether@cpan.org">ether@cpan.org</a><br></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Dear Karen,

On 2021-12-26 02:06, Karen Etheridge wrote:

I am the maintainer of
https://metacpan.org/dist/Test-JSON-Schema-Acceptance <https://metacpan.org/dist/Test-JSON-Schema-Acceptance> which is
packaged as libtest-json-schema-acceptance-perl.

Maintainer of libtest-json-schema-acceptance-perl Debian package here.

I've just noticed that its share/ directory is not being taken from the
cpan release, but rather copied directly from github.com/json-schema-org/JSON-Schema-Test-Suite <http://github.com/json-schema-org/JSON-Schema-Test-Suite>.  Please
don't do that -- the data is not equivalent and downstream consumers may
fail their tests if the data does not match what was expected in the
cpan release.

I have done so because of two reasons:

1. To use the same version of JSON Schema Test Suite in all Debian packages;

2. To deduplicate the shipped files.

When I did the packaging I noticed that JSON Schema Test Suite in Test::JSON::Schema::Acceptance is already a bit newer than the last
release of JSON Schema Test Suite. I understand why this difference matters.

I am fine with undoing my decision to replace files from CPAN release
with ones from JSON Schema Test Suite release, but I would like to
discuss an alternative approach first (including Adam Cecile, the
maintainer of json-schema-test-suite Debian package, in CC). JSON Schema
Test Suite is released quite rarely, albeit its development is quite
intensive. I expect most commits there being additions of new tests not touching already existing files much. Thus maybe it is better to package
its Git HEAD and update it from time to time instead of sticking to
releases (previous one happened in 2018)?

Karen, would it still be acceptable to have more up-to-date JSON Schema
Test Suite in libtest-json-schema-acceptance-perl's share/ instead of
what is in the CPAN release?

Adam, does packaging Git HEAD of JSON Schema Test Suite make sense to
you? Are you aware of potential breakages to the reverse dependencies?

If my proposal does not seem viable, I can revert my packaging choice. I
am not tied to it very strongly.

Thanks a lot,
Andrius

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

------NPWA0DC1N77KI9AKNKNKXHB17S2VQG
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hello,

Jason schéma test suite had been uploaded to be able to enable python-fastjsonschema test suite. At the first try, I embedded the testsuite inside the package but it got rejected by FTP masters. So at the beginning, fastjsonschema what the only package
using it, but we should check now.
I can probably build the git head and check if other packages still build, buy not right now.
Ping me again in a couple of day if I haven't got back to you.

Regards, Adam.

On December 26, 2021 8:46:51 AM GMT+01:00, Andrius Merkys <merkys@debian.org> wrote:

Dear Karen,

On 2021-12-26 02:06, Karen Etheridge wrote:

I am the maintainer of
https://metacpan.org/dist/Test-JSON-Schema-Acceptance
<https://metacpan.org/dist/Test-JSON-Schema-Acceptance> which is
packaged as libtest-json-schema-acceptance-perl.

Maintainer of libtest-json-schema-acceptance-perl Debian package here.

I've just noticed that its share/ directory is not being taken from the
cpan release, but rather copied directly from
github.com/json-schema-org/JSON-Schema-Test-Suite
<http://github.com/json-schema-org/JSON-Schema-Test-Suite>.  Please
don't do that -- the data is not equivalent and downstream consumers may
fail their tests if the data does not match what was expected in the
cpan release.

I have done so because of two reasons:

1. To use the same version of JSON Schema Test Suite in all Debian packages;

2. To deduplicate the shipped files.

When I did the packaging I noticed that JSON Schema Test Suite in >Test::JSON::Schema::Acceptance is already a bit newer than the last
release of JSON Schema Test Suite. I understand why this difference matters.

I am fine with undoing my decision to replace files from CPAN release
with ones from JSON Schema Test Suite release, but I would like to
discuss an alternative approach first (including Adam Cecile, the
maintainer of json-schema-test-suite Debian package, in CC). JSON Schema
Test Suite is released quite rarely, albeit its development is quite >intensive. I expect most commits there being additions of new tests not >touching already existing files much. Thus maybe it is better to package
its Git HEAD and update it from time to time instead of sticking to
releases (previous one happened in 2018)?

Karen, would it still be acceptable to have more up-to-date JSON Schema
Test Suite in libtest-json-schema-acceptance-perl's share/ instead of
what is in the CPAN release?

Adam, does packaging Git HEAD of JSON Schema Test Suite make sense to
you? Are you aware of potential breakages to the reverse dependencies?

If my proposal does not seem viable, I can revert my packaging choice. I
am not tied to it very strongly.

Thanks a lot,
Andrius

------NPWA0DC1N77KI9AKNKNKXHB17S2VQG
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head></head><body>Hello,<br><br>Jason schéma test suite had been uploaded to be able to enable python-fastjsonschema test suite. At the first try, I embedded the testsuite inside the package but it got rejected by FTP masters. So at the beginning,
fastjsonschema what the only package using it, but we should check now.<br>I can probably build the git head and check if other packages still build, buy not right now.<br>Ping me again in a couple of day if I haven't got back to you.<br><br>Regards,
Adam.<br><br><div class="gmail_quote">On December 26, 2021 8:46:51 AM GMT+01:00, Andrius Merkys &lt;merkys@debian.org&gt; wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;

<pre dir="auto" class="k9mail">Dear Karen,<br><br>On 2021-12-26 02:06, Karen Etheridge wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">I am the maintainer of<br><a href="
https://metacpan.org/dist/Test-JSON-Schema-Acceptance">https://metacpan.org/dist/Test-JSON-Schema-Acceptance</a><br>&lt;<a href="https://metacpan.org/dist/Test-JSON-Schema-Acceptance">https://metacpan.org/dist/Test-JSON-Schema-Acceptance</a>&gt; which is<

packaged as libtest-json-schema-acceptance-perl.<br></blockquote><br>Maintainer of libtest-json-schema-acceptance-perl Debian package here.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf;

padding-left: 1ex;">I've just noticed that its share/ directory is not being taken from the<br>cpan release, but rather copied directly from<br>github.com/json-schema-org/JSON-Schema-Test-Suite<br>&lt;<a href="http://github.com/json-schema-org/JSON-
Schema-Test-Suite">http://github.com/json-schema-org/JSON-Schema-Test-Suite</a>&gt;.&nbsp; Please<br>don't do that -- the data is not equivalent and downstream consumers may<br>fail their tests if the data does not match what was expected in the<br>cpan
release.<br></blockquote><br>I have done so because of two reasons:<br><br>1. To use the same version of JSON Schema Test Suite in all Debian packages;<br><br>2. To deduplicate the shipped files.<br><br>When I did the packaging I noticed that JSON Schema
Test Suite in<br>Test::JSON::Schema::Acceptance is already a bit newer than the last<br>release of JSON Schema Test Suite. I understand why this difference matters.<br><br>I am fine with undoing my decision to replace files from CPAN release<br>with ones
from JSON Schema Test Suite release, but I would like to<br>discuss an alternative approach first (including Adam Cecile, the<br>maintainer of json-schema-test-suite Debian package, in CC). JSON Schema<br>Test Suite is released quite rarely, albeit its
development is quite<br>intensive. I expect most commits there being additions of new tests not<br>touching already existing files much. Thus maybe it is better to package<br>its Git HEAD and update it from time to time instead of sticking to<br>releases
(previous one happened in 2018)?<br><br>Karen, would it still be acceptable to have more up-to-date JSON Schema<br>Test Suite in libtest-json-schema-acceptance-perl's share/ instead of<br>what is in the CPAN release?<br><br>Adam, does packaging Git HEAD
of JSON Schema Test Suite make sense to<br>you? Are you aware of potential breakages to the reverse dependencies?<br><br>If my proposal does not seem viable, I can revert my packaging choice. I<br>am not tied to it very strongly.<br><br>Thanks a lot,<br>
Andrius<br><br></pre></blockquote></div></body></html> ------NPWA0DC1N77KI9AKNKNKXHB17S2VQG--

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sat, Dec 25, 2021 at 11:46 PM Andrius Merkys <merkys@debian.org> wrote:

Karen, would it still be acceptable to have more up-to-date JSON Schema
Test Suite in libtest-json-schema-acceptance-perl's share/ instead of
what is in the CPAN release?

No, that can produce failures that authors of dependent packages cannot anticipate or mitigate. If the github HEAD was always acceptable to be used
in tests, I would have written the Test::JSON::Schema::Acceptance module so
it always pulled down the latest data from git when running tests, rather
than
packaging the data into share/.

Also, sometimes the format of the data changes, requiring changes to the wrapper
code in the Test::JSON::Schema::Acceptance module.

<div dir="ltr"><div dir="ltr"></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Dec 25, 2021 at 11:46 PM Andrius Merkys &lt;<a href="mailto:merkys@debian.org">merkys@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Karen, would it still be acceptable to have more up-to-date JSON Schema<br> Test Suite in libtest-json-schema-acceptance-perl&#39;s share/ instead of<br> what is in the CPAN release?<br></blockquote><div><br></div><div>No, that can produce failures that authors of dependent packages cannot</div><div>anticipate or mitigate. If the github HEAD was always acceptable to be used</div><div>in tests, I would
have written the Test::JSON::Schema::Acceptance module so</div><div>it always pulled down the latest data from git when running tests, rather than</div><div>packaging the data into share/.<br></div><div><br></div><div>Also, sometimes the format of the
data changes, requiring changes to the wrapper</div><div>code in the Test::JSON::Schema::Acceptance module.</div><div><br></div></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, 27 Dec 2021 11:52:23 -0800, Karen Etheridge wrote:

On Sat, Dec 25, 2021 at 11:46 PM Andrius Merkys <merkys@debian.org> wrote:

Karen, would it still be acceptable to have more up-to-date JSON Schema Test Suite in libtest-json-schema-acceptance-perl's share/ instead of
what is in the CPAN release?

No, that can produce failures that authors of dependent packages cannot anticipate or mitigate.

Thanks.

I've now uploaded libtest-json-schema-acceptance-perl 1.015-1,
without the repackaging, i.e. your pristine tarball from the CPAN.

(Alas the previous approach didn't work out, oh well …)

Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Status Quo: Rockin' All Over The World

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmHSXh1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZFfBAAswRVoFWl9/bjMmTeBSjXB1wnwcG1CoYOtkXLjGHbFZnl+27b1tbetbi0 gMqOA6hKm2Hzk20JLeQcCqIbsUcVydfTHXsJD2qi8JofZBlsE7u+rEl4AEnvQXQy 6qClDx73iVfeRI2mo4qOvHqPUcJHTFE/+2LiYp2QH1VW8wVQBZJxI3crnRnYl96J bhTIQnBKslci3SkyET1mEBTBRbrvme2El1njSnUU9thIBKaRPdm9EgQZb2jTdRl3 q0Ol7TRx3cchswMm5ajwx9/UGzqC8hIU4iVP4vDhCyftacUXPWvU/Dt/+0fCY1l4 SZRyvvuhSzQ/KijLJywLa82QFmFJuullFnX6ZCZSDNZQ7XA2W8HL/+DwLFOVlAts wmfaRc86tFoQhlcayqG+sKAfD8FhyPLjE8OWUA9jezx5nU6TdvJg2udfG2Ld2+q9 1AAibqqN8WSrM8bWqTTFJrM8DnT2TK4A

Hello,

On 2022-01-03 04:23, gregor herrmann wrote:

On Mon, 27 Dec 2021 11:52:23 -0800, Karen Etheridge wrote:

On Sat, Dec 25, 2021 at 11:46 PM Andrius Merkys <merkys@debian.org> wrote: >>> Karen, would it still be acceptable to have more up-to-date JSON Schema

Test Suite in libtest-json-schema-acceptance-perl's share/ instead of
what is in the CPAN release?

No, that can produce failures that authors of dependent packages cannot
anticipate or mitigate.

Thanks, Karen, for your input.

I've now uploaded libtest-json-schema-acceptance-perl 1.015-1,
without the repackaging, i.e. your pristine tarball from the CPAN.

Thanks, Gregor, for reverting my repackaging. I was about to do it myself.

Adam, let's leave json-schema-test-suite watching stable releases. If
the upstream changes format from time to time, packaging Git HEAD will
break other packages.

Best,
Andrius

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)