Thanks for the review Gregor.
All the changes have been made, and I think we are ready for upload.
Regards
--
Ken Ibbotson
E:
keni@computer.org
*"Reality is merely an illusion, albeit a very persistent one."*
- Albert Einstein (1879-1955)
On Mon, 5 Apr 2021 at 22:32, gregor herrmann <
gregoa@debian.org> wrote:
On Mon, 05 Apr 2021 14:02:34 +0930, Ken Ibbotson wrote:
Package: libtest-fitesque-rdf-perl
Origin:
https://salsa.debian.org/perl-team/modules/packages/libtest-fitesque-rdf-perl.git
1) d/copyright: An interesting case :)
Now it says "MIT"; https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
recommends "There are many versions of the MIT license. Please use
Expat instead, when it matches.", and indeed what's in d/copyright
sounds like the Expat license;
README* has "MIT (X11)";
and COPYRIGHT has
License: Expat
This software is Copyright (c) 2020 by Kjetil Kjernsmo.
This is free software, licensed under:
The MIT (X11) License
whereas LICENSE says "MIT (X11)" and "MIT" and then has the text of
the Expat license.
I _think_ MIT-X11 and Expat are the same, so I would use one of those
2 terms in d/copyright instead of just MIT.
Additionally there's a missing space in the license text: associateddocumentation
2) d/u/metadata:
Running one of (recent versions of)
- dpt debian-upstream
- lintian-brush --modern --no-update-changelog --opinionated --uncertain
adds
Bug-Submit: https://github.com/kjetilk/p5-test-fitesque-rdf/issues/new
3) d/control:
All lib.*-perl in Build-Depends-Indep could be annotated with
'<!nocheck>'.
The short description should start with a small letter and should be
a noun phrase (simple but inelegant solution: "module to formulate
…")
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-
<div dir="ltr"><div>Thanks for the review Gregor.</div><div><br></div><div>All the changes have been made, and I think we are ready for upload.</div><div><br></div><div>Regards<br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="
gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:
keni@computer.org" target="_blank">
keni@computer.org</a><br><div><br></div><div><i>"Reality is merely an illusion, albeit a very persistent one."</i></div>
- Albert Einstein (1879-1955)<br></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 5 Apr 2021 at 22:32, gregor herrmann <<a href="mailto:
gregoa@debian.org">
gregoa@debian.org</a>> wrote:<
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 05 Apr 2021 14:02:34 +0930, Ken Ibbotson wrote:<br>
> Package: libtest-fitesque-rdf-perl<br>
> Origin:<br>
> <a href="
https://salsa.debian.org/perl-team/modules/packages/libtest-fitesque-rdf-perl.git" rel="noreferrer" target="_blank">
https://salsa.debian.org/perl-team/modules/packages/libtest-fitesque-rdf-perl.git</a><br>
1) d/copyright: An interesting case :)<br>
Now it says "MIT";<br>
<a href="
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/" rel="noreferrer" target="_blank">
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/</a><br>
recommends "There are many versions of the MIT license. Please use<br> Expat instead, when it matches.", and indeed what's in d/copyright<br> sounds like the Expat license;<br>
README* has "MIT (X11)";<br>
and COPYRIGHT has<br>
License: Expat<br>
This software is Copyright (c) 2020 by Kjetil Kjernsmo.<br>
This is free software, licensed under:<br>
The MIT (X11) License<br>
whereas LICENSE says "MIT (X11)" and "MIT" and then has the text of<br>
the Expat license.<br>
I _think_ MIT-X11 and Expat are the same, so I would use one of those<br>
2 terms in d/copyright instead of just MIT.<br>
Additionally there's a missing space in the license text:<br> associateddocumentation<br>
2) d/u/metadata:<br>
Running one of (recent versions of)<br>
- dpt debian-upstream<br>
- lintian-brush --modern --no-update-changelog --opinionated --uncertain<br>
adds<br>
Bug-Submit: <a href="
https://github.com/kjetilk/p5-test-fitesque-rdf/issues/new" rel="noreferrer" target="_blank">
https://github.com/kjetilk/p5-test-fitesque-rdf/issues/new</a><br>
3) d/control:<br>
All lib.*-perl in Build-Depends-Indep could be annotated with<br> '<!nocheck>'.<br>
The short description should start with a small letter and should be<br>
a noun phrase (simple but inelegant solution: "module to formulate<br> …")<br>
Cheers,<br>
gregor<br>
-- <br>
.''`. <a href="
https://info.comodo.priv.at" rel="noreferrer" target="_blank">
https://info.comodo.priv.at</a> -- Debian Developer <a href="
https://www.debian.org" rel="noreferrer" target="_blank">
https://www.debian.org</a><br>
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06<br>
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe<br>
`- <br>
</blockquote></div>
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)