• Finance::Quote Update

    From gregor herrmann@21:1/5 to Rainer Dorsch on Sun Mar 7 02:00:01 2021
    On Sat, 06 Mar 2021 09:47:59 +0100, Rainer Dorsch wrote:

    Hi Gregor,

    Hi Rainer,

    Although it throws quite some errors, the modules relevant for me seem to work
    (which is not the case in 1.49 release in the Debian repo):

    Thanks for bringing this to our attention.

    Could you explain what problems 1.49-1 has?
    I'm asking because there are no bug reports in the Debian BTS about
    it.

    I think it would be worthwhile to do a proper update by somebody who has some
    more experience in perl and Debian packaging.

    I've imported the 1.50-rc1 tarball into our packaging repo. [0] It
    contains huge changes (might be called a partial rewrite) and took
    some work to get a working package again (e.g. with patches, as
    you noted, and also with dependencies etc.)

    Typically I would not upload a release candidate, and I would not
    upload a package with huge changes during the soft freeze.
    OTOH, if 1.49-1 is indeed broken, we might want to take the risks …

    https://github.com/finance-quote/finance-quote/issues/173 is also not
    very encouraging …

    Maybe I should upload what we have now to experimental to get some
    testing?
    Ok, I just went ahead, and 1.50~rc1-1 is now (module buildds and
    mirror sync) in experimental.

    Rainer, do you have a chance to install and test this version?


    Cheers,
    gregor

    [0] https://salsa.debian.org/perl-team/modules/packages/libfinance-quote-perl

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Die Quote: Nummer ans in Reykjavik

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmBEJOtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgaLrA//YlXbq4D6NzUz9I9/fcd9ZwxGZpPC3ugEQ5lsmCUVhIbpYJwje5cV7zBw oQLTmf/C6tB/SISApW2gQQ79yoz1B4Tm/5Zw0qWeJ0/fw7DihCBNrHWHJcDFJ1nn DeNAOSaY5qup4qGZCNRd5QP1wSZsbfP3gY+38GKsN5jrbNP2IeioB9FjrUCaqV4e mhQQzM0Gl9jT1FQ9cQdOCMg8csuMALxGw6StSiKvgAkpdGCQanLCbg5XFYIXf0hU Hbp0J6Eugna1rWHchwc2jLKucU15aU0W+7jg18AsEL/o4iiyi3zFadpqeenxBC1B V2bDHpELz1BjrEemqztC0ED2USe1Elw9yvGPzbxIUXeYJHlXLWNw67HyF2bRRs8G xtd1fbl2aqstLnjnt6jWRSgW8M+UIswWS/71gejwi4Xk/81XhcZwIdJm4mOxLmF8 QFbic+uBzk9seifUTCLItWxyRihpjTR0PITn
  • From Rainer Dorsch@21:1/5 to All on Sun Mar 7 13:10:01 2021
    Am Sonntag, 7. März 2021, 12:30:38 CET schrieb Rainer Dorsch:
    I also checked within gnucash:

    The currency problem you describe above I see as well.

    The prices for the funds work well.

    This was too optimistic:

    I see issues there. It seems that all fund prices inside gnucash the the price of the first fund. Very strange. I will check on the gnucash mailing list if somebody has every tried this.

    Thanks
    Rainer
    --
    Rainer Dorsch
    http://bokomoko.de/

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rainer Dorsch@21:1/5 to All on Sun Mar 7 12:40:02 2021
    Am Sonntag, 7. März 2021, 01:57:11 CET schrieb gregor herrmann:
    On Sat, 06 Mar 2021 09:47:59 +0100, Rainer Dorsch wrote:
    Hi Gregor,

    Hi Rainer,


    Hi Gregor :-)

    Although it throws quite some errors, the modules relevant for me seem to work
    (which is not the case in 1.49 release in the Debian repo):
    Thanks for bringing this to our attention.

    Could you explain what problems 1.49-1 has?
    I'm asking because there are no bug reports in the Debian BTS about
    it.


    I think the users understand if a service breaks, this is an upstream issue due to a change on the website, not a problem of the Debian package. Therefore I never even considered to open a bug report against the Debian package.

    As an example the VWD module does not work at all anymore since I believe the entire service is not available anymore.

    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$ ./stockdump.pl VWD LU1136260384
    $VAR1 = {
    'LU1136260384source' => 'VWD',
    'LU1136260384errormsg' => 'HTTP error 410 Gone',
    'LU1136260384success' => 0
    };
    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$

    I did not really find another source for funds for more than one provider in 1.49.

    I think here you get the best overview over the problems in the old release:

    https://github.com/finance-quote/finance-quote/issues?q=is%3Aissue+is%3Aclosed

    and fixes for the new release.

    I think it would be worthwhile to do a proper update by somebody who has some more experience in perl and Debian packaging.

    I've imported the 1.50-rc1 tarball into our packaging repo. [0] It
    contains huge changes (might be called a partial rewrite) and took
    some work to get a working package again (e.g. with patches, as
    you noted, and also with dependencies etc.)

    Wow, that was super fast. I would not have expected this. I did not understand that the changes are so massive, I expected that they fixed some modules, removed some non-working modules (e.g. VWD) and added new working modules (e.g. Fondsweb).

    Typically I would not upload a release candidate, and I would not
    upload a package with huge changes during the soft freeze.
    OTOH, if 1.49-1 is indeed broken, we might want to take the risks …

    https://github.com/finance-quote/finance-quote/issues/173 is also not
    very encouraging …

    With the version from experimental, I see this issue as well.

    Maybe I should upload what we have now to experimental to get some
    testing?
    Ok, I just went ahead, and 1.50~rc1-1 is now (module buildds and
    mirror sync) in experimental.

    I think that is the perfect solution. Let users experiment with the new version. I think the ideal solution for this kind of package would be to supply updates to stable using the stable-backports repository.

    Rainer, do you have a chance to install and test this version?

    That is my pleasure. I noticed that it pulls quite a few additional packages:

    libcrypt-rc4-perl libdigest-perl-md5-perl libhtml-selector-xpath-perl libhtml- tokeparser-simple-perl libhtml-treebuilder-libxml-perl libjcode-pm-perl libole-storage-lite-perl libparse-recdescent-perl libspreadsheet-parseexcel- perl libspreadsheet-writeexcel-perl libspreadsheet-xlsx-perl
    libtext-trim-perl libunicode-map-perl libuniversal-require-perl libweb- scraper-perl libyaml-perl

    Works nicely here (and all the error messages I saw are gone :-) ):

    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$ ./stockdump.pl Fondsweb LU1136260384
    $VAR1 = {
    'LU1136260384method' => 'fondsweb',
    'LU1136260384date' => '03/05/2021',
    'LU1136260384type' => 'fund',
    'LU1136260384isodate' => '2021-03-05',
    'LU1136260384currency' => 'EUR',
    'LU1136260384success' => 1,
    'LU1136260384isin' => 'LU1136260384',
    'LU1136260384nav' => '273.28',
    'LU1136260384year_range' => '353.97 - 72.23',
    'LU1136260384name' => 'green benefit Global Impact Fund P',
    'LU1136260384last' => '273.28'
    };
    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$

    I also checked within gnucash:

    The currency problem you describe above I see as well.

    The prices for the funds work well.

    In the process I also hit one glitch in Fondsweb.pm, which I reported upstream (without thinking) and with a proposed fix:

    https://github.com/finance-quote/finance-quote/issues/179

    So still no Debian bug report ;-)

    Many thanks
    Rainer

    --
    Rainer Dorsch
    http://bokomoko.de/

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rainer Dorsch@21:1/5 to All on Fri Mar 19 21:10:01 2021
    Hi Gregor,

    version 1.50rc2 is tagged, it fixes the issue you pointed to

    https://github.com/finance-quote/finance-quote/issues/173

    and the one I reported upstream

    https://github.com/finance-quote/finance-quote/issues/179

    If you find some time, can you upload it to experimental, then I would test drive it?

    Thanks
    Rainer


    Am Sonntag, 7. März 2021, 12:30:38 CET schrieb Rainer Dorsch:
    Am Sonntag, 7. März 2021, 01:57:11 CET schrieb gregor herrmann:
    On Sat, 06 Mar 2021 09:47:59 +0100, Rainer Dorsch wrote:
    Hi Gregor,

    Hi Rainer,

    Hi Gregor :-)

    Although it throws quite some errors, the modules relevant for me seem
    to
    work

    (which is not the case in 1.49 release in the Debian repo):
    Thanks for bringing this to our attention.

    Could you explain what problems 1.49-1 has?
    I'm asking because there are no bug reports in the Debian BTS about
    it.

    I think the users understand if a service breaks, this is an upstream issue due to a change on the website, not a problem of the Debian package. Therefore I never even considered to open a bug report against the Debian package.

    As an example the VWD module does not work at all anymore since I believe
    the entire service is not available anymore.

    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$ ./stockdump.pl VWD LU1136260384
    $VAR1 = {
    'LU1136260384source' => 'VWD',
    'LU1136260384errormsg' => 'HTTP error 410 Gone',
    'LU1136260384success' => 0
    };
    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$

    I did not really find another source for funds for more than one provider in 1.49.

    I think here you get the best overview over the problems in the old release:

    https://github.com/finance-quote/finance-quote/issues?q=is%3Aissue+is%3Aclos ed

    and fixes for the new release.

    I think it would be worthwhile to do a proper update by somebody who has some more experience in perl and Debian packaging.

    I've imported the 1.50-rc1 tarball into our packaging repo. [0] It
    contains huge changes (might be called a partial rewrite) and took
    some work to get a working package again (e.g. with patches, as
    you noted, and also with dependencies etc.)

    Wow, that was super fast. I would not have expected this. I did not understand that the changes are so massive, I expected that they fixed some modules, removed some non-working modules (e.g. VWD) and added new working modules (e.g. Fondsweb).

    Typically I would not upload a release candidate, and I would not
    upload a package with huge changes during the soft freeze.
    OTOH, if 1.49-1 is indeed broken, we might want to take the risks …

    https://github.com/finance-quote/finance-quote/issues/173 is also not
    very encouraging …

    With the version from experimental, I see this issue as well.

    Maybe I should upload what we have now to experimental to get some
    testing?
    Ok, I just went ahead, and 1.50~rc1-1 is now (module buildds and
    mirror sync) in experimental.

    I think that is the perfect solution. Let users experiment with the new version. I think the ideal solution for this kind of package would be to supply updates to stable using the stable-backports repository.

    Rainer, do you have a chance to install and test this version?

    That is my pleasure. I noticed that it pulls quite a few additional
    packages:

    libcrypt-rc4-perl libdigest-perl-md5-perl libhtml-selector-xpath-perl libhtml- tokeparser-simple-perl libhtml-treebuilder-libxml-perl libjcode-pm-perl libole-storage-lite-perl libparse-recdescent-perl libspreadsheet-parseexcel- perl libspreadsheet-writeexcel-perl libspreadsheet-xlsx-perl
    libtext-trim-perl libunicode-map-perl libuniversal-require-perl libweb- scraper-perl libyaml-perl

    Works nicely here (and all the error messages I saw are gone :-) ):

    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$ ./stockdump.pl Fondsweb LU1136260384
    $VAR1 = {
    'LU1136260384method' => 'fondsweb',
    'LU1136260384date' => '03/05/2021',
    'LU1136260384type' => 'fund',
    'LU1136260384isodate' => '2021-03-05',
    'LU1136260384currency' => 'EUR',
    'LU1136260384success' => 1,
    'LU1136260384isin' => 'LU1136260384',
    'LU1136260384nav' => '273.28',
    'LU1136260384year_range' => '353.97 - 72.23',
    'LU1136260384name' => 'green benefit Global Impact Fund P',
    'LU1136260384last' => '273.28'
    };
    rd@h370:/usr/share/doc/libfinance-quote-perl/examples$

    I also checked within gnucash:

    The currency problem you describe above I see as well.

    The prices for the funds work well.

    In the process I also hit one glitch in Fondsweb.pm, which I reported upstream (without thinking) and with a proposed fix:

    https://github.com/finance-quote/finance-quote/issues/179

    So still no Debian bug report ;-)

    Many thanks
    Rainer


    --
    Rainer Dorsch
    http://bokomoko.de/

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Rainer Dorsch on Fri Mar 19 22:00:01 2021
    On Fri, 19 Mar 2021 20:59:42 +0100, Rainer Dorsch wrote:

    version 1.50rc2 is tagged,
    […]
    If you find some time, can you upload it to experimental, then I would test drive it?

    Sure, thanks for the pointer.
    Uploaded to experimental right now, should appear on the mirrors
    soonish.


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: J.J. Cale: Sensitive Kind

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmBVDztfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgb2xBAAigJNB7h/0nw3oYtbuplB0qrTSytSqamlXWvKy7HlnmsK/vrRms7evq5/ pJtiNUjqdRDm8gWD6gx9JYQPECn5WS2tIO9+smLMJiZPgr/LY/fn2bro/HKhnTrs l4WpS/cQszwrxwgiVh9LA185Hg9BWvnVg8IuEUlfujPSdyVmIv8y8i+jS5XZQV+f 3ysMXqV9dVsydPXD5Gz+JuJ5LO3oLXRElF4vp5AdLNEPinRZUyU1/9r1muZ6UWjn fEIaZ3LF9KBkyDs+6BiGZjTaYEDs7D5fTG0KmtnzlpVQiIXSMelScyXkg5dftOS0 uFMoaqz+cvoRyfMI0Udr+TNGCYz9i6e7uO9Gnv0yTC6lGbFXu+8e6KK1G/3r9U0C AWwi+1C9UNRAfQUN0SUsGCWU+4P/LiLJRjBgp4oAKiw6FkpQyi3A42wUT+/oXF+W CPtHiA91mhac5C3n3oDXPz4maV3w9bRk906ktM9PRDC/o
  • From Rainer Dorsch@21:1/5 to All on Sat Mar 20 17:30:01 2021
    Am Freitag, 19. März 2021, 21:53:15 CET schrieb gregor herrmann:
    On Fri, 19 Mar 2021 20:59:42 +0100, Rainer Dorsch wrote:
    version 1.50rc2 is tagged,

    […]

    If you find some time, can you upload it to experimental, then I would
    test
    drive it?

    Sure, thanks for the pointer.
    Uploaded to experimental right now, should appear on the mirrors
    soonish.

    Many thanks Gregor.

    Works very well for me with bullseye.

    I think it has less problems than the version in bullseye. I did not hit any problem so far, but at least there are a few open bug reports upstream:

    https://github.com/finance-quote/finance-quote/issues

    For me both installing from experimental and bullseye works. For a random Debian user it would probably preferable to get that version into bullseye. But you as an experienced maintainer should decide if that makes sense for you to bring 1.50rc2 into bullseye.

    Many thanks from my side :-)
    Rainer

    --
    Rainer Dorsch
    http://bokomoko.de/

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Rainer Dorsch on Sun Mar 28 02:30:01 2021
    On Sat, 20 Mar 2021 17:26:23 +0100, Rainer Dorsch wrote:

    Uploaded to experimental right now, should appear on the mirrors
    soonish.

    Works very well for me with bullseye.
    I think it has less problems than the version in bullseye. I did not hit any problem so far,

    Thanks for testing and reporting back!

    but at least there are a few open bug reports upstream: https://github.com/finance-quote/finance-quote/issues

    I checked the issues and pull requests there; I can't reproduce #180,
    and I grabbed #182 as another patch.

    For me both installing from experimental and bullseye works. For a random Debian user it would probably preferable to get that version into bullseye. But you as an experienced maintainer should decide if that makes sense for you
    to bring 1.50rc2 into bullseye.

    After pondering this issue a bit, I guess this rc2 is probably indeed
    a better choice (as in "at least less broken"), so I uploaded it to
    unstable now, and it should migrate to testing (and therefore end up
    in the bullseye release) in 20 days.

    Thanks again for your help, and please shout if you discover anything
    relevant about this package in the future :)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Fleetwood Mac: No Questions Asked

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmBfzdFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgaArg//XUUWC7qGkNERRluq4A7YQMKhrcjFM+SXdXhZDvyXss50i9yGMxj5gb/l l3r/jM662Qp8hiB0zDpurFDvCRvuZV/oJ6pr/ZvkOiUxr2v60SI3sNKDmliNINev 7ZBlI9sKVmhEC3PyGblqv0ucfefRSx1RoDig+Ai0ceHXyC78hktevmhyWuR1tizp jEQpBvqnAgGcJj+pWz/fOm7eRpXWmKorN2tk9TqpMc9XTYULZBpRSgxLnrOdeFDe 6hEDb61/5NTyFBmq13LeHnytCF5lwl5iyl936ukXPgOINjyumQxvzUHCPdlfu5oL be5nNn7+Hfda4oapvxv4Jqfe7Ph0CUUMn0Ue4kMqJj2aTS+nyGSZr0+BmrTSxbc4 uLSyRj1sOl907VaCF/tOAsMf7WF2pKmTvwt6Nk4PZ8hxRzsdLzs/icAhTyg/l/or 1dSofCAg6IMDSXjaRJRq/GXkMWHsA48tToDqER71kj1/g4Xr1BK7c0yi4fBXA53u NCDu3jgJYnRCfO/41XnK+PUAVuQUgEcFhih7HGTbM+cBqY7zF/okJZ/Al14tKfs1 U0zKY6L/5+rdHheRVek0iRcslyHtvQFGGAYJoKXAe0q9t9kZZQbDhKoktt+lPF7m u83o7L1JpcH+rTiA506ky+Bl3+oqW8E6mB0VgL1SsE+4fb9B1og=
    =Pk8p
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rainer Dorsch@21:1/5 to All on Mon Mar 29 00:10:01 2021
    This is a multi-part message in MIME format.

    Am Sonntag, 28. März 2021, 01:28:57 CEST schrieb gregor herrmann:
    On Sat, 20 Mar 2021 17:26:23 +0100, Rainer Dorsch wrote:
    Uploaded to experimental right now, should appear on the mirrors
    soonish.

    Works very well for me with bullseye.
    I think it has less problems than the version in bullseye. I did not hit any problem so far,

    Thanks for testing and reporting back!

    but at least there are a few open bug reports upstream: https://github.com/finance-quote/finance-quote/issues

    I checked the issues and pull requests there; I can't reproduce #180,
    and I grabbed #182 as another patch.

    For me both installing from experimental and bullseye works. For a random Debian user it would probably preferable to get that version into
    bullseye.
    But you as an experienced maintainer should decide if that makes sense for you to bring 1.50rc2 into bullseye.

    After pondering this issue a bit, I guess this rc2 is probably indeed
    a better choice (as in "at least less broken"), so I uploaded it to
    unstable now, and it should migrate to testing (and therefore end up
    in the bullseye release) in 20 days.

    Many thanks for taking care Gregor. I am impressed, that it seems, you managed to get that update into bullseye.

    This makes bullseye even more valuable for me (and hopefully many others).

    Thanks again for your help, and please shout if you discover anything relevant about this package in the future :)


    Thank your for your great support. That is outstanding!

    Rainer


    --
    Rainer Dorsch
    http://bokomoko.de/
    <html>
    <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    </head>
    <body><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Am Sonntag, 28. März 2021, 01:28:57 CEST schrieb gregor herrmann:</p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; On Sat, 20 Mar 2021 17:26:23 +0100, Rainer Dorsch wrote:</p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; &gt; &gt; Uploaded to experimental right now, should appear on the mirrors</p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; &gt; &gt; soonish.</p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; &gt; </p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; &gt; Works very well for me with bullseye.</p>
    <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">&gt; &gt; I think it has less problems than the version in bullseye. I d