I have marked this package 'unstable' to signify that I believe it is ready
to upload.
All suggested changes have been completed, with the exception of one:
W: libintl-perl: national-encoding usr/share/doc/libintl-perl/examples/simplecal/po/ar.po
Well, yes. Might warrant an override.
I tried to run 'iconv' against this as a possible override, but alas it
baulked at the line 18 - the very first converted value in Arabic.
Added a Lintian override for 'national-encoding'.
Please advise if not suitable, as I can always revert the Lintain override.
--
Ken Ibbotson
E:
keni@computer.org
*"Reality is merely an illusion, albeit a very persistent one."*
- Albert Einstein (1879-1955)
On Mon, 18 Jan 2021 at 01:29, gregor herrmann <
gregoa@debian.org> wrote:
On Mon, 11 Jan 2021 20:48:27 +1030, Ken Ibbotson wrote:
Please review and upload if acceptable.
dpt checkout libintl-perl
Thanks for your work on this package!
Some remarks:
- d/changelog:
+ "Peter Eisentraut <petere@debian.org> moved to Uploaders." should
be removed, as you have later correctly removed them from
Uploaders.
+ Maybe document some more of your changes (e.g. the conversion of
d/copyright is missing).
- d/copyright:
+ including old copyright holders for debian/* might be nice,
cf. `dh-make-perl refresh --only copyright'
+ you used "Artistic or GPL-1+" for debian/*, which is of course
fine; in general we use the superset of upstream license and perl
license, aka "GPL-3+ or Artistic or GPL-1+"
- d/control:
+ "perl (>= 5.8.0-7)" -> the version can be dropped, as even oldoldstable
has 5.20; cf. `cme fix dpkg-control'
+ this also removes the version from "dpkg-dev (>= 1.16.1~)", and
an unversioned dpkg-dev can be dropped completely
- debian/.gbp.conf
does this work? gbp.conf(5) mentions debian/gbp.conf.
- lintian overrides: they make me curious, especially because they
don't have a comment, explaining what they do :)
Let's see:
I: libintl-xs-perl: unused-override unusual-interpreter
So this one can be removed
O: libintl-perl: unusual-interpreter usr/share/perl5/Locale/Messages.pm #!/bin/false
Hm, ok weird but well …
- debian/rules:
+ PERL_MM_USE_DEFAULT=1 can be removed (I believe it's set by the
debhelper perl makemaker buildsystem)
+ The old d/rules had some none-default commands which are missing
now. Let's see what they do …
Test 1: building twice in a row. This fails with
dpkg-source: info: local changes detected, the modified files are:
libintl-perl-1.26/ReleaseNotes
libintl-perl-1.26/config.log
So these two files should be put into debian/clean
Then we had "dh_install -i --exclude=xs", which surprised me but
explains the lintian warning
W: libintl-perl source: binaries-have-file-conflict libintl-perl libintl-xs-perl usr/share/man/man3/Locale::gettext_xs.3pm.gz
i.e. this file is in both packages which is prevented by the
--exclude. - Hm, how is this written nowadays?
The following seems to work:
override_dh_install:
dh_install -a
dh_install -i --exclude=xs
- autopkgtests fail or are skipped … We need
+ debian/tests/pkg-perl/smoke-files with test.pl and tests/
and then it still fails *sigh*
cannot open './xs_disabled': No such file or directory at ./test.pl
line 59.
So we need a smoke-setup as well … and here we go.
+ debian/tests/pkg-perl/use-name with the name of one perl module,
maybe Locale::Recode
+ I've committed and pushed the autopkgtests changes as I already
have them here :)
2 patches have been raised to handle spelling and POD markup corrections.
Thanks.
I did have to increment the dot version in changelog as the 3000 build action currently happening updated to version, and the 'dpt takeover'
used
the same version number '1.26-2.1`.
This (-2.2) is not correct. -X.Y are for non-maintainer uploads by
convention (as the -2.1 from Holger) but since we are doing a regular maintainer upload now, -3 is the next "regular" debian revision.
See also lintian's
W: libintl-perl source: maintainer-upload-has-incorrect-version-number 1.26-2.2
Not sure if this may be a bug with the takeover script.
Well, what dpt-takeover did was
+libintl-perl (1.26-2.1ubuntu1) UNRELEASED; urgency=medium
which points to a different enironment :)
(In general, dpt-takeover just calls `dch' which picks the next
version.)
Lintian does show a couple more items - please advise on the same if not ready for upload.
Let's see what else we have besides the messages already discussed:
W: libintl-perl: national-encoding usr/share/doc/libintl-perl/examples/simplecal/po/ar.po
Well, yes. Might warrant an override.
I: libintl-perl source: duplicate-short-description libintl-perl libintl-xs-perl
Hm, yes, the short description is identical. If there is some space
in <80 characters, libintl-xs-perl could add something about XS
there.
If not, no big deal.
I: libintl-perl: example-wrong-path-for-interpreter usr/share/doc/libintl-perl/examples/simplecal/Makefile.PL (#!/usr/local/bin/perl != /usr/bin/perl)
I: libintl-perl: example-wrong-path-for-interpreter usr/share/doc/libintl-perl/examples/simplecal/bin/simplecal.pl (#!/usr/local/bin/perl != /usr/bin/
P: libintl-perl: example-unusual-interpreter usr/share/doc/libintl-perl/examples/simplecal/lib/SimpleCal.pm #!/bin/false
I think these should be fixed (at least the first two). https://perl-team.pages.debian.net/debhelper.html has some recipes,
cf. the "Note on paths" and "Fixing Interpreter Shebang Lines"
sections
I: libintl-perl source: patch-not-forwarded-upstream debian/patches/dot-inc.patch
Might be worth taking a look at (if it's already fixed upstream or
needs forwarding etc.)
Ok, I think that's all for now :)
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Mark Knopfler: Irish Boy
<div dir="ltr"><div dir="ltr"><div>I have marked this package 'unstable' to signify that I believe it is ready to upload.</div><div><br></div><div>All suggested changes have been completed, with the exception of one:</div><div><br></div><div
style="margin-left:40px">W: libintl-perl: national-encoding usr/share/doc/libintl-perl/examples/simplecal/po/ar.po<br>
Well, yes. Might warrant an override.</div><div><br></div><div>I tried to run 'iconv' against this as a possible override, but alas it baulked at the line 18 - the very first converted value in Arabic.</div><div>Added a Lintian override for '
national-encoding'.</div><div><br></div><div>Please advise if not suitable, as I can always revert the Lintain override.<br></div><div><br></div><div></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="
ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:
keni@computer.org" target="_blank">
keni@computer.org</a><br><div><br></div><div><i>"Reality is merely an illusion, albeit a very persistent one."</i></div> - Albert Einstein (1879-
1955)<br></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 18 Jan 2021 at 01:29, gregor herrmann <<a href="mailto:
gregoa@debian.org">
gregoa@debian.org</a>> wrote:<br></div><blockquote
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 11 Jan 2021 20:48:27 +1030, Ken Ibbotson wrote:<br>
> Please review and upload if acceptable.<br>
> dpt checkout libintl-perl<br>
Thanks for your work on this package!<br>
Some remarks:<br>
- d/changelog:<br>
+ "Peter Eisentraut <<a href="mailto:
petere@debian.org" target="_blank">
petere@debian.org</a>> moved to Uploaders." should<br>
be removed, as you have later correctly removed them from<br>
Uploaders.<br>
+ Maybe document some more of your changes (e.g. the conversion of<br>
d/copyright is missing).<br>
- d/copyright:<br>
+ including old copyright holders for debian/* might be nice,<br>
cf. `dh-make-perl refresh --only copyright'<br>
+ you used "Artistic or GPL-1+" for debian/*, which is of course<br>
fine; in general we use the superset of upstream license and perl<br>
license, aka "GPL-3+ or Artistic or GPL-1+"<br>
- d/control:<br>
+ "perl (>= 5.8.0-7)" -> the version can be dropped, as even oldoldstable<br>
has 5.20; cf. `cme fix dpkg-control'<br>
+ this also removes the version from "dpkg-dev (>= 1.16.1~)", and<br>
an unversioned dpkg-dev can be dropped completely<br>
- debian/.gbp.conf<br>
does this work? gbp.conf(5) mentions debian/gbp.conf.<br>
- lintian overrides: they make me curious, especially because they<br>
don't have a comment, explaining what they do :)<br>
Let's see:<br>
I: libintl-xs-perl: unused-override unusual-interpreter<br>
So this one can be removed<br>
O: libintl-perl: unusual-interpreter usr/share/perl5/Locale/Messages.pm #!/bin/false<br>
Hm, ok weird but well …<br>
- debian/rules:<br>
+ PERL_MM_USE_DEFAULT=1 can be removed (I believe it's set by the<br>
debhelper perl makemaker buildsystem)<br>
+ The old d/rules had some none-default commands which are missing<br>
now. Let's see what they do …<br>
Test 1: building twice in a row. This fails with<br>
dpkg-source: info: local changes detected, the modified files are:<br>
libintl-perl-1.26/ReleaseNotes<br>
libintl-perl-1.26/config.log<br>
So these two files should be put into debian/clean<br>
Then we had "dh_install -i --exclude=xs", which surprised me but<br>
explains the lintian warning<br>
W: libintl-perl source: binaries-have-file-conflict libintl-perl libintl-xs-perl usr/share/man/man3/Locale::gettext_xs.3pm.gz<br>
i.e. this file is in both packages which is prevented by the<br>
--exclude. - Hm, how is this written nowadays?<br>
The following seems to work:<br>
override_dh_install:<br>
dh_install -a<br>
dh_install -i --exclude=xs<br>
- autopkgtests fail or are skipped … We need<br>
+ debian/tests/pkg-perl/smoke-files with <a href="
http://test.pl" rel="noreferrer" target="_blank">test.pl</a> and tests/<br>
and then it still fails *sigh*<br>
cannot open './xs_disabled': No such file or directory at ./<a href="
http://test.pl" rel="noreferrer" target="_blank">test.pl</a> line 59.<br>
So we need a smoke-setup as well … and here we go.<br>
+ debian/tests/pkg-perl/use-name with the name of one perl module,<br>
maybe Locale::Recode<br>
+ I've committed and pushed the autopkgtests changes as I already<br>
have them here :)<br>
> 2 patches have been raised to handle spelling and POD markup corrections.<br>
Thanks.<br>
> I did have to increment the dot version in changelog as the 3000 build<br> > action currently happening updated to version, and the 'dpt takeover' used<br>
> the same version number '1.26-2.1`.<br>
This (-2.2) is not correct. -X.Y are for non-maintainer uploads by<br> convention (as the -2.1 from Holger) but since we are doing a regular<br> maintainer upload now, -3 is the next "regular" debian revision.<br>
See also lintian's<br>
W: libintl-perl source: maintainer-upload-has-incorrect-version-number 1.26-2.2<br>
> Not sure if this may be a bug with the takeover script.<br>
Well, what dpt-takeover did was<br>
+libintl-perl (1.26-2.1ubuntu1) UNRELEASED; urgency=medium<br>
which points to a different enironment :)<br>
(In general, dpt-takeover just calls `dch' which picks the next<br> version.)<br>
> Lintian does show a couple more items - please advise on the same if not<br>
> ready for upload.<br>
Let's see what else we have besides the messages already discussed:<br>
W: libintl-perl: national-encoding usr/share/doc/libintl-perl/examples/simplecal/po/ar.po<br>
Well, yes. Might warrant an override.<br>
I: libintl-perl source: duplicate-short-description libintl-perl libintl-xs-perl<br>
Hm, yes, the short description is identical. If there is some space<br>
in <80 characters, libintl-xs-perl could add something about XS<br> there.<br>
If not, no big deal.<br>
I: libintl-perl: example-wrong-path-for-interpreter usr/share/doc/libintl-perl/examples/simplecal/Makefile.PL (#!/usr/local/bin/perl != /usr/bin/perl)<br>
I: libintl-perl: example-wrong-path-for-interpreter usr/share/doc/libintl-perl/examples/simplecal/bin/<a href="
http://simplecal.pl" rel="noreferrer" target="_blank">simplecal.pl</a> (#!/usr/local/bin/perl != /usr/bin/<br>
P: libintl-perl: example-unusual-interpreter usr/share/doc/libintl-perl/examples/simplecal/lib/SimpleCal.pm #!/bin/false<br>
I think these should be fixed (at least the first two).<br>
<a href="
https://perl-team.pages.debian.net/debhelper.html" rel="noreferrer" target="_blank">
https://perl-team.pages.debian.net/debhelper.html</a> has some recipes,<br>
cf. the "Note on paths" and "Fixing Interpreter Shebang Lines"<br>
sections<br>
I: libintl-perl source: patch-not-forwarded-upstream debian/patches/dot-inc.patch<br>
Might be worth taking a look at (if it's already fixed upstream or<br> needs forwarding etc.)<br>
Ok, I think that's all for now :)<br>
Cheers,<br>
gregor<br>
-- <br>
.''`. <a href="
https://info.comodo.priv.at" rel="noreferrer" target="_blank">
https://info.comodo.priv.at</a> -- Debian Developer <a href="
https://www.debian.org" rel="noreferrer" target="_blank">
https://www.debian.org</a><br>
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06<br>
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe<br>
`- NP: Mark Knopfler: Irish Boy<br>
</blockquote></div></div>
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)