• Updated GnuPG::Interface

    From Andrew Ruthven@21:1/5 to All on Sun Jul 5 15:00:01 2020
    Hey,

    As part of my work to get Request Tracker 5.0 ready for uploading to Experimental I needed to have GnuPG::Interface v 1.00 packaged.

    I've picked up the work from Salvatore and finished getting the
    packaging updated for the new upstream release. Good news, I could drop
    all the Debian patches as they're all merged, or re-implemented
    upstream.

    If someone could please review, and ideally build and upload it, that'd
    be much appreciated.

    Cheers,
    Andrew

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Andrew Ruthven on Sun Jul 5 16:00:02 2020
    On Mon, 06 Jul 2020 00:57:45 +1200, Andrew Ruthven wrote:

    I've picked up the work from Salvatore and finished getting the
    packaging updated for the new upstream release. Good news, I could drop
    all the Debian patches as they're all merged, or re-implemented
    upstream.

    Thanks for your work, much appreciated.

    If someone could please review, and ideally build and upload it, that'd
    be much appreciated.

    I added a couple of small commits, and I put two questions in
    debian/changelog, for you and others :)

    I hope that Salvatore or someone else more familiar with the package
    can take a look as well but in generall this looks all good to me.


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `-

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8B3ERfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgbDYBAAqAS1y5D+BY1o8mz05HQT3Z9yUzpBJFit1aHaRWFMfZoFDvEB9N5ckF2W cATogMs2vKNKKQfZVwoskiy6ILW4BAI/YrtlV2MiXGBgeeFrI4h0mo5+Tr5HiY8A pgy2DtAAWl1YsbcMLVfVhouT3jCLsiPN4ujoNM5GwZ7zhjThw7c9Ub2UpcH+0EYd t13XhSxhnn+Q2AOAUOiSLhaJq3SP3olbCCn8YM7JTx4KPKaGKFhmNHjP2YbOy2h0 Dc/xkY9qb/yPs5nUoQf6dpHJ0oe1eKkMKx4rMgZA9975RbnTbbWK5bEgJu5qNM51 uUZniheAlGrCoCdPfH6cj+SzZsKUQfpOEdynfdhvuMqFtV8P5M07Tm/vxKfrCMRJ oWMdqbEokqR14zdtOR4fMdpm3zjL9qg017mo5bKtlJkQgiyQxxEhytj+S1/3GRcC bXHrn6vj+slKdJoSLrJWMoZ8RClWOGwsS3+G3wW9T8mlv+YB0DrVhhmfXC9P+5fA 4qJuESX7jzZIWG3bi2RS3aqmZ3uI/0KibCgh9i6t4cYgt8uiWMssP0CSfmFWwBwF dTndTnfkN2j6WzS5dQOsonfOvtIFOCEyy0bpfFkkeM6fQYJ0uJjRyhxekfJUsLaV PT2ezGRLaorkBg4i3VMlmkCioocEreag+YJtF9nJCz+i8P4pCjI=
    =FprM
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andrew Ruthven@21:1/5 to gregor herrmann on Mon Jul 6 01:40:01 2020
    On Sun, 2020-07-05 at 15:57 +0200, gregor herrmann wrote:

    I added a couple of small commits, and I put two questions in debian/changelog, for you and others :)

    I hope that Salvatore or someone else more familiar with the package
    can take a look as well but in generall this looks all good to me.

    They're good questions, I've resolved them both. The clean step was
    because when the tests failed due to an old patch the blib directory
    was left. I've moved it to a clean target.

    Last night laying in bed I realised I hadn't checked the dependencies
    on gnupg. I've now fixed those as well. ;)

    Cheers,
    Andrew

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Andrew Ruthven on Mon Jul 6 16:40:01 2020
    On Mon, 06 Jul 2020 11:33:14 +1200, Andrew Ruthven wrote:

    I added a couple of small commits, and I put two questions in debian/changelog, for you and others :)
    They're good questions, I've resolved them both. The clean step was
    because when the tests failed due to an old patch the blib directory
    was left. I've moved it to a clean target.

    I have to admit that I'm still not convinced that this needed; an
    inconsistent state after a failed build (due to a failed test) is
    nothing I would worry about, and nothing we handle in other packages.
    (And maybe EUMM or M::B rm blib/ anyway?)

    After your last change, which kind of "hijacks" the clean target, the
    package now fails to build twice in a row:

    [end of first build]
    dpkg-deb: building package 'libgnupg-interface-perl' in '../libgnupg-interface-perl_1.00-1_all.deb'.
    dpkg-genbuildinfo
    dpkg-genchanges >../libgnupg-interface-perl_1.00-1_amd64.changes dpkg-genchanges: info: including full source code in upload
    dpkg-source --after-build .
    dpkg-buildpackage: info: full upload (original source is included) dpkg-buildpackage: info: source package libgnupg-interface-perl dpkg-buildpackage: info: source version 1.00-1
    dpkg-buildpackage: info: source distribution UNRELEASED
    dpkg-buildpackage: info: source changed by Debian Janitor <janitor@jelmer.uk>
    dpkg-source --before-build .
    dpkg-buildpackage: info: host architecture amd64
    debian/rules clean
    rm -rf blib
    dpkg-source -b .
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Interface.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Signature.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Fingerprint.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Options.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::PublicKey.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::SubKey.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Key.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Revoker.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Handles.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::UserAttribute.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::SecretKey.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::UserId.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::PrimaryKey.3pm.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/doc/libgnupg-interface-perl/changelog.Debian.gz
    dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/doc/libgnupg-interface-perl/changelog.gz
    dpkg-source: error: detected 15 unwanted binary files (add them in debian/source/include-binaries to allow their inclusion).
    dpkg-source: info: using source format '3.0 (quilt)'
    dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255 E: Failed autobuilding of package


    I suggest to remove the rm from debian/rules.
    (And if there should be a case to care for blib/ manually, to stick
    it into debian/clean.)
    (And the current override_dh_clean doesn't do anything and can be
    removed).

    Oh, and override_dh_auto_configure also can be removed, as
    Makefile.PL does basically the same now.


    I've now pushed these changes to debian/rules, please shout if you
    see any problem or have any issues building!


    Last night laying in bed I realised I hadn't checked the dependencies
    on gnupg. I've now fixed those as well. ;)

    Great, thanks!


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Donovan: Epistle To Derroll

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8DN39fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZkCQ/+NdC6QGQa3LBfvyDIU8+QNRUc536AQn8tkO9L37vAlWpbpg+bh5PM0QRn ZSarT380H5oobYnUzg2fIE8x2vdYbuRE3avlcIPu6bRrjRRicyw+Zq+vVJ/SAUEG tAiktk75fra2U4fCGl7yxb6zptYyuIq5+3YbJKTNkXY5I3tIJpa2aP8SXzSQlBiD 6yfcfMr8gnhd1K/vFjHJXsK90HVnn1H+Lv5dbBLuoTGAfuekJrmyaXTxTdbTyH27 PRLObCWdxixJjY3II9xeMmhlWS8Py+i3zBnQVM9mabOXen+fVCmi7WfeYrl6aoCv lXiwx8Uahrp7kYevAfFirBy3DaFxAUTC2NyJ5KIvXCXk8attTeSBt5L2kmF/mePn 1UQ//JAa5XAu07pMjcfrtNGjZ5SCBhPHvrwy9CUGUDCKX/UH2WHGXzkUFLDJXOad TmSY6N2RKCnx0BcdclztP0xIX3vr5qu0830VcXL5KWMM9hWpf2pgxycJ/OsUlP/+ 2GgQ7r9qVNSUl3d9A2I0RP0rj7hD9rmIPKfnyLgfSX/RQ8t3NbWH1S8SyvoeNSf6 baALB+W4Eaqw82EkzISBvpclwHMycMUeDtNOJxuyf0UAO+X1h2lpNtf7/VwBOm0i HcF9jCLIU7T7TACRycP32ajebkRdE10TQGe0Xf05pmxIUyp/7I8=
    =P/oV
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andrew Ruthven@21:1/5 to gregor herrmann on Tue Jul 7 01:20:01 2020
    On Mon, 2020-07-06 at 16:38 +0200, gregor herrmann wrote:
    On Mon, 06 Jul 2020 11:33:14 +1200, Andrew Ruthven wrote:

    I have to admit that I'm still not convinced that this needed; an inconsistent state after a failed build (due to a failed test) is
    nothing I would worry about, and nothing we handle in other packages.
    (And maybe EUMM or M::B rm blib/ anyway?)

    After your last change, which kind of "hijacks" the clean target, the
    package now fails to build twice in a row:

    Oh, interesting. It worked for me.

    [snip]
    I suggest to remove the rm from debian/rules.
    (And if there should be a case to care for blib/ manually, to stick
    it into debian/clean.)
    (And the current override_dh_clean doesn't do anything and can be
    removed).
    Oh, and override_dh_auto_configure also can be removed, as
    Makefile.PL does basically the same now.


    I've now pushed these changes to debian/rules, please shout if you
    see any problem or have any issues building!

    Sure, no worries.

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andrew Ruthven@21:1/5 to All on Tue Jul 21 09:10:02 2020
    Hey,

    GnuPG::Interface made a change to handle both GnuPG version 1.4 and 2.2
    and it does that by tracking the version of gpg that is being used. But
    it failed to clear the cached version information if you changed the
    gpg binary to use after the object was instantiated.

    This is exactly how Request Tracker changes the gpg binary to use with GnuPG::Interface, and caused request-tracker4 to FTBFS.

    I've pushed a commit to libgnupg-interface-perl which resolves this
    behaviour. We also now test libgnupg-interface-perl against both
    versions of GnuPG.

    If someone could please review and (hopefully) upload the package,
    that'd be much appreciated.

    Cheers,
    Andrew

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Andrew Ruthven on Tue Jul 21 19:30:02 2020
    On Tue, 21 Jul 2020 19:02:12 +1200, Andrew Ruthven wrote:

    GnuPG::Interface made a change to handle both GnuPG version 1.4 and 2.2
    and it does that by tracking the version of gpg that is being used. But
    it failed to clear the cached version information if you changed the
    gpg binary to use after the object was instantiated.

    This is exactly how Request Tracker changes the gpg binary to use with GnuPG::Interface, and caused request-tracker4 to FTBFS.

    Thanks for your investigations and your work on this!

    I've pushed a commit to libgnupg-interface-perl which resolves this behaviour. We also now test libgnupg-interface-perl against both
    versions of GnuPG.

    If someone could please review and (hopefully) upload the package,
    that'd be much appreciated.

    Looks good to me in general.

    Some thoughts:

    - Does this also fix #964878?

    - Could you forward the relevant patches upstream (to the CPAN RT
    issue)? Then we can wait a bit and see if there are reactions
    before uploading.

    - The tests throw some warnings:

    t/import_keys.t ............
    1..2
    ok 1
    ok 2
    ok
    Can't exec "gnupg": No such file or directory at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 343.
    Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.
    Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.
    t/Interface.t ..............
    1..2
    ok 1
    ok 2
    ok

    t/import_keys.t ............
    1..2
    ok 1
    ok 2
    ok
    Can't exec "gnupg": No such file or directory at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 343.
    Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.
    Use of uninitialized value $a in split at /build/libgnupg-interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.
    t/Interface.t ..............
    1..2
    ok 1
    ok 2
    ok

    (So the same for gpg2 and gpg1). Is this expected/harmless/…?

    - Same in autopkgtests:

    t/Interface.t ..............
    1..2
    ok 1
    Can't exec "gnupg": No such file or directory at /usr/share/perl5/GnuPG/Interface.pm line 343.
    Use of uninitialized value $a in split at /usr/share/perl5/GnuPG/Interface.pm line 829, <GEN5> line 1.
    Use of uninitialized value $a in split at /usr/share/perl5/GnuPG/Interface.pm line 829, <GEN5> line 1.
    ok 2
    ok

    - Not sure if CALL is the nicest possible name for the env var but
    that's bikeshedding territory :)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: R.E.M.: Daysleeper

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8XJfdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZ17g//UcDc58/kdeFodZ9e9gHQbQFmcxEsAwmvQTFGDd6AXnw5l+6rVwFgKJqq yaDAYkXhZ9J+SXp1jn1Ih5kCeK1MNNU4823ezIJ7G5yB62Tre9EbB5z1Ml6GoF2U 24aJowkZRaJix8q3z2M6fch/vhpyRGG5gXo49HdLOFdE1hOCCw7zAZBnWiWfOmWd jFcbMMBY/Vq7iBZawau7RsUaphmblU1j1ox2XDZzOIIg61KlOKMolfSWT38kOikj ne73mE80nSOewTZ57kWclRBTV23sgRep4zW2y4JCFqXrp7BCHkYisYzH6Gic/zNq DmozdhOJzaaUs4oZMQWFJPd0ZaOiVkvaJ78/XJijOWNx42f+S731/v52CzaTRJ/y gXDeieYHkUoqpG1LU/Tgp1sT5Q9fWByVGTXGteQakYwqC00UFh+5ls4E4RZPjRZt udF/1nB893g3zD3DcHZG4uH2SjZ4pxASGL3F+h+4SU5iAxCCE1qc
  • From Andrew Ruthven@21:1/5 to gregor herrmann on Thu Jul 23 14:00:02 2020
    On Tue, 2020-07-21 at 19:29 +0200, gregor herrmann wrote:
    On Tue, 21 Jul 2020 19:02:12 +1200, Andrew Ruthven wrote:

    I've pushed a commit to libgnupg-interface-perl which resolves this behaviour. We also now test libgnupg-interface-perl against both
    versions of GnuPG.

    If someone could please review and (hopefully) upload the package,
    that'd be much appreciated.

    Looks good to me in general.

    Some thoughts:

    - Does this also fix #964878?

    Sadly no it doesn't. Bug #964878 is caused because monkeysphere- validation-agent uses -T. GnuPG::Interface tries to use $ENV{PATH} -
    which hasn't been untainted - to find gpg.

    We have two options here. Either
    patch /usr/share/perl5/Crypt/Monkeysphere/MSVA.pm in msva-perl to use
    the full path to /usr/bin/gpg when GnuPG::Interface. Or we modify GnuPG::Interface to use the full path instead of just running "gpg".

    I'm leaning towards the later as otherwise we'll be playing whack-a-
    mole for any other Perl programs that use Taint. Thoughts?

    I'm happy to prepare that patch.

    - Could you forward the relevant patches upstream (to the CPAN RT
    issue)? Then we can wait a bit and see if there are reactions
    before uploading.

    I already have. ;) No response from upstream for the first one which I
    uploaded 5 days ago.

    Fix for RT4 breakage: https://rt.cpan.org/Ticket/Display.html?id=133021
    Fix for below warning: https://rt.cpan.org/Ticket/Display.html?d=133039

    - The tests throw some warnings:

    Can't exec "gnupg": No such file or directory at /build/libgnupg- interface-perl-1.00/blib/lib/GnuPG/Interface.pm line 343.
    Use of uninitialized value $a in split at /build/libgnupg-interface- perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.
    Use of uninitialized value $a in split at /build/libgnupg-interface- perl-1.00/blib/lib/GnuPG/Interface.pm line 829, <GEN5> line 1.

    (So the same for gpg2 and gpg1). Is this expected/harmless/…?

    It is harmless, but I agree it is off putting. I have added a patch
    which causes these warnings to be suppressed.

    - Not sure if CALL is the nicest possible name for the env var but
    that's bikeshedding territory :)

    I am open to suggestions, but since it is the string to be passed in to
    the call parameter, it seemed reasonable to me.

    Cheers,
    Andrew

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andrew Ruthven@21:1/5 to Andrew Ruthven on Thu Jul 23 14:50:01 2020
    On Thu, 2020-07-23 at 23:55 +1200, Andrew Ruthven wrote:
    We have two options here. Either
    patch /usr/share/perl5/Crypt/Monkeysphere/MSVA.pm in msva-perl to use
    the full path to /usr/bin/gpg when GnuPG::Interface. Or we modify GnuPG::Interface to use the full path instead of just running "gpg".

    I'm leaning towards the later as otherwise we'll be playing whack-a-
    mole for any other Perl programs that use Taint. Thoughts?

    I'm happy to prepare that patch.

    I've written a patch for this and pushed it. General case patch is
    submitted upstream here:

    https://rt.cpan.org/Ticket/Display.html?id=133041

    We'll need to carry our own patch even if upstream accepts it as I've
    set the default binary for gpg to be the full path so we don't need to
    use $ENV{PATH} or modify any programs that use GnuPG::Interface.

    Cheers,
    Andrew

    --
    Andrew Ruthven, Wellington, New Zealand
    andrew@etc.gen.nz |
    Catalyst Cloud: | This space intentionally left blank
    https://catalystcloud.nz |

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Dominic Hargreaves@21:1/5 to Andrew Ruthven on Thu Jul 23 15:00:02 2020
    On Fri, Jul 24, 2020 at 12:45:37AM +1200, Andrew Ruthven wrote:
    On Thu, 2020-07-23 at 23:55 +1200, Andrew Ruthven wrote:
    We have two options here. Either
    patch /usr/share/perl5/Crypt/Monkeysphere/MSVA.pm in msva-perl to use
    the full path to /usr/bin/gpg when GnuPG::Interface. Or we modify GnuPG::Interface to use the full path instead of just running "gpg".

    I'm leaning towards the later as otherwise we'll be playing whack-a-
    mole for any other Perl programs that use Taint. Thoughts?

    I'm happy to prepare that patch.

    I've written a patch for this and pushed it. General case patch is
    submitted upstream here:

    https://rt.cpan.org/Ticket/Display.html?id=133041

    We'll need to carry our own patch even if upstream accepts it as I've
    set the default binary for gpg to be the full path so we don't need to
    use $ENV{PATH} or modify any programs that use GnuPG::Interface.

    Agreed, we should be using the full path in any case to maintain
    interface stability. As packagers we shouldn't rely on the user's
    path not containing unexpected values.

    Cheers
    Dominic

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Andrew Ruthven on Fri Jul 24 14:30:01 2020
    On Thu, 23 Jul 2020 23:55:06 +1200, Andrew Ruthven wrote:

    On Tue, 2020-07-21 at 19:29 +0200, gregor herrmann wrote:
    If someone could please review and (hopefully) upload the package,
    that'd be much appreciated.
    Looks good to me in general.
    Some thoughts:

    [Lots of further work done & explained.]

    Thanks Andrew for the huge amount of work you put into fixing these
    issues!

    I added a small commit for autopkgtests (chmod the dummy scripts) and
    uploaded the package.


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Rolling Stones: Angie

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8a0xpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgbzZA/7BIc8Q3zaEBM5SccB6lR49nsCdYF3eIVuQTJtmXCx4F1z+N4aYkJx+9lO zGY0KxwGkFkX7h4rE6sbLIR7FfLz4C+3uYDoGLgB4NfXcfTgwza/sWXMPua8PGZl LQ5MnmmdYeOySj5hWFoaTlMiEZwmsXKZ+6uBLNocD2HcneNQ8Y89Hy3aSTfyfGmI /P7bj08mlMVusoXyo3AkECHC1tYSbXPMqRMXHoWFYiOsr8HLc++lOu91RXc2hkxn xNtAliae7nS87AI6wmgWbmbIpI0bh+TudJV94OzeWR11KfiXmioABuUP1Jd9Q+ZK 5PIFp3Ey5Y+JFcCmMjQAXYl35pwRN1AcWXZuh4HypcBjvXI9r3D5lS/A/9dhkm4/ gxbpF1EY4Oz4mqXLkGCSBOXXj01dwYsTQxzstC99huqLItEjB9zKcH5dOWmrLFYF ReZ3L00l6/rAUng7XgdvG97cCqF3cKbcPEuqN2xyGLELeL6uzi3MpHGoKE5YIkie +DWGl18F38MK61agepeOC7P1EPIpzHu27Z4/z7tC0vspwiCGpfD3Qx8Q+cxkISKv TSnNG6mVN2t1v+Ylq4VVymuaC97OwEaxm0yNJLoqgUbZnuXKGA6A/+lZ+O4fynKi zn58rS/vq+5Bc3bqFrxtltBxE2pmpC3LYLKQfOlksxwofVZxAyc=
    =j89i
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)