Hey,
I've just pushed a new repo to Salsa - libmodule-install-substitute-
perl - this is used by some of the existing Request Tracker extensions
that I'm working on updating to support both RT4 and RT5.
I'm only a DM, it'd be appreciated if someone could please review and
upload. The changelog is still targeting UNRELEASED.
Unfortunately the README file is for the wrong module - I've raised a
bug upstream for that - so don't believe that!
Cheers,
Andrew
Hi Xavier,
First off, thank for taking a look!
On Fri, 2020-11-27 at 12:12 +0100, Xavier wrote:
your package is not ready:
 Can't locate inc/Module/Installinc/Module/Install.pm in @INC (you
may
need to install
 the inc::Module::Install module) (@INC contains: ...) at
Makefile.PL
you should patch it to require Module::Install, not
inc::Module::Install
in Makefile.PL:
 $ git grep inc::Module::Install
 Makefile.PL:use inc::Module::Install;
 [...]
I'm not convinced, when I did that just now I get:
Please invoke Module::Install with:
use inc::Module::Install;
not:
use Module::Install;
None of the other libmodule-install-*-perl packages I sampled do that, however they do have a build-depends on libmodule-install-perl, so I
have added that.
Ahh, and it turned out I was missing some dependencies. Fixed now.
I pushed also some minor changes and enabled continuous integration,
then you'll receive mails for each wrong commit ;-)
Thank you.
I guess this means I'll get an email if my push just now didn't work.
;) And I did, but I was also watching the pipeline. Very handy!
Cheers,
Andrew
your package is not ready:
 Can't locate inc/Module/Installinc/Module/Install.pm in @INC (you
may
need to install
 the inc::Module::Install module) (@INC contains: ...) at
Makefile.PL
you should patch it to require Module::Install, not
inc::Module::Install
in Makefile.PL:
 $ git grep inc::Module::Install
 Makefile.PL:use inc::Module::Install;
 [...]
I pushed also some minor changes and enabled continuous integration,
then you'll receive mails for each wrong commit ;-)
Le 27/11/2020 à 13:22, Andrew Ruthven a écrit :
Hi Xavier,
First off, thank for taking a look!
On Fri, 2020-11-27 at 12:12 +0100, Xavier wrote:
your package is not ready:
 Can't locate inc/Module/Installinc/Module/Install.pm in @INC (you
may
need to install
 the inc::Module::Install module) (@INC contains: ...) at
Makefile.PL
you should patch it to require Module::Install, not
inc::Module::Install
in Makefile.PL:
 $ git grep inc::Module::Install
 Makefile.PL:use inc::Module::Install;
 [...]
I'm not convinced, when I did that just now I get:
Please invoke Module::Install with:
use inc::Module::Install;
not:
use Module::Install;
None of the other libmodule-install-*-perl packages I sampled do that,
however they do have a build-depends on libmodule-install-perl, so I
have added that.
Ahh, and it turned out I was missing some dependencies. Fixed now.
I pushed also some minor changes and enabled continuous integration,
then you'll receive mails for each wrong commit ;-)
Thank you.
I guess this means I'll get an email if my push just now didn't work.
;) And I did, but I was also watching the pipeline. Very handy!
Cheers,
Andrew
OK, it builds fine now. Please:
* mention inc/Module/* in debian/copyright (see https://perl-team.pages.debian.net/copyright.html#Module%3A%3AInstall)
* add missing debian/upstream/metadata
* fix spelling errors in POD docs (in a debian/patches/ file) and
send patch to upstream:
+ substituations => substitutions
+ writen => written
(reported by lintian --info)
@gregoa:
* build & autopkgtest OK
* cme & duck OK
* copyright OK after ^, but I don't find from where come "years"
Cheers,
Xavier
@gregoa:
* build & autopkgtest OK
* cme & duck OK
* copyright OK after ^, but I don't find from where come "years"
OK, it builds fine now. Please:
 * mention inc/Module/* in debian/copyright (see https://perl-team.pages.debian.net/copyright.html#Module%3A%3AInstall
)
 * add missing debian/upstream/metadata
 * fix spelling errors in POD docs (in a debian/patches/ file) and
  send patch to upstream:
  + substituations => substitutions
  + writen        => written
 (reported by lintian --info)
@gregoa:
 * build & autopkgtest OK
 * cme & duck OK
 * copyright OK after ^, but I don't find from where come "years"
Also : "X: perl-module-name-not-mentioned-in-description Module::Install::Substitute"
On Fri, 27 Nov 2020 14:01:01 +0100, Xavier wrote:
@gregoa:
 * build & autopkgtest OK
 * cme & duck OK
 * copyright OK after ^, but I don't find from where come "years"
Not sure why you're asking me where Andrew found copyright years :)
The actual problem I'm seeing is that we don't have any copyright
statement in the whole code. I mean there is section titled
"COPYRIGHT" in the README but it doesn't talk about (a) copyright
holder but about the license.
Well, the Berne Convention to the rescue which allows us to assume
that the author is the copyright holder. Cf. https://perl-team.pages.debian.net/copyright.html#Berne_Convention
So I would write:
Files: *
Copyright: Ruslan Zakirov <ruz@cpan.org>
License: Artistic or GPL-1+
Comment: The upstream distribution does not contain an explicit
statement of
 copyright ownership. Pursuant to the Berne Convention for the
Protection of
 Literary and Artistic Works, it is assumed that all content is
copyright by
 its respective authors unless otherwise stated.
(I tend to put no years there as upstream doesn't tell us anything
about the period, and IMO it's not our job to second-guess them. But
I'm also fine if someone deduces the years from the changelog or
commit dates or whatever.)
Also interesting is that Andrew put his work under GPL-2+. That's of
course fine as a personal preference; we usually pick a superset of $upstream_license and $same_as_perl for debian/* (which is just
$same_as_perl here and in most cases). - One reason why GPL-2+ might
be problematic is that it leads to potential patches under a
different license than what upstream uses …
I've created as much of this as I can. * add missing debian/upstream/metadata
Also, could dh-make-perl generate some of the contents of this file?
Also : "X: perl-module-name-not-mentioned-in-description Module::Install::Substitute"Fixed.
The actual problem I'm seeing is that we don't have any copyright
statement in the whole code. I mean there is section titled
"COPYRIGHT" in the README but it doesn't talk about (a) copyright
holder but about the license.
Well, the Berne Convention to the rescue which allows us to assume
that the author is the copyright holder. Cf. https://perl-team.pages.debian.net/copyright.html#Berne_Convention
Yes, I had made an assumption that the author would hold the copyright,
and that is what dh-make-perl assumes as well as it generated the block
in debian/copyright.
So I would write:Done.
Files: * […]
Perhaps this is something that dh-make-perl can insert in these
circumstances as well?
(I tend to put no years there as upstream doesn't tell us anythingI had looked at the Changes file to determine the copyright years. I am
about the period, and IMO it's not our job to second-guess them. But
I'm also fine if someone deduces the years from the changelog or
commit dates or whatever.)
happy to remove the year ranges if that is preferred.
Also interesting is that Andrew put his work under GPL-2+. That's ofMy default license is GPL-2+. However, I see your point about patches
course fine as a personal preference; we usually pick a superset of $upstream_license and $same_as_perl for debian/* (which is just $same_as_perl here and in most cases). - One reason why GPL-2+ might
be problematic is that it leads to potential patches under a
different license than what upstream uses …
etc, so I have re-licensed it to $same_as_perl. I will make the same
change to some other Perl modules I'm working on as well.
On Sat, 28 Nov 2020 12:42:34 +1300, Andrew Ruthven wrote:
I've created as much of this as I can. * add missing debian/upstream/metadata
Also, could dh-make-perl generate some of the contents of this
file?
It does, but only if upstream provides the data :)
(And basically we use debian/upstream/metadata only for the upstream
Git repo. But looking at the file you created taught me some new keys
I haven't seen before :))
dpt-debian-upstream also creates debian/upstream/metadata (but again
only if the information is in META.{yml,json}). Oh, and lintian-brush
as well (not sure where it looks).
Also : "X: perl-module-name-not-mentioned-in-description Module::Install::Substitute"Fixed.
This lintian tag is more about the long description in
debian/control,
and not about the upstream POD. - Unsurprisingly, lintian still
finds:
X: libmodule-install-substitute-perl: perl-module-name-not-mentioned- in-description Module::Install::Substitute
And then (re your other patch) lintian now also tells us:
P: libmodule-install-substitute-perl source: spelling-error-in-patch- description debian/patches/add-name-to-description.diff grammer
grammar
Perhaps this is something that dh-make-perl can insert in these circumstances as well?
That's a bit hard to do [0] but if you have ideas: you have the
commit
bit for dh-make-perl as well :)
(And basically we use debian/upstream/metadata only for the upstreamFor reference, I used https://wiki.debian.org/UpstreamMetadata as a
Git repo. But looking at the file you created taught me some new keys
I haven't seen before :))
guide for the keys to use.
Sadly I couldn't find a git (or any other VCS) repo for the package. :(
This lintian tag is more about the long description in
debian/control,
and not about the upstream POD. - Unsurprisingly, lintian still
finds:
X: libmodule-install-substitute-perl: perl-module-name-not-mentioned- in-description Module::Install::Substitute
Ah, I misinterpreted that, and I didn't realise I needed to run lintian
with -E to see that warning so I thought I had fixed it.
Fixed.
P: libmodule-install-substitute-perl source: spelling-error-in-patch- description debian/patches/add-name-to-description.diff grammerDoh. Fixed.
grammar
| Sysop: | Keyop |
|---|---|
| Location: | Huddersfield, West Yorkshire, UK |
| Users: | 293 |
| Nodes: | 16 (2 / 14) |
| Uptime: | 242:53:18 |
| Calls: | 6,625 |
| Calls today: | 1 |
| Files: | 12,175 |
| Messages: | 5,320,203 |