• Request for Review / Upload libtest-fitesque-perl

    From Ken Ibbotson@21:1/5 to All on Fri Nov 27 11:10:03 2020
    Not being a DD, I require a current DD to review my work and either:
    - upload the package for me; or
    - provide feedback on the package

    Package: libtest-fitesque-perl
    Origin: remote.origin.url=git@salsa.debian.org: perl-team/modules/packages/libtest-fitesque-perl.git

    Thanks in advance.

    Regards
    --
    Ken Ibbotson
    E: keni@computer.org

    *"Reality is merely an illusion, albeit a very persistent one."*
    - Albert Einstein (1879-1955)

    <div dir="ltr"><div>Not being a DD, I require a current DD to review my work and either:</div><div>- upload the package for me; or</div><div>- provide feedback on the package</div><div><br></div><div>Package: libtest-fitesque-perl</div><div>Origin:
    remote.origin.url=git@salsa.debian.org:perl-team/modules/packages/libtest-fitesque-perl.git<br></div><div><br></div><div>Thanks in advance.</div><div><br></div><div>Regards</div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">
    <div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:keni@computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert
    Einstein (1879-1955)<br></div></div></div></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Ken Ibbotson on Fri Nov 27 21:20:01 2020
    On Fri, 27 Nov 2020 20:31:10 +1030, Ken Ibbotson wrote:

    Package: libtest-fitesque-perl
    Origin: remote.origin.url=git@salsa.debian.org: perl-team/modules/packages/libtest-fitesque-perl.git

    What I found:

    - Standards-Version should be 4.5.1 as we had a new release of the
    Debian Policy in the meantime.
    - You directly changed lib/Test/FITesque.pm to fix the spelling;
    this doesn't work:

    dh_clean
    dpkg-source: info: using source format '3.0 (quilt)'
    dpkg-source: info: building libtest-fitesque-perl using existing ./libtest-fitesque-perl_0.04.orig.tar.gz
    dpkg-source: info: local changes detected, the modified files are:
    libtest-fitesque-perl-0.04/lib/Test/FITesque.pm
    dpkg-source: error: aborting due to unexpected upstream changes, see /home/gregoa/tmp/libtest-fitesque-perl_0.04-1.diff.F2KdgZ
    dpkg-source: info: you can integrate the local changes with dpkg-source --commit

    And dpkg-source's info is a bit misleading; the clean way to do
    this is to create a quilt patch (and revert the direct changes to
    the file). Besides the quilt manpage etc. there's also
    https://perl-team.pages.debian.net/howto/quilt.html

    - After locally reverting 3b9227de2452fd214fb3191dfcf362f8e62a79b9
    (i.e. resetting lib/Test/FITesque.pm), so we get past the
    dpkg-source error, the package doesn't build (in a cowbuilder
    chroot) because the tests fail:

    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/
    local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/01-
    fixture.t line 8.
    BEGIN failed--compilation aborted at t/01-fixture.t line 8.
    # Looks like your test exited with 2 before it could output anything. t/01-fixture.t ....
    1..15
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 15/15 subtests
    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/
    lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/02-test.t line
    7.
    BEGIN failed--compilation aborted at t/02-test.t line 7.
    # Looks like your test exited with 2 before it could output anything. t/02-test.t .......
    1..24
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 24/24 subtests
    Could not load 'Buddha::TestRun' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/
    share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157. BEGIN failed--compilation aborted at t/lib/Buddha/TestRun.pm line 5. Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77. Can't locate Buddha/TestRun in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/
    perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    t/03-test-run.t ...
    1..2
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 2/2 subtests
    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/
    lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/04-suite.t
    line 7.
    BEGIN failed--compilation aborted at t/04-suite.t line 7.
    # Looks like your test exited with 2 before it could output anything. t/04-suite.t ......
    1..14
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 14/14 subtests
    Could not load 'Buddha::SuiteRunTest' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/
    share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157. BEGIN failed--compilation aborted at t/lib/Buddha/SuiteRunTest.pm line 5. Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77. Can't locate Buddha/SuiteRunTest in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/
    share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    t/05-suite-run.t ..
    1..1
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 1/1 subtests
    Could not load 'Buddha::FITesqueFixture' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/
    local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157. BEGIN failed--compilation aborted at t/lib/Buddha/FITesqueFixture.pm line 5. Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77. Can't locate Buddha/FITesqueFixture in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /
    usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    # Looks like your test exited with 2 just after 1.
    t/06-fitesque.t ...
    1..3
    ok 1 - use Test::FITesque;
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 2/3 subtests

    So we need Test::Exception ('libtest-exception-perl <!nocheck>') in
    Build-Depends-Indep, and probably Class::Data::Inheritable
    somewhere - ah yes, that's also in Makefile.PL, so
    'libclass-data-inheritable-perl' in Depends and 'libclass-data-inheritable-perl
    <!nocheck>' in Build-Depends-Indep.

    Catching issues like this is simple when building in a chroot
    (sbuild or pbuilder/cowbuilder) which is more than recommended.

    - Now the package bugs; let's go to autopkgtests; we see a lintian
    warning after building already:
    W: libtest-fitesque-perl source: team/pkg-perl/testsuite/autopkgtest-needs-use-name
    and indeed, autopkgtest-pkg-perl's use.t is skipped:

    autopkgtest [20:58:59]: test autodep8-perl: /usr/share/pkg-perl-autopkgtest/runner runtime-deps
    autopkgtest [20:58:59]: test autodep8-perl: [----------------------- /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t .. skipped: can't guess package from META.json or META.yml
    Files=1, Tests=0, 1 wallclock secs ( 0.03 usr 0.02 sys + 0.12 cusr 0.03 csys = 0.20 CPU)
    Result: NOTESTS
    autopkgtest [20:59:00]: test autodep8-perl: -----------------------] autodep8-perl PASS (superficial)

    So let's try:
    % mkdir -p debian/tests/pkg-perl
    % echo Test::FITesque > debian/tests/pkg-perl/use-name

    and everything works :)
    For the meaning of these files cf.
    https://perl-team.pages.debian.net/autopkgtest.html

    Oh, and a last note: Please don't add a debian/0.04-1 tag. When
    changes have to been (like in this case here), the exisiting tag can
    be a bit annoying (when it's overwritten and others have already
    pulled), that's why the tag is set by the person doing the actual
    upload.


    This looks a bit overwhelming but I'm suer you'll get into it :)
    The package is very untypical; but OTOH you see more exciting things
    than in a standard package where dh-make-perl just gets everything
    right from the beginning …


    As a whish for the future: splitting changes into more and smaller
    commits with more descriptive commit messages would help others to
    understand what you did. (No problem in this case as all changes are
    easy to understand)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Beatles: Fool On The Hill

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl/BXS1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgYWPQ//WvwK1oc44wiV/qqacHcl8bCjRDNVYfAr89zONSvr2mbuUf+9SVHAdn9U 9YxGWA7tds9zRGnYMFauF+SVEqKzOjqn8856AC07xzIWL9SDnU5wIDm7EEw2ub04 5dTJjBnuN3ac0u2QwwyZ7iRNN7yk5kIBpXByEobjFS+yZw7ThTE1bqOpkplorPZt 3M82CUylBzChBFvZDVU+5HaNY2NMEf83mLmeAcSE4aOOCOWkSN/nWAGB9epqYcZK OldLDJnK0YOFmhImqo/zEW5LncJF3KN7D9TvrJW4gLl5BcyE+3YeKv+osNAZhFeC GCmzGwZcDt5s1FWQKoDUNIWS7SPD11TdukdockBxDbYaRiNry3drHaHCM6tGsYvi Xek1miOLabgkgod+1YgIRHCIcs3kaGlTjSvqQxwf4PYJ/xzkJkVqDy8XIWPSay1m ZdSoot6gsRlmfCEq0foBfKDPlxzEDYmQ96pqjK8hBbr+u
  • From Ken Ibbotson@21:1/5 to gregor herrmann on Tue Dec 15 04:50:02 2020
    Been looking into this, and currently in the process of setting up my environment to isolate builds etc. using cowbuilder, but may migrate to
    Docker down the track.

    Will try to complete this ticket ASAP, as it has been too long, then move
    onto the libintl-perl.
    --
    Ken Ibbotson
    E: keni@computer.org

    *"Reality is merely an illusion, albeit a very persistent one."*
    - Albert Einstein (1879-1955)


    On Sat, 28 Nov 2020 at 06:40, gregor herrmann <gregoa@debian.org> wrote:

    On Fri, 27 Nov 2020 20:31:10 +1030, Ken Ibbotson wrote:

    Package: libtest-fitesque-perl
    Origin: remote.origin.url=git@salsa.debian.org: perl-team/modules/packages/libtest-fitesque-perl.git

    What I found:

    - Standards-Version should be 4.5.1 as we had a new release of the
    Debian Policy in the meantime.
    - You directly changed lib/Test/FITesque.pm to fix the spelling;
    this doesn't work:

    dh_clean
    dpkg-source: info: using source format '3.0 (quilt)'
    dpkg-source: info: building libtest-fitesque-perl using existing ./libtest-fitesque-perl_0.04.orig.tar.gz
    dpkg-source: info: local changes detected, the modified files are:
    libtest-fitesque-perl-0.04/lib/Test/FITesque.pm
    dpkg-source: error: aborting due to unexpected upstream changes, see /home/gregoa/tmp/libtest-fitesque-perl_0.04-1.diff.F2KdgZ
    dpkg-source: info: you can integrate the local changes with dpkg-source --commit

    And dpkg-source's info is a bit misleading; the clean way to do
    this is to create a quilt patch (and revert the direct changes to
    the file). Besides the quilt manpage etc. there's also
    https://perl-team.pages.debian.net/howto/quilt.html

    - After locally reverting 3b9227de2452fd214fb3191dfcf362f8e62a79b9
    (i.e. resetting lib/Test/FITesque.pm), so we get past the
    dpkg-source error, the package doesn't build (in a cowbuilder
    chroot) because the tests fail:

    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/01-fixture.t line 8. BEGIN failed--compilation aborted at t/01-fixture.t line 8.
    # Looks like your test exited with 2 before it could output anything. t/01-fixture.t ....
    1..15
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 15/15 subtests
    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains:
    /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/02-test.t line 7.
    BEGIN failed--compilation aborted at t/02-test.t line 7.
    # Looks like your test exited with 2 before it could output anything. t/02-test.t .......
    1..24
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 24/24 subtests
    Could not load 'Buddha::TestRun' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm
    line 7.
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/
    base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157.
    BEGIN failed--compilation aborted at t/lib/Buddha/TestRun.pm line 5. Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line
    77.
    Can't locate Buddha/TestRun in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    t/03-test-run.t ...
    1..2
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 2/2 subtests
    Can't locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains:
    /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/04-suite.t line 7.
    BEGIN failed--compilation aborted at t/04-suite.t line 7.
    # Looks like your test exited with 2 before it could output anything. t/04-suite.t ......
    1..14
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 14/14 subtests
    Could not load 'Buddha::SuiteRunTest' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm
    line 7.
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/
    base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157.
    BEGIN failed--compilation aborted at t/lib/Buddha/SuiteRunTest.pm line 5. Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line
    77.
    Can't locate Buddha/SuiteRunTest in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    t/05-suite-run.t ..
    1..1
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 1/1 subtests
    Could not load 'Buddha::FITesqueFixture' fixture: Base class package "Class::Data::Inheritable" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).
    at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm
    line 7.
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/
    base.pm line 135.
    ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157.
    BEGIN failed--compilation aborted at t/lib/Buddha/FITesqueFixture.pm line
    5.
    Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line
    77.
    Can't locate Buddha/FITesqueFixture in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.
    # Looks like your test exited with 2 just after 1.
    t/06-fitesque.t ...
    1..3
    ok 1 - use Test::FITesque;
    Dubious, test returned 2 (wstat 512, 0x200)
    Failed 2/3 subtests

    So we need Test::Exception ('libtest-exception-perl <!nocheck>') in
    Build-Depends-Indep, and probably Class::Data::Inheritable
    somewhere - ah yes, that's also in Makefile.PL, so
    'libclass-data-inheritable-perl' in Depends and 'libclass-data-inheritable-perl
    <!nocheck>' in Build-Depends-Indep.

    Catching issues like this is simple when building in a chroot
    (sbuild or pbuilder/cowbuilder) which is more than recommended.

    - Now the package bugs; let's go to autopkgtests; we see a lintian
    warning after building already:
    W: libtest-fitesque-perl source: team/pkg-perl/testsuite/autopkgtest-needs-use-name
    and indeed, autopkgtest-pkg-perl's use.t is skipped:

    autopkgtest [20:58:59]: test autodep8-perl: /usr/share/pkg-perl-autopkgtest/runner runtime-deps
    autopkgtest [20:58:59]: test autodep8-perl: [----------------------- /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t .. skipped: can't
    guess package from META.json or META.yml
    Files=1, Tests=0, 1 wallclock secs ( 0.03 usr 0.02 sys + 0.12 cusr
    0.03 csys = 0.20 CPU)
    Result: NOTESTS
    autopkgtest [20:59:00]: test autodep8-perl: -----------------------] autodep8-perl PASS (superficial)

    So let's try:
    % mkdir -p debian/tests/pkg-perl
    % echo Test::FITesque > debian/tests/pkg-perl/use-name

    and everything works :)
    For the meaning of these files cf.
    https://perl-team.pages.debian.net/autopkgtest.html

    Oh, and a last note: Please don't add a debian/0.04-1 tag. When
    changes have to been (like in this case here), the exisiting tag can
    be a bit annoying (when it's overwritten and others have already
    pulled), that's why the tag is set by the person doing the actual
    upload.


    This looks a bit overwhelming but I'm suer you'll get into it :)
    The package is very untypical; but OTOH you see more exciting things
    than in a standard package where dh-make-perl just gets everything
    right from the beginning …


    As a whish for the future: splitting changes into more and smaller
    commits with more descriptive commit messages would help others to
    understand what you did. (No problem in this case as all changes are
    easy to understand)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Beatles: Fool On The Hill


    <div dir="ltr"><div>Been looking into this, and currently in the process of setting up my environment to isolate builds etc. using cowbuilder, but may migrate to Docker down the track.</div><div><br></div><div>Will try to complete this ticket ASAP, as it
    has been too long, then move onto the libintl-perl.<br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:keni@computer.org" target="_blank">keni@
    computer.org</a><br><div><br></div><div><i>&quot;Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class=
    "gmail_attr">On Sat, 28 Nov 2020 at 06:40, gregor herrmann &lt;<a href="mailto:gregoa@debian.org">gregoa@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-
    left:1ex">On Fri, 27 Nov 2020 20:31:10 +1030, Ken Ibbotson wrote:<br>

    &gt; Package: libtest-fitesque-perl<br>
    &gt; Origin: remote.origin.url=<a href="mailto:git@salsa.debian.org" target="_blank">git@salsa.debian.org</a>:<br>
    &gt; perl-team/modules/packages/libtest-fitesque-perl.git<br>

    What I found:<br>

    - Standards-Version should be 4.5.1 as we had a new release of the<br>
      Debian Policy in the meantime.<br>
    - You directly changed lib/Test/FITesque.pm to fix the spelling;<br>
      this doesn&#39;t work:<br>

       dh_clean<br>
    dpkg-source: info: using source format &#39;3.0 (quilt)&#39;<br>
    dpkg-source: info: building libtest-fitesque-perl using existing ./libtest-fitesque-perl_0.04.orig.tar.gz<br>
    dpkg-source: info: local changes detected, the modified files are:<br>  libtest-fitesque-perl-0.04/lib/Test/FITesque.pm<br>
    dpkg-source: error: aborting due to unexpected upstream changes, see /home/gregoa/tmp/libtest-fitesque-perl_0.04-1.diff.F2KdgZ<br>
    dpkg-source: info: you can integrate the local changes with dpkg-source --commit<br>

      And dpkg-source&#39;s info is a bit misleading; the clean way to do<br>
      this is to create a quilt patch (and revert the direct changes to<br>
      the file). Besides the quilt manpage etc. there&#39;s also<br>
      <a href="https://perl-team.pages.debian.net/howto/quilt.html" rel="noreferrer" target="_blank">https://perl-team.pages.debian.net/howto/quilt.html</a><br>

    - After locally reverting 3b9227de2452fd214fb3191dfcf362f8e62a79b9<br>
      (i.e. resetting lib/Test/FITesque.pm), so we get past the<br>
      dpkg-source error, the package doesn&#39;t build (in a cowbuilder<br>
      chroot) because the tests fail:<br>

    Can&#39;t locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /
    usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/01-
    fixture.t line 8.<br>
    BEGIN failed--compilation aborted at t/01-fixture.t line 8.<br>
    # Looks like your test exited with 2 before it could output anything.<br> t/01-fixture.t .... <br>
    1..15<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 15/15 subtests <br>
    Can&#39;t locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/
    local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/02-test.
    t line 7.<br>
    BEGIN failed--compilation aborted at t/02-test.t line 7.<br>
    # Looks like your test exited with 2 before it could output anything.<br> t/02-test.t ....... <br>
    1..24<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 24/24 subtests <br>
    Could not load &#39;Buddha::TestRun&#39; fixture: Base class package &quot;Class::Data::Inheritable&quot; is empty.<br>
        (Perhaps you need to &#39;use&#39; the module which defines that package first,<br>
        or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/
    local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).<br>
     at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 135.<br>
            ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 157.<br>
    BEGIN failed--compilation aborted at t/lib/Buddha/TestRun.pm line 5.<br> Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    Can&#39;t locate Buddha/TestRun in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/
    share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    t/03-test-run.t ... <br>
    1..2<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 2/2 subtests <br>
    Can&#39;t locate Test/Exception.pm in @INC (you may need to install the Test::Exception module) (@INC contains: /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/
    local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at t/04-suite.
    t line 7.<br>
    BEGIN failed--compilation aborted at t/04-suite.t line 7.<br>
    # Looks like your test exited with 2 before it could output anything.<br> t/04-suite.t ...... <br>
    1..14<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 14/14 subtests <br>
    Could not load &#39;Buddha::SuiteRunTest&#39; fixture: Base class package &quot;Class::Data::Inheritable&quot; is empty.<br>
        (Perhaps you need to &#39;use&#39; the module which defines that package first,<br>
        or make that module available in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/
    local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).<br>
     at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 135.<br>
            ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 157.<br>
    BEGIN failed--compilation aborted at t/lib/Buddha/SuiteRunTest.pm line 5.<br> Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    Can&#39;t locate Buddha/SuiteRunTest in @INC (@INC contains: t/lib /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /usr/
    local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    t/05-suite-run.t .. <br>
    1..1<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 1/1 subtests <br>
    Could not load &#39;Buddha::FITesqueFixture&#39; fixture: Base class package &quot;Class::Data::Inheritable&quot; is empty.<br>
        (Perhaps you need to &#39;use&#39; the module which defines that package first,<br>
        or make that module available in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.0 /
    usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl).<br>
     at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    BEGIN failed--compilation aborted at /build/libtest-fitesque-perl-0.04/blib/lib/Test/FITesque/Fixture.pm line 7.<br>
    Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 135.<br>
            ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/<a href="http://base.pm" rel="noreferrer" target="_blank">base.pm</a> line 157.<br>
    BEGIN failed--compilation aborted at t/lib/Buddha/FITesqueFixture.pm line 5.<br>
    Compilation failed in require at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    Can&#39;t locate Buddha/FITesqueFixture in @INC (@INC contains: t/lib t/mock /build/libtest-fitesque-perl-0.04/inc /build/libtest-fitesque-perl-0.04/blib/lib /build/libtest-fitesque-perl-0.04/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.
    0 /usr/local/share/perl/5.32.0 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl/5.32/Module/Load.pm line 77.<br>
    # Looks like your test exited with 2 just after 1.<br>
    t/06-fitesque.t ... <br>
    1..3<br>
    ok 1 - use Test::FITesque;<br>
    Dubious, test returned 2 (wstat 512, 0x200)<br>
    Failed 2/3 subtests <br>

      So we need Test::Exception (&#39;libtest-exception-perl &lt;!nocheck&gt;&#39;) in<br>
      Build-Depends-Indep, and probably Class::Data::Inheritable<br>
      somewhere - ah yes, that&#39;s also in Makefile.PL, so<br>
      &#39;libclass-data-inheritable-perl&#39; in Depends and &#39;libclass-data-inheritable-perl<br>
      &lt;!nocheck&gt;&#39; in Build-Depends-Indep.<br>

      Catching issues like this is simple when building in a chroot<br>
      (sbuild or pbuilder/cowbuilder) which is more than recommended.<br>

    - Now the package bugs; let&#39;s go to autopkgtests; we see a lintian<br>
      warning after building already:<br>
      W: libtest-fitesque-perl source: team/pkg-perl/testsuite/autopkgtest-needs-use-name<br>
      and indeed, autopkgtest-pkg-perl&#39;s use.t is skipped:<br>

    autopkgtest [20:58:59]: test autodep8-perl: /usr/share/pkg-perl-autopkgtest/runner runtime-deps<br>
    autopkgtest [20:58:59]: test autodep8-perl: [-----------------------<br> /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t .. skipped: can&#39;t guess package from META.json or META.yml<br>
    Files=1, Tests=0,  1 wallclock secs ( 0.03 usr  0.02 sys +  0.12 cusr  0.03 csys =  0.20 CPU)<br>
    Result: NOTESTS<br>
    autopkgtest [20:59:00]: test autodep8-perl: -----------------------]<br> autodep8-perl        PASS (superficial)<br>

      So let&#39;s try:<br>
      % mkdir -p debian/tests/pkg-perl<br>
      % echo Test::FITesque &gt; debian/tests/pkg-perl/use-name<br>

      and everything works :)<br>
      For the meaning of these files cf.<br>
      <a href="https://perl-team.pages.debian.net/autopkgtest.html" rel="noreferrer" target="_blank">https://perl-team.pages.debian.net/autopkgtest.html</a><br>

    Oh, and a last note: Please don&#39;t add a debian/0.04-1 tag. When<br>
    changes have to been (like in this case here), the exisiting tag can<br>
    be a bit annoying (when it&#39;s overwritten and others have already<br> pulled), that&#39;s why the tag is set by the person doing the actual<br> upload.<br>


    This looks a bit overwhelming but I&#39;m suer you&#39;ll get into it :)<br> The package is very untypical; but OTOH you see more exciting things<br>
    than in a standard package where dh-make-perl just gets everything<br>
    right from the beginning …<br>


    As a whish for the future: splitting changes into more and smaller<br>
    commits with more descriptive commit messages would help others to<br> understand what you did. (No problem in this case as all changes are<br>
    easy to understand)<br>


    Cheers,<br>
    gregor<br>

    -- <br>
     .&#39;&#39;`.  <a href="https://info.comodo.priv.at" rel="noreferrer" target="_blank">https://info.comodo.priv.at</a> -- Debian Developer <a href="https://www.debian.org" rel="noreferrer" target="_blank">https://www.debian.org</a><br>
     : :&#39; : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06<br>
     `. `&#39;  Member VIBE!AT &amp; SPI Inc. -- Supporter Free Software Foundation Europe<br>
       `-   NP: Beatles: Fool On The Hill<br>
    </blockquote></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ken Ibbotson@21:1/5 to All on Thu Dec 31 06:10:01 2020
    dpt checkout libtest-fitesque-perl

    This package has certainly been an education, and I believe after much
    advice (many thanks), reading and amending I believe it is ready for review
    / upload.

    I have taken the comments of others and applied each.

    I apologise for my naivety and ergo mistakenly adding the debian/0.04-1 tag.

    The packages is being built under cowbuilder using:
    time DIST=sid ARCH=amd64 gbp buildpackage --git-pbuilder --git-verbose
    and the build was performed against: stable (buster), testing (bullseye),
    and unstable (sid), with all being successful via auto testing.

    I run Ubuntu at home, and as a result it was a further challenge to get the environment right.

    Lintain has been run using:
    lintian -iEvIL +pedantic --profile debian ../libtest-fitesque-perl_0.04-1_amd64.changes

    Advance apologies if I have missed anything.

    Regards
    --
    Ken Ibbotson
    E: keni@computer.org

    *"Reality is merely an illusion, albeit a very persistent one."*
    - Albert Einstein (1879-1955)

    <div dir="ltr"><div dir="ltr">dpt checkout libtest-fitesque-perl</div><div dir="ltr"><br></div><div>This package has certainly been an education, and I believe after much advice (many thanks), reading and amending I believe it is ready for review /
    upload.</div><div><br></div><div>I have taken the comments of others and applied each.</div><div><br></div><div>I apologise for my naivety and ergo mistakenly adding the debian/0.04-1 tag.</div><div><br></div><div>The packages is being built under
    cowbuilder using:</div><div style="margin-left:40px"><span style="font-family:monospace">time DIST=sid ARCH=amd64 gbp buildpackage --git-pbuilder --git-verbose</span></div><div>and the build was performed against: stable (buster), testing (bullseye), and
    unstable (sid), with all being successful via auto testing.</div><div><br></div><div>I run Ubuntu at home, and as a result it was a further challenge to get the environment right.</div><div><br></div><div>Lintain has been run using:</div><div style="
    margin-left:40px"><span style="font-family:monospace">lintian -iEvIL +pedantic --profile debian ../libtest-fitesque-perl_0.04-1_amd64.changes</span></div><div><br></div><div>Advance apologies if I have missed anything.</div><div><br></div><div>Regards<br>
    </div><div dir="ltr"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:keni@computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;
    Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div></div><br></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Ken Ibbotson on Fri Jan 1 01:10:01 2021
    On Thu, 31 Dec 2020 15:38:56 +1030, Ken Ibbotson wrote:

    This package has certainly been an education, and I believe after much
    advice (many thanks), reading and amending I believe it is ready for review
    / upload.

    I took another look, and indeed it's ready for upload.
    Congratulations!

    I've made one small change (unapplied the patch as applied patches
    can cause grievance later, during work on the package or when
    importing new upstream versions), and I've deleted the old tag and
    pushed a new one. Oh, and I uploaded it to the NEW queue.

    I apologise for my naivety and ergo mistakenly adding the debian/0.04-1 tag.

    No worries.

    The packages is being built under cowbuilder using:

    Cool.
    And it looks like you've seen almost everything related to packaging
    perl modules on your way :)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Arlo Guthrie: Can't Help Falling in Love

    -----BEGIN PGP SIGNATURE-----

    iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl/uZpNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgYSjw//Rww7l+hR1nBLj3tqUOES/h/KCBmeuaKZTK5OEm+x6xDfey56Oq7Ryc5f LKncxTdXcrQ6ckP0T6IY+sW4L4GY7VQIX+Q5WcxghWcprQeO9tdP82uSF2X4eTjn WBBSy2jFKMtJD8Suvo/oUMzaFhaqS8ya1T1sjpfa6a5lu9NSAc+l7U52YRhHASi2 vvrMCOFHuGxT256W6+QZRTAUiBHIK9CXSRKFGnKzC3wwE63PWl6t+2sTl2f7qU9C JRRHYDDCesXvqp6vJiJwQW/WhsSfrUfrhOTA1hr5E/WlhjZr8/MFavwjqz0SRMiw RmuZng9jFGZnOZvsgH2FEXxr3VOTvGcQ32Q18ixd5Xtw8lW3Zc3px5Pv8UlNUBa4 J+4mMQC3yOWwEFcqnbLIYV/LbDzxEIzq4TZ7DCvlyZwyuWULD6zcoujv1lETm5xR 7mBgnPgM4Wohhq05hQZonBogEhzgXQP1D07i06VQFAoTTyauoe9Z/zH7r306d89k gqdZS59KmB+hBNZboGLI6nSMH8QRLuuDcpebdiKtO2TQq/Jz/ZXYrTdUvK35fsY+ wnaZ0oFUxb71qNXxIrK568nhHNJDpNh8YiLuLoIagpqDNeMUuSpcY93eWJx+/AkJ +9LM7mX+jR43cGQ3ygVxItxNcN8px2UYox3Eb0U1Cd7lA0qwPDo=
    =znsw
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ken Ibbotson@21:1/5 to gregor herrmann on Fri Jan 1 03:20:01 2021
    Many thanks Gregor,

    It certainly was a tough nut to crack.

    So now I know:
    - not to tag as will be done by the reviewer at upload
    - unapply patches before commit and review request

    Still waiting for my PAUSE account, so patch is pending `forward` step at present.

    I wonder if `Test::FITesque-RDF` (libtest-fitesque-rdf-perl) will be
    simpler.

    Ciao
    --
    Ken Ibbotson
    E: keni@computer.org

    *"Reality is merely an illusion, albeit a very persistent one."*
    - Albert Einstein (1879-1955)


    On Fri, 1 Jan 2021 at 10:32, gregor herrmann <gregoa@debian.org> wrote:

    On Thu, 31 Dec 2020 15:38:56 +1030, Ken Ibbotson wrote:

    This package has certainly been an education, and I believe after much advice (many thanks), reading and amending I believe it is ready for
    review
    / upload.

    I took another look, and indeed it's ready for upload.
    Congratulations!

    I've made one small change (unapplied the patch as applied patches
    can cause grievance later, during work on the package or when
    importing new upstream versions), and I've deleted the old tag and
    pushed a new one. Oh, and I uploaded it to the NEW queue.

    I apologise for my naivety and ergo mistakenly adding the debian/0.04-1
    tag.

    No worries.

    The packages is being built under cowbuilder using:

    Cool.
    And it looks like you've seen almost everything related to packaging
    perl modules on your way :)


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- NP: Arlo Guthrie: Can't Help Falling in Love


    <div dir="ltr"><div>Many thanks Gregor,</div><div><br></div><div>It certainly was a tough nut to crack.</div><div><br></div><div>So now I know:</div><div>- not to tag as will be done by the reviewer at upload</div><div>- unapply patches before commit and
    review request<br></div><div><br></div><div>Still waiting for my PAUSE account, so patch is pending `forward` step at present.</div><div><br></div><div>I wonder if `Test::FITesque-RDF` (libtest-fitesque-rdf-perl) will be simpler.</div><div><br></div><div>
    Ciao<br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>--<br>Ken Ibbotson</div>E: <a href="mailto:keni@computer.org" target="_blank">keni@computer.org</a><br><div><br></div><div><i>&quot;
    Reality is merely an illusion, albeit a very persistent one.&quot;</i></div>    - Albert Einstein (1879-1955)<br></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 1 Jan 2021 at 10:32, gregor
    herrmann &lt;<a href="mailto:gregoa@debian.org">gregoa@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 31 Dec 2020 15:38:56 +1030, Ken
    Ibbotson wrote:<br>

    &gt; This package has certainly been an education, and I believe after much<br> &gt; advice (many thanks), reading and amending I believe it is ready for review<br>
    &gt; / upload.<br>

    I took another look, and indeed it&#39;s ready for upload.<br> Congratulations!<br>

    I&#39;ve made one small change (unapplied the patch as applied patches<br>
    can cause grievance later, during work on the package or when<br>
    importing new upstream versions), and I&#39;ve deleted the old tag and<br> pushed a new one. Oh, and I uploaded it to the NEW queue.<br>

    &gt; I apologise for my naivety and ergo mistakenly adding the debian/0.04-1 tag.<br>

    No worries.<br>

    &gt; The packages is being built under cowbuilder using:<br>

    Cool.<br>
    And it looks like you&#39;ve seen almost everything related to packaging<br> perl modules on your way :)<br>


    Cheers,<br>
    gregor<br>

    -- <br>
     .&#39;&#39;`.  <a href="https://info.comodo.priv.at" rel="noreferrer" target="_blank">https://info.comodo.priv.at</a> -- Debian Developer <a href="https://www.debian.org" rel="noreferrer" target="_blank">https://www.debian.org</a><br>
     : :&#39; : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06<br>
     `. `&#39;  Member VIBE!AT &amp; SPI Inc. -- Supporter Free Software Foundation Europe<br>
       `-   NP: Arlo Guthrie: Can&#39;t Help Falling in Love<br> </blockquote></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)