1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.PYTHON

  • review for python-ssdpy

    From Jeroen Ploemen@21:1/5 to All on Mon Oct 3 14:20:01 2022
    Hi Ben,

    * control: missing build-dep on python3-all? Needed to run the
    testsuite against all supported Python version rather than just the
    default one.

    * watch: regex "(\d\.\d.\d)" is overly specific, could easily miss
    upstream versions such as a hypothetical "1.5" or "1.4.10".

    Package ftbfs in pbuilder with errors in the testsuite; many of the
    failing tests are marked by upstream as incompatible with github ci,
    probably for similar reasons they fail in pbuilder, particularly
    assumptions regarding the availability and configuration of the
    network.

    See log at https://paste.debian.net/hidden/daadfbea/

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmM60cAACgkQQoMEoXSN zHrvmg/+OJUfO9SNl221Ybe6ORGCn+Ol/120V+Xuqckg9SEn6/LTRh//4hiLbRB+ SOvCWq7oyZBpQnbXNZ58FwOwpeww3STiSM8aIOLHyvIx+nZXF30/ESmrMDG+lqCP rtBznurPF8nbvv5fFNCqCdyuScz3sh0/hTG8caMnE5TTu0Fn+P0vHzQPSZkGGbTs oGXkiGQOeKvU4uyO3dCxnOe4IRmoZeSMUudQfaE8w3Jz1TYNQtpltiNRWH2FpmL2 d0DERNrWhK3KHTKqYY3HsLBefiM4T/rlZ21Mg3wWI8GrkOKKCfM0uZXXLWnZYxtW P2n/YT7BbEhZNDPj5zBpY2iBCodL+4NzPprSU8fUmj3vhR5j3Yu/M0+rm8f4ql19 sqA8BFjN921wHLgT3MX/NFe6YZruzK5Cu6RGRRkFdJ/XNMeOJltWpt0YeEIpZUiw f3Wimoj5GCqJ/HNHVJhkizxzQRiBCitRGhQ7AHYijg0yX2nVQlVwtq9T194bVtzw iHPCEn/TGY/2wqq4VDMNwpQWJPRwi/PqKAZgS0uCUQd2t4xEitEXI0OyGCNwwOj0 Y3WomKTTPKkZjKz6CvLCOMeXTcKPuLn/bARFrDXAl9IaVBLzNZgNgwYpn/c9HURy 5GAlymbm2htBSmYszBQF2BAQKHkwUpMgEKtg67AkKsYMKmXRpYQ=
    =Md6t
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ben Westover@21:1/5 to Jeroen Ploemen on Mon Oct 3 18:00:02 2022
    Copy: debian-python@lists.debian.org

    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0Zm9y9wvX0LyaWXx7IHPRr6E
    Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64

    SGVsbG8sDQoNCk9uIDEwLzMvMjIgMDg6MTIsIEplcm9lbiBQbG9lbWVuIHdyb3RlOg0KPiAq IGNvbnRyb2w6IG1pc3NpbmcgYnVpbGQtZGVwIG9uIHB5dGhvbjMtYWxsPyBOZWVkZWQgdG8g cnVuIHRoZQ0KPiAgICB0ZXN0c3VpdGUgYWdhaW5zdCBhbGwgc3VwcG9ydGVkIFB5dGhvbiB2 ZXJzaW9uIHJhdGhlciB0aGFuIGp1c3QgdGhlDQo+ICAgIGRlZmF1bHQgb25lLg0KDQpUaGFu a3MsIGFkZGVkLg0KDQo+ICogd2F0Y2g6IHJlZ2V4ICIoXGRcLlxkLlxkKSIgaXMgb3Zlcmx5 IHNwZWNpZmljLCBjb3VsZCBlYXNpbHkgbWlzcw0KPiAgICB1cHN0cmVhbSB2ZXJzaW9ucyBz dWNoIGFzIGEgaHlwb3RoZXRpY2FsICIxLjUiIG9yICIxLjQuMTAiLg0KDQpGaXhlZC4NCg0K PiBQYWNrYWdlIGZ0YmZzIGluIHBidWlsZGVyIHdpdGggZXJyb3JzIGluIHRoZSB0ZXN0c3Vp dGU7IG1hbnkgb2YgdGhlDQo+IGZhaWxpbmcgdGVzdHMgYXJlIG1hcmtlZCBieSB1cHN0cmVh bSBhcyBpbmNvbXBhdGlibGUgd2l0aCBnaXRodWIgY2ksDQo+IHByb2JhYmx5IGZvciBzaW1p bGFyIHJlYXNvbnMgdGhleSBmYWlsIGluIHBidWlsZGVyLCBwYXJ0aWN1bGFybHkNCj4gYXNz dW1wdGlvbnMgcmVnYXJkaW5nIHRoZSBhdmFpbGFiaWxpdHkgYW5kIGNvbmZpZ3VyYXRpb24g b2YgdGhlDQo+IG5ldHdvcmsuDQo+IA0KPiBTZWUgbG9nIGF0IGh0dHBzOi8vcGFzdGUuZGVi aWFuLm5ldC9oaWRkZW4vZGFhZGZiZWEvDQoNClRoYW5rcywgSSBkaWRuJ3QgY2F0Y2ggdGhh dCBzaW5jZSBJIHVzZSBzYnVpbGQgaW5zdGVhZCBvZiBwYnVpbGRlci4gSSANCmhhdmUgc2V0 IHRoZSBlbnZpcm9ubWVudCB2YXJpYWJsZSBDSSA9IHRydWUgd2hpY2ggc2hvdWxkIGRpc2Fi bGUgdGhvc2UgDQp0ZXN0cy4gVGhpcyBhbmQgYWJvdmUgZml4ZXMgYXJlIHB1c2hlZCB0byBT YWxzYS4NCg0KLS0NCkJlbiBXZXN0b3Zlcg0K

    --------------0Zm9y9wvX0LyaWXx7IHPRr6E--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEEOGnacqRhdU6eNmtFwxHF9U6JtpgFAmM7Bi4FAwAAAAAACgkQwxHF9U6JtpgV mxAAgXS2VKNB7IMYDmqvHqjJkTlOq5dCZO1Y+wCU1WALA5FtkJyDJ3OC51c75Wa409GZ+Jw9D/Va wgyMxIBq1E6TgOy1E8AdMvgFNFC8vj7irgUgM/ZJ04ptL6pE09EQKTUU/bokq96XqyToXubDma0Z f60M28u97GumZ2mq4Dzw44AtX94aIp5N1vhEZ8GVu9WZ97rLlB/o3ccI3Ipl7V69s8icvpC/eASO 1WC4obpM7ytb3nMYbp6m1FW12LM2MJE42o0qctzcshDcIMRU6fUfqVwLj/AO8L6pCw8pFT98d8br mIgDzPG2KsxTA0Jv7/kuQz2rbcqkwDEg0vi8RAwv5DYs7lfcgy5yoL+rO2yRRpCAYZy3zdNVIXPe YElEfzRvsPukPKRsbLEiIuf/DsvPHxbKAJICMWIGoWho26gwzUcSbHCiFdxy8EyZjV2FhoyFZXPx +acmKIeFvsBUkBbfOG8+zODeEFW10hLs/GKpEy654L8Xrnmw7+Eps0x2NbZsZYuaLmlaVYhUqQTO haX/Ao0+wKwX4sz60TSWyWXGepsM1ZnwPI2t5BEa4QoPkEPiakuoHiEGgBuWWANCPUWZ7wiKuyI8 leIFHJwmYMx3YMp3djwW2RSurTxnusHoZh1mtWFJKjjO4Gok5EG/tJn8DxAr66Y2aRN74lrVlCw0 rZI=
    =WBaG
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jeroen Ploemen@21:1/5 to Ben Westover on Tue Oct 4 15:00:01 2022
    On Mon, 3 Oct 2022 11:56:30 -0400
    Ben Westover <kwestover.kw@gmail.com> wrote:

    Thanks, I didn't catch that since I use sbuild instead of pbuilder.
    I have set the environment variable CI = true which should disable
    those tests.

    Unfortunately, it doesn't.

    The change suggested below does make 'CI=true' take effect, but that
    still leaves a few failing tests not marked by upstream. Probably
    easiest to exclude those remaining troublemakers by instructing
    pybuild to set a pytest option, e.g. PYBUILD_TEST_ARGS = -k 'not ...'.

    --- a/debian/rules
    +++ b/debian/rules
    @@ -1,7 +1,6 @@
    #! /usr/bin/make -f

    export PYBUILD_NAME = ssdpy
    -export CI = "true" # Skip tests which require network

    %:
    dh $@ --with python3,sphinxdoc --buildsystem=pybuild
    @@ -11,3 +10,7 @@ execute_after_dh_auto_build:

    execute_after_dh_auto_clean:
    rm -rf debian/html
    +
    +override_dh_auto_test:
    + # Skip tests which require network
    + CI=true dh_auto_test

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmM8LAoACgkQQoMEoXSN zHrt7A/+I0St9d3h6qntrQ/RUiAvoIlk9KIjfKjL8R9uP0gs8jByyRpWI5/u9f1J 8qufgjuRVGGoWgFbeLTcfA0Irz2nWrt5kJphIDBfCpkN8Fs6NjAg0fxZheH/BkA9 1MK2cqR2brz66LxZnD5Kht8k+r5n4bO77FXu6lHGorNI9gpRrDaytwl0Wu4AFB/X R6TyJo+g3rLHlsRCzmmgQlZab+6V07JYdxSlMQz9EgmoYi2dbjEWVdOxvGlDH3Gs PyU4jn9YONgCofprre9mZwUGKy9ZI7dRydU7EEIieNG3wC8IpSdnOylapdXehlTN JFcAw3FqL5R2cTk/E/FpTpPPmJ8F+7dvocg2N8HbmVtsc7+u0saat+Ia/IAXIRdm gx1/RwloWPrSmGsaoxN7Ox24Sn1qSkxhiJH6LA7RJgItT7MuKYp7BuoN4ltDmU3l
    2wgjtLgDZdS
  • From Ben Westover@21:1/5 to Jeroen Ploemen on Tue Oct 4 18:50:01 2022
    Copy: debian-python@lists.debian.org

    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0NOaGVPwUpilys0pDeDhWDk6
    Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64

    T24gMTAvNC8yMiA4OjUwIEFNLCBKZXJvZW4gUGxvZW1lbiB3cm90ZToNCj4+IFRoYW5rcywg SSBkaWRuJ3QgY2F0Y2ggdGhhdCBzaW5jZSBJIHVzZSBzYnVpbGQgaW5zdGVhZCBvZiBwYnVp bGRlci4NCj4+IEkgaGF2ZSBzZXQgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIENJID0gdHJ1 ZSB3aGljaCBzaG91bGQgZGlzYWJsZQ0KPj4gdGhvc2UgdGVzdHMuDQo+IA0KPiBVbmZvcnR1 bmF0ZWx5LCBpdCBkb2Vzbid0Lg0KPiANCj4gVGhlIGNoYW5nZSBzdWdnZXN0ZWQgYmVsb3cg ZG9lcyBtYWtlICdDST10cnVlJyB0YWtlIGVmZmVjdCwgYnV0IHRoYXQNCj4gc3RpbGwgbGVh dmVzIGEgZmV3IGZhaWxpbmcgdGVzdHMgbm90IG1hcmtlZCBieSB1cHN0cmVhbS4gUHJvYmFi bHkNCj4gZWFzaWVzdCB0byBleGNsdWRlIHRob3NlIHJlbWFpbmluZyB0cm91YmxlbWFrZXJz IGJ5IGluc3RydWN0aW5nDQo+IHB5YnVpbGQgdG8gc2V0IGEgcHl0ZXN0IG9wdGlvbiwgZS5n LiBQWUJVSUxEX1RFU1RfQVJHUyA9IC1rICdub3QgLi4uJy4NCg0KSSB3YXMgZ29pbmcgdG8s IGJ1dCBpdCBsb29rcyBsaWtlIHByYWN0aWNhbGx5IGFsbCBvZiB0aGUgdGVzdHMgcmVxdWly ZSANCm5ldHdvcmsgaW4gc29tZSBmb3JtLCBzbyBJJ3ZlIGp1c3QgZGlzYWJsZWQgdGVzdHMg YWx0b2dldGhlci4NCg0KVGhhbmtzLA0KLS0NCkJlbiBXZXN0b3Zlcg0K

    --------------0NOaGVPwUpilys0pDeDhWDk6--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEEOGnacqRhdU6eNmtFwxHF9U6JtpgFAmM8YmAFAwAAAAAACgkQwxHF9U6Jtphh LxAAj2OZMrOErEy/RX8ZkfpT9KvIxRJfRxbbN8X29OemUfH8JK4QFM5gwYZLI0CXNkWCJecAhf9y EIh5kKzwYuDKkd7GKtvJx5KikG4UEfRaqklKJ9iIP2lMf0L2YFJHFzKEGY/ga6IG+K1AHVX6Eo9f iPHoaq39lpwM67uBmjrbKdQZHDQu4vxnJk7BHZKIAuaE3TXCa/tOPQ0UvMp+xogDL98JBKmY1TRX 8EBdrHxK607g9KyjaAxEmXqBioWPu7XJkXkhpMr8j3Top3CQXKdfJg/exQU997+RTCQT779T4pzV 5e8RENc6LCoFyCIQpoxrb/s3B4gUvjqpFciExOdKUgdibk92GQ3obyCn1MnfizCrU6+uAicgHehy EoSptoiISGKnXepCe7Rp/Fi0FZNfYG6A9CYpMDGv2vGGjw5USFR2/mfPAr2XMNqQDtb0ArhouEfM Q4JMOVSc1MO/hrTtoVNCjpblJEPvkP0/K+kpCW83fMq8heMyAXbr2OFvBA6tedhaFB8owTIbk3K1 EvMoKYSBiALS+rnIYcIN3XVHPGA+eGhvtOigFSuHrVcuo68XgvdkEZUgLfG7zq2W1aY2M2MSY6Pb wMEukkyAbjAkMOQGdPdXTvA0aX4vAJKTghSmqIK9mMkCHejJ0c72xUaESKK1E+lqMJMWa3P/ObTF cgg=
    =/v0m
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)