On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
dh_auto_install
mv debian/git-multimail/usr/bin/git_multimail.py debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

That resulted in two copies of that sizeable file in the package I
reviewed back in June. Hence my suggestion - quoted in an earlier
message by Bo - to replace the copy in /usr/bin with a tiny launcher,
reducing the installed size of the package by almost half.

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmMsnr0ACgkQQoMEoXSN zHpZZBAAi7qte5IznijgM9szsU4DcTmpzn9PRLaGnKjd71iW67jzwJhYUotJAWn4 QnEfD857kR2+qzQHHSMgn/s3sKHyx8U+j/lEwg8CtLSfeGxW5uFoQc+e0A3NUAmA ozWJU916SRKuPGTbiN3jf5SQ7jy85YzYQLa0+KulpCKQHmEKGxVM3pyjWjo3ZP8t XlZJDlv09L/zxxx82sh6GT1ycyC/S8Px9gN/7PUCBaLW5WbbXxJHENLebfZeTko4 a4MmBeDWflCoRnricBTNPW5c1yNdh5PzDiPTpsmLSm9FduPNaO0wVvodH9uNYDik /7BDkI7z/FYEah9nZj4+gz+ulNag2E+8S6ERto0uyS0tYYvetgurmnZ5YGIPasel hioeY83TIXhZGSIpegLFg9Yn7KXxs+WudsYgs1ESuP34LzYtqsLZc5Z0qHiWkZOg DcSzVWe9LgksFCVBaY+UU7BICd2+dlHXiIdHOuQp4ne9Rg8i7ptR2uqB1l9Q05Vb CZg+ZisXfQQSuJyC5LIvG7PEuPAYMkQgaERZZp7jQb0tOWa9BsdeTIQBHgfNiW0d b74QNoVfmbQSZChGYe3/5GE/K0AkGCvmUhpnIenpVM79DUGdcSEgg0dgjVWExgiB gzTutEmJux//ANkwYXUH+1SHoEZbHAO7uoeqi1Uho12Cx2/zmQ0=
=H6iS
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On 2022-09-22 19:43:24, Jeroen Ploemen wrote:

On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
dh_auto_install
mv debian/git-multimail/usr/bin/git_multimail.py
debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

Oh. I misunderstood that, sorry.

That resulted in two copies of that sizeable file in the package I
reviewed back in June. Hence my suggestion - quoted in an earlier
message by Bo - to replace the copy in /usr/bin with a tiny launcher, reducing the installed size of the package by almost half.

Sure, that completely makes sense then, sorry.

a.

--
À force de ne jamais réfléchir, on a un bonheur stupide
- Jean Cocteau

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi,
On Thu, Sep 22, 2022 at 02:12:07PM -0400, Antoine Beaupré wrote:

On 2022-09-22 19:43:24, Jeroen Ploemen wrote:

On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
dh_auto_install
mv debian/git-multimail/usr/bin/git_multimail.py
debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

Oh. I misunderstood that, sorry.

Sorry, maybe my words misled you also here.

That resulted in two copies of that sizeable file in the package I
reviewed back in June. Hence my suggestion - quoted in an earlier
message by Bo - to replace the copy in /usr/bin with a tiny launcher,
reducing the installed size of the package by almost half.

Sure, that completely makes sense then, sorry.

Ok, I have re-enabled the launcher and other issues fixed for git-multimail
as your and jcfp's suggestions.

Thanks all and please let me know if any issues.

--
Regards,
--
Bo YU


-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmMusvMACgkQ+RVP3hQ+ S69oRxAAgUzkemDaVZq5k3S5yqY75466xuz6OXc0+TTlDpVDhrSw/bNBKjjjO/lU SFlsmfYVUAPOOKeYm1bsq4SvVhmXkhb7S3nh9S98WM2KT0vDq2XdaOaJdjvjhSHI wiDbnyXIz6rlGNKXqka4SsvYeqjNBfjxSeF+qYUpcMuV/g7OAu4eO1Il9di4IOkc oimg+OeyZ7022eI+VLwhMKoTb9qhqJeR3DjqMfLnlhStmSGkV+ScMgCrv3awv8i3 VK3ipyeCqc9XK4GCmRxKGOiguniGEm5nIZxw9AKWf8jcFFnq+eCJ5oFWggumrudB u9+BOWkDscRH/wM+lD23OfI4vh1g/+ZLc1KxgQSeVQWhn9yKc8qkzNmM9yNPYt3a ALPK8G75LHG1qRpuYK5GtET3QdCxyQQYy8zt0WkKsxcwpLJGKRNaT6RxXnqmWzDC PLW339JkGulD6r/9vYVoV+kT0HryceZZtSiJ+5vqxSiqErgXpci6TaT8NL++rUQz 6vSlQhUu0xzTVNjS/PEMZFZ0oWtSiBrPBSvoE6z7yTdgCE4Y5QuFm2nlp3UrRUQ5 8k5JmCVNXzB4bzI2YBBG9s006xIcttzZXXE5WniEo9uYkrRq2FGE3iehIXaH2eE/ 4H9ug/irDIKfOVG4nPsSIeKPib7pA6KuvF/BiO2yqIfQzsyPeig=
=iKL9
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi

On Sat, Sep 24, 2022 at 3:34 PM Bo YU <tsu.yubo@gmail.com> wrote:

Hi,
On Thu, Sep 22, 2022 at 02:12:07PM -0400, Antoine Beaupré wrote:

On 2022-09-22 19:43:24, Jeroen Ploemen wrote:

On Thu, 22 Sep 2022 12:35:12 -0400
Antoine Beaupré <anarcat@debian.org> wrote:

I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:

override_dh_auto_install:
dh_auto_install
mv debian/git-multimail/usr/bin/git_multimail.py
debian/git-multimail/usr/bin/git-multimail

Antoine, IIRC the git_multimail.py file upstream installs into
/usr/bin is not a launcher but a full copy of the module as installed
into /usr/lib/python3. The code in that file auto-detects whether
it's run as a program.

Oh. I misunderstood that, sorry.

[...]

Thanks all and please let me know if any issues.

I have sent the PR and whcih was merged: https://github.com/git-multimail/git-multimail/pull/224

The latest version git-multimail debian package is here: https://mentors.debian.net/package/git-multimail/

Thanks again.:)

--
Regards,
--
Bo YU

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)