Hello all,
the question is essentially all in the subject line, and my answer is yes.
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.
Regards,
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
On 2022-02-17 12 h 39, Sandro Tosi wrote:
Hello all,yes.
the question is essentially all in the subject line, and my answer is
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.
Regards,
You sent a mail on the list on 2020-07-27 about this and the general consensus (3-4 replies) was that it was a good idea.
Anyway, I also vote yes!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
⠈⠳⣄
I admit I'm hesitating a bit for different reasons. While I agree that
direct commits are better than MRs I found several DPT packages with
very sensible changes in Git but no uploads following these. For
instance fixing VCS fields and Maintainer name should be followed by an
according upload to make those changes visible to users and developers
of the *packages* in Debian.
In the Debian Med team for instance we do those automatic changes before
uploading a package - say when upgrading to new upstream versions or
fixing some bugs. Than we run the Janitor scripts and other automatic
changes which is all done in routine-update. I personally find this
workflow more convenient. That way Debian Med team (as well as pkg-r
team) are blacklisted for Janitor to not have competing changes inside
the package.
thanks for bringing the perspective of how things are done in the Med
team, but it feels none of the points you mentioned nor the specific
Med team workflow apply here,
or are relevant to just let Janitor
commit directly to our packages.
I admit I'm hesitating a bit for different reasons. While I agree that direct commits are better than MRs I found several DPT packages with
very sensible changes in Git but no uploads following these. For
instance fixing VCS fields and Maintainer name should be followed by an according upload to make those changes visible to users and developers
of the *packages* in Debian.
In the Debian Med team for instance we do those automatic changes before uploading a package - say when upgrading to new upstream versions or
fixing some bugs. Than we run the Janitor scripts and other automatic changes which is all done in routine-update. I personally find this
workflow more convenient. That way Debian Med team (as well as pkg-r
team) are blacklisted for Janitor to not have competing changes inside
the package.
On 2/18/22 2:23 AM, Sandro Tosi wrote:
thanks for bringing the perspective of how things are done in the Med
team, but it feels none of the points you mentioned nor the specific
Med team workflow apply here,
I suppose the highlight was the usage of routine-update[1] package before upload
and we could use it with DPT too.
This does similar(same?) changes as in janitor.
But that said, I agree with what you wrote:
or are relevant to just let Janitor
commit directly to our packages.
I vote a in for/OK for janitor to commit directly as well.
[1]: https://tracker.debian.org/pkg/routine-update
Hello all,
the question is essentially all in the subject line, and my answer is yes.
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.
Regards,
--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi
Piotr, Stefano, Bernd, Scott, Ondrey,
as owners of the DPT salsa team ( https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
can you approve (or deny) this request, and so give access to Janitor to directly commit to all our repos, instead of filing MRs?
thanks!
On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:
Hello all,
the question is essentially all in the subject line, and my answer is yes.
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.
Regards,
--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi
--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi
Hi Sandro (2022.03.29_21:46:29_+0000)
Seeing Jelmer reminded me about this thread.
I have no objection, so count this as an approval.
I thought Janitor was already doing this, though...
SR
Piotr, Stefano, Bernd, Scott, Ondrey,
as owners of the DPT salsa team ( https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
can you approve (or deny) this request, and so give access to Janitor to directly commit to all our repos, instead of filing MRs?
thanks!
On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:
Hello all,
the question is essentially all in the subject line, and my answer is yes.
I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.
Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.
Regards,
--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi
--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi
--
Stefano Rivera
http://tumbleweed.org.za/
+1 415 683 3272
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 350 |
Nodes: | 16 (2 / 14) |
Uptime: | 09:31:12 |
Calls: | 7,625 |
Files: | 12,793 |
Messages: | 5,686,482 |