• Should we allow Janitor to commit directly to all DPT packages?

    From Sandro Tosi@21:1/5 to All on Thu Feb 17 18:50:01 2022
    Hello all,
    the question is essentially all in the subject line, and my answer is yes.

    I receive notifications for all MRs opened against DPT packages, and
    Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,
    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Louis-Philippe_V=c3=a9ron@21:1/5 to Sandro Tosi on Thu Feb 17 18:50:01 2022
    On 2022-02-17 12 h 39, Sandro Tosi wrote:
    Hello all,
    the question is essentially all in the subject line, and my answer is yes.

    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,

    You sent a mail on the list on 2020-07-27 about this and the general
    consensus (3-4 replies) was that it was a good idea.

    Anyway, I also vote yes!

    --
    ⢀⣴⠾⠻⢶⣦⠀
    ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
    ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
    ⠈⠳⣄

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andreas Tille@21:1/5 to All on Thu Feb 17 21:00:01 2022
    Hi,

    Am Thu, Feb 17, 2022 at 12:39:54PM -0500 schrieb Sandro Tosi:
    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    I admit I'm hesitating a bit for different reasons. While I agree that
    direct commits are better than MRs I found several DPT packages with
    very sensible changes in Git but no uploads following these. For
    instance fixing VCS fields and Maintainer name should be followed by an according upload to make those changes visible to users and developers
    of the *packages* in Debian.

    In the Debian Med team for instance we do those automatic changes before uploading a package - say when upgrading to new upstream versions or
    fixing some bugs. Than we run the Janitor scripts and other automatic
    changes which is all done in routine-update. I personally find this
    workflow more convenient. That way Debian Med team (as well as pkg-r
    team) are blacklisted for Janitor to not have competing changes inside
    the package.

    Kind regards

    Andreas.

    --
    http://fam-tille.de

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Emmanuel Arias@21:1/5 to All on Thu Feb 17 20:30:01 2022
    On Thu, Feb 17, 2022 at 2:48 PM Louis-Philippe Véronneau <pollo@debian.org> wrote:

    On 2022-02-17 12 h 39, Sandro Tosi wrote:
    Hello all,
    the question is essentially all in the subject line, and my answer is
    yes.

    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,

    You sent a mail on the list on 2020-07-27 about this and the general consensus (3-4 replies) was that it was a good idea.

    Anyway, I also vote yes!


    I also vote yes :-)



    --
    ⢀⣴⠾⠻⢶⣦⠀
    ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
    ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
    ⠈⠳⣄



    <div dir="ltr"><div dir="ltr"><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div dir="ltr"><br></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">
    On Thu, Feb 17, 2022 at 2:48 PM Louis-Philippe Véronneau &lt;<a href="mailto:pollo@debian.org">pollo@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:
    1ex">On 2022-02-17 12 h 39, Sandro Tosi wrote:<br>
    &gt; Hello all,<br>
    &gt; the question is essentially all in the subject line, and my answer is yes.<br>
    &gt; <br>
    &gt; I receive notifications for all MRs opened against DPT packages, and<br> &gt; Janitor&#39;s are always pretty much ready to merge as is, and so i think<br>
    &gt; we should let Janitor commit directly to the team packages.<br>
    &gt; <br>
    &gt; Jelmer is in CC (not sure if he&#39;s subscribed), in case he wants to<br> &gt; chime in on the implication of this discussion.<br>
    &gt; <br>
    &gt; Regards,<br>

    You sent a mail on the list on 2020-07-27 about this and the general<br> consensus (3-4 replies) was that it was a good idea.<br>

    Anyway, I also vote yes!<br></blockquote><div><br></div><div>I also vote yes :-)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

    -- <br>
      ⢀⣴⠾⠻⢶⣦⠀<br>
      ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau<br>
      ⢿⡄⠘⠷⠚⠋   <a href="mailto:pollo@debian.org" target="_blank">pollo@debian.org</a> / <a href="http://veronneau.org" rel="noreferrer" target="_blank">veronneau.org</a><br>
      ⠈⠳⣄<br>

    </blockquote></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Nilesh Patra@21:1/5 to Sandro Tosi on Thu Feb 17 22:10:02 2022
    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8aoa0ec6mZlUUIyk6iWAFS8iOKcCDfZK6
    Content-Type: text/plain; charset=utf-8; format=flowed
    Content-Language: en-US
    Content-Transfer-Encoding: quoted-printable

    On 2/18/22 2:23 AM, Sandro Tosi wrote:
    I admit I'm hesitating a bit for different reasons. While I agree that
    direct commits are better than MRs I found several DPT packages with
    very sensible changes in Git but no uploads following these. For
    instance fixing VCS fields and Maintainer name should be followed by an
    according upload to make those changes visible to users and developers
    of the *packages* in Debian.

    In the Debian Med team for instance we do those automatic changes before
    uploading a package - say when upgrading to new upstream versions or
    fixing some bugs. Than we run the Janitor scripts and other automatic
    changes which is all done in routine-update. I personally find this
    workflow more convenient. That way Debian Med team (as well as pkg-r
    team) are blacklisted for Janitor to not have competing changes inside
    the package.

    thanks for bringing the perspective of how things are done in the Med
    team, but it feels none of the points you mentioned nor the specific
    Med team workflow apply here,

    I suppose the highlight was the usage of routine-update[1] package before upload
    and we could use it with DPT too.
    This does similar(same?) changes as in janitor.

    But that said, I agree with what you wrote:

    or are relevant to just let Janitor
    commit directly to our packages.

    I vote a in for/OK for janitor to commit directly as well.

    [1]: https://tracker.debian.org/pkg/routine-update

    Regards,
    Nilesh


    --8aoa0ec6mZlUUIyk6iWAFS8iOKcCDfZK6--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEEPpmlJvXcwMu/HO6mALrnSzQzafEFAmIOt5kFAwAAAAAACgkQALrnSzQzafGU 2g//Sf2zArxl5jugj3FDksqRwbqRItCeICYuW/1jo+trfDlaselQEfcLbQ4HRdkJn+f45ihlrce/ qpdp0FAI90uLjtlXbC4Rx0FABc+NjZlb9zjzZd1VQmAc5z5ZM2FJwG/1PmCnaFbvA5PHJkdtKEVZ mxZTPHpXA7xEL6vxuPioO99g8aKy9U7gOnXilR7M7P/gSmWkqHHk3BHn+GdwC4JzdqCL21OAC6h6 54gfeP4g/ruBSh6yiinpHqc+HvTXKyeyUaRuuuZN3PonGAxCnQKvAnK+nWa9vmpGjmLZHSrgxW45 NPjPQN4NwP/1azQwF3RzRdODXO5du6E4kNPBNg8MvL3ts/xYVZeefv4J46zRtKJX7oMpcJ6qV0mJ ncYz2+XsD9VMYnI5quCBg4H7VEeYr4V5gMkG62mXw2Z6VR+Dbiijq7wggE4GhPjrWLhErP8WQAWM yGF4QEYkJYDjQEQKXjYIbvsaPVgvFrLjd3OXsbzn5eovZ68DMYPuwUPI2NO9wFKT4RC5ay0F73yx mrhAMZ5gKpI+QTmb8LpWBX/iaBbLyWdrIDDij4lbTF1um6m11ZlkvrAdrir887zpISYE0gl+B32Z A/uLch4LtByJlBpiDDAVVbDt6rYS77pey3ckVzUzvOiTRcdb25VJwqLpvi2vE+0vybEX+fuHlRNd Vq0=
    =yFF8
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sandro Tosi@21:1/5 to All on Thu Feb 17 22:00:01 2022
    I admit I'm hesitating a bit for different reasons. While I agree that direct commits are better than MRs I found several DPT packages with
    very sensible changes in Git but no uploads following these. For
    instance fixing VCS fields and Maintainer name should be followed by an according upload to make those changes visible to users and developers
    of the *packages* in Debian.

    In the Debian Med team for instance we do those automatic changes before uploading a package - say when upgrading to new upstream versions or
    fixing some bugs. Than we run the Janitor scripts and other automatic changes which is all done in routine-update. I personally find this
    workflow more convenient. That way Debian Med team (as well as pkg-r
    team) are blacklisted for Janitor to not have competing changes inside
    the package.

    thanks for bringing the perspective of how things are done in the Med
    team, but it feels none of the points you mentioned nor the specific
    Med team workflow apply here, or are relevant to just let Janitor
    commit directly to our packages.

    Regards,
    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andreas Tille@21:1/5 to All on Sat Feb 19 14:30:01 2022
    Am Fri, Feb 18, 2022 at 02:31:13AM +0530 schrieb Nilesh Patra:
    On 2/18/22 2:23 AM, Sandro Tosi wrote:
    thanks for bringing the perspective of how things are done in the Med
    team, but it feels none of the points you mentioned nor the specific
    Med team workflow apply here,

    I suppose the highlight was the usage of routine-update[1] package before upload
    and we could use it with DPT too.

    Yes.

    This does similar(same?) changes as in janitor.

    I asked Jelmer what Janitor is doing and included those calls into routine-update.

    But that said, I agree with what you wrote:

    or are relevant to just let Janitor
    commit directly to our packages.

    I vote a in for/OK for janitor to commit directly as well.

    Just in case this was not clear from my previous mail: I'm fine with
    direct commits.

    My additional point was that I consider it sensible to let those commits
    follow actual uploads which I was missing for several DPT packages which
    I touched by chance.

    Kind regards

    Andreas.

    [1]: https://tracker.debian.org/pkg/routine-update

    --
    http://fam-tille.de

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sandro Tosi@21:1/5 to morph@debian.org on Tue Mar 29 23:50:01 2022
    Piotr, Stefano, Bernd, Scott, Ondrey,
    as owners of the DPT salsa team ( https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
    can you approve (or deny) this request, and so give access to Janitor to directly commit to all our repos, instead of filing MRs?

    thanks!

    On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:

    Hello all,
    the question is essentially all in the subject line, and my answer is yes.

    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,
    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi



    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi

    <div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Piotr, Stefano, Bernd, Scott, Ondrey,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">as owners of the DPT salsa team (<a href="https:/
    /salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc">https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc</a>) can you approve (or deny) this request, and so give access to Janitor
    to directly commit to all our repos, instead of filing MRs?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">thanks!</div></div><br><div
    class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi &lt;<a href="mailto:morph@debian.org">morph@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:
    1px solid rgb(204,204,204);padding-left:1ex">Hello all,<br>
    the question is essentially all in the subject line, and my answer is yes.<br>

    I receive notifications for all MRs opened against DPT packages, and<br> Janitor&#39;s are always pretty much ready to merge as is, and so i think<br> we should let Janitor commit directly to the team packages.<br>

    Jelmer is in CC (not sure if he&#39;s subscribed), in case he wants to<br> chime in on the implication of this discussion.<br>

    Regards,<br>
    -- <br>
    Sandro &quot;morph&quot; Tosi<br>
    My website: <a href="http://sandrotosi.me/" rel="noreferrer" target="_blank">http://sandrotosi.me/</a><br>
    Me at Debian: <a href="http://wiki.debian.org/SandroTosi" rel="noreferrer" target="_blank">http://wiki.debian.org/SandroTosi</a><br>
    Twitter: <a href="https://twitter.com/sandrotosi" rel="noreferrer" target="_blank">https://twitter.com/sandrotosi</a><br>
    </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Sandro &quot;morph&quot; Tosi<br>My website: <a href="http://sandrotosi.me/" target="_blank">http://sandrotosi.me/</a><br>Me at Debian: <a href="http://wiki.
    debian.org/SandroTosi" target="_blank">http://wiki.debian.org/SandroTosi</a><br>Twitter: <a href="https://twitter.com/sandrotosi" target="_blank">https://twitter.com/sandrotosi</a></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From stefanor@debian.org@21:1/5 to All on Tue May 24 12:40:01 2022
    Hi Sandro (2022.03.29_21:46:29_+0000)

    Seeing Jelmer reminded me about this thread.

    I have no objection, so count this as an approval.

    I thought Janitor was already doing this, though...

    SR

    Piotr, Stefano, Bernd, Scott, Ondrey,
    as owners of the DPT salsa team ( https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
    can you approve (or deny) this request, and so give access to Janitor to directly commit to all our repos, instead of filing MRs?

    thanks!

    On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:

    Hello all,
    the question is essentially all in the subject line, and my answer is yes.

    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,
    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi



    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi

    --
    Stefano Rivera
    http://tumbleweed.org.za/
    +1 415 683 3272

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jelmer =?utf-8?Q?Vernoo=C4=B3?=@21:1/5 to stefanor@debian.org on Tue May 24 12:50:01 2022
    Yeah, this is already happening.

    If the janitor starts making other sorts of changes in the future,
    I'll check in here first rather than just enabling those.

    Jelmer

    On Tue, May 24, 2022 at 10:30:57AM +0000, stefanor@debian.org wrote:
    Hi Sandro (2022.03.29_21:46:29_+0000)

    Seeing Jelmer reminded me about this thread.

    I have no objection, so count this as an approval.

    I thought Janitor was already doing this, though...

    SR

    Piotr, Stefano, Bernd, Scott, Ondrey,
    as owners of the DPT salsa team ( https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
    can you approve (or deny) this request, and so give access to Janitor to directly commit to all our repos, instead of filing MRs?

    thanks!

    On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:

    Hello all,
    the question is essentially all in the subject line, and my answer is yes.

    I receive notifications for all MRs opened against DPT packages, and Janitor's are always pretty much ready to merge as is, and so i think
    we should let Janitor commit directly to the team packages.

    Jelmer is in CC (not sure if he's subscribed), in case he wants to
    chime in on the implication of this discussion.

    Regards,
    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi



    --
    Sandro "morph" Tosi
    My website: http://sandrotosi.me/
    Me at Debian: http://wiki.debian.org/SandroTosi
    Twitter: https://twitter.com/sandrotosi

    --
    Stefano Rivera
    http://tumbleweed.org.za/
    +1 415 683 3272

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)