Dear list, Sandro,

I have uploaded on salsa a new upstream version of sphinxext-opengraph: https://salsa.debian.org/python-team/packages/sphinxext-opengraph/

I have also modified the way how tests are run... but I'm still in the
process of understanding how autopkgtests works ....

If everything is good feel free to upload. Let me know how things can be improved otherwise.

Thanks for listening,

Chiara

<div dir="ltr"><div>Dear list, Sandro,</div><div><br></div><div>I have uploaded on salsa a new upstream version of sphinxext-opengraph:</div><div><a href="https://salsa.debian.org/python-team/packages/sphinxext-opengraph/">https://salsa.debian.org/python-
team/packages/sphinxext-opengraph/</a></div><div><br></div><div>I have also modified the way how tests are run... but I&#39;m still in the process of understanding how autopkgtests works ....</div><div><br></div><div>If everything is good feel free to
upload. Let me know how things can be improved otherwise.</div><div><br></div><div>Thanks for listening,</div><div><br></div><div>Chiara<br></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Thu, 30 Dec 2021 14:27:09 -1000
Chiara Marmo <marmochiaskl@gmail.com> wrote:

Dear list, Sandro,

I have uploaded on salsa a new upstream version of
sphinxext-opengraph: https://salsa.debian.org/python-team/packages/sphinxext-opengraph/

I have also modified the way how tests are run... but I'm still in
the process of understanding how autopkgtests works ....

Enabling the CI on salsa for your package can be really helpful to
verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed at
all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
(i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
as python3-sphinx) should not be duplicated as a test dependency;
* within the control file, the field identifying tests in a separate
file is called 'Tests', not 'Test-Command'.

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmHO7rwACgkQQoMEoXSN zHq9Vg/+KNkkqrntxwIq3gDq0XyPZ4GpbSlPd7Tvw5DdZlOS3U8P/O43rHKIBZKb Iw26ML8J55MKlahQvOrWGNModcwTzCFtEU0gz/l08Na6++FzmsNb9Y6tVtvSyT6Z xKp6FdJzTrOWJSbOD/h3GaPssJG/AJXhG6qGiIEhC/IkhO2xg41GqgxPLq2BcDZU ixu+bsEaBVtFB88Z4Q5pHTnZuseXDBHJr0N3DmcUOpzCLoD/Ih5pujG3ryJ4n+FM CPXILUw9mmOKST1sTsXUJKt0iz+0jTyVt9fx6nfem3FSbFiKgNXoMHz8UsC5D5c0 ujkgrjVg4wLlWs/faTSOxaaN0ch0YLYedY1dJZN1NqskoQOM3BO449E+VyKlXVH8 jywuxdfW50hGYcoTOCrjzOiBVr1Y8ApWQ3RB1XpQaPZjyGq+jumSoH40FRkUSBXJ NppDsNBtrwbcqka4in9sdStzza/ytBPHXMVVP6KrbCXtMOQ+RBsq/Cd1pdqFY++S yaVZWKghoOnDlRMSwSEIJSszthVnLN1A3ANsw9d5rxx1JXf8iErtHQHli4qNZVD2 GIk3uskiX1P4hqoAOXYCQ+9YTgZuJ9v/UAOrXIvvhu76Th01evVN5jkB9z9hMAdr rVZ1FLm5rVIu68JyWYaNGz/s7ir3O+sXow6ysuL+60Xd/2xEp1A=
=A1hf
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Thanks Jeroen for your time and your review

Enabling the CI on salsa for your package can be really helpful to

verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Indeed, I have enabled it.

Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed at
all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
(i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
as python3-sphinx) should not be duplicated as a test dependency;
* within the control file, the field identifying tests in a separate
file is called 'Tests', not 'Test-Command'.

I think the configuration is better now, as the CI passed too.
Please let me know if the package is ready for the upload.

Also, happy new year 2022 to all the people on the list!

Best,

Chiara

<div dir="ltr"><div>Thanks Jeroen for your time and your review<br></div><div dir="ltr"><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Enabling the CI on salsa for your package can be really helpful to<br>
verify things work as expected. As an added benefit, it also lowers<br>
the time and effort needed to review a package.<br></blockquote><div><br></div><div>Indeed, I have enabled it. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Anyway, the current autopkgtest has a number of obvious flaws:<br>
* the binary package it&#39;s trying to test isn&#39;t actually installed at<br>
  all because it&#39;s not listed as a test dependency;<br>
* the same goes for the supported python versions the test loops over<br>
  (i.e. the necessary dependency on python3-all is missing).<br>
* on the other hand, dependencies of the package being tested (such<br>
  as python3-sphinx) should not be duplicated as a test dependency;<br>
* within the control file, the field identifying tests in a separate<br>
  file is called &#39;Tests&#39;, not &#39;Test-Command&#39;.<br></blockquote><div><br></div><div>I think the configuration is better now, as the CI passed too.</div><div>Please let me know if the package is ready for the upload.</div><div><br></div><

Also, happy new year 2022 to all the people on the list!</div><div><br></div><div>Best,</div><div><br></div><div>Chiara<br></div><div> </div></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Fri, 31 Dec 2021 17:25:34 -1000
Chiara Marmo <marmochiaskl@gmail.com> wrote:

I think the configuration is better now, as the CI passed too.

Using @builddeps@ may seem attractive at first, but is best reserved
for autopkgtests that actually do a full build. In most other cases
redundant extra stuff gets installed that's only needed at build
time, such as dh-python and setuptools in this case.

In addition, python packages that run tests at build time typically
have the full set of module dependencies as build-deps that one also
expects to find as deps on the (main) binary pkg. For such packages,
using @builddeps@ causes dependencies of the package being tested to
get duplicated as test deps, meaning any missing ones - for example
resulting from a packaging or helper application bug - could easily
be overlooked. After all, the autopkgtest would pass even for a
severely broken binary package with all python deps missing.

Please let me know if the package is ready for the upload.

The debhelper compat level could do with a bump to the current
version. Other than that, things look fine.

Also, happy new year 2022 to all the people on the list!

Indeed!

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmHRk2gACgkQQoMEoXSN zHqVMw//VblW2j43E9LgA/O7lAhuwI025B9cP3xKjHlKxXN16WYZ9E6mSNRJx7ja 0aHHUnYpIqekxRZwaNlg7pupEkdas55X4yAOwQrtb2B0/4XZ0bjRmQGD5m9CcKQH iV/AaSExcKaUMLuyywPomlLOiKGEcAo3bJBsSBKhmfWa9tGWUbLWxb5NW2tyJcf0 1o9zk0b5p8mSC83wLKvFJzhTAksqobtPrEkpZ7LWKaDAoG8z+I3or2mv7puKRIXZ K+Hhk85olhv3hE4BReU1Jl47iGNC7QB1F2r30/Oj9wOGXFUc1oN+TefIQrSkBhEv 9d0ZrjgXzjEgxXDwzFDzaCt3b8Gn4ZlBoKGeqDiufLf1frAAWwjVbrhiU572vyW4 T1CDgNZKKHT73Jf3+ZZQVvpTbh6QzVgaO2SMHgqpS1XnzHyYsxxqMvemFVx+7trL vzx2+vNBb2UWVhnQxMX8xyVfKM0zXpF2dVTKDc9vUQMNmu5rHm6jP7NelGH3MhKh 1JioLnKRNb5UFrK/yvdSFs6LXA4UkMRIuSgizQln2BH8oAdnSfOSLv2JY4sHB6uM OH7maLZTdzy2x3MNlsZ4/Vgij1wZr8VPLpBs3VR/uets1N27VMsW6MPMVMhdz/bV zP3q868G07HaSOKJE9KNdr17kfiA5XCOtBw597wncvVl4y9DMKo=
=FffQ
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Thanks Jeroen for your comments and clarifications.

Using @builddeps@ may seem attractive at first, but is best reserved

for autopkgtests that actually do a full build. In most other cases
redundant extra stuff gets installed that's only needed at build
time, such as dh-python and setuptools in this case.

I believe I have reduced the dependencies to the ones needed for the tests.

The debhelper compat level could do with a bump to the current

version. Other than that, things look fine.

Version bumped.

Ready for upload?
Thanks!
Best,

Chiara

<div dir="ltr"><div>Thanks Jeroen for your comments and clarifications.</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Using @builddeps@ may seem attractive at first, but is best reserved<br>
for autopkgtests that actually do a full build. In most other cases<br> redundant extra stuff gets installed that&#39;s only needed at build<br>
time, such as dh-python and setuptools in this case.<br></blockquote><div><br></div><div>I believe I have reduced the dependencies to the ones needed for the tests.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;
border-left:1px solid rgb(204,204,204);padding-left:1ex">
The debhelper compat level could do with a bump to the current<br>
version. Other than that, things look fine.<br></blockquote><div><br></div><div>Version bumped.</div><div><br></div><div>Ready for upload?</div><div>Thanks!</div><div>Best,</div><div><br></div><div>Chiara<br></div></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sun, 2 Jan 2022 15:26:30 -1000
Chiara Marmo <marmochiaskl@gmail.com> wrote:

Ready for upload?

Uploaded with some minor changes. Thanks for your contribution.

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmHSyIgACgkQQoMEoXSN zHqyWQ/9FalshuszA2v3YoVrx+ibfDBBTtpW/WMrt3HA2Ig3FzYWeF+H4WXvWtvK 496GD+HTd1b7BokRA3JXVWIBypeBahKD46TYsa7uqIvgC1R0S/28XxpCz/MsX0d2 mvpLWYbEnLMR6GjhKA09c4LkfPsTRqPf79j6biLI6w+1h7yTmKdDAgPPbfQj9eUg Ji8j2L5iYkx7WpFHzshqxFk27J5JOEmBDG9Tu6nmnPf57wRn1Ev2/Ct+Yq8a1Xr5 eBXofr5DxPNSNePhi1trpexgQcHt8d5hEq4d5zmO3OtO312NRtnBBqgJ24bsH6XQ wqfkgNbBKYAfI+4EDYtwUyaQAQrESM/9fu3UEEj9uo2gqgE8pY1Pm4ojhd0Cg7g2 pUqWa7kSO33wTxe0ikRCK+ugFN1fFV28NmJ2HRzekPV3xa1t5Jn1YXttnaytlp4I +RNKHBolZryfqQhIcD3cR/4bE1of0nC+MbxK7Yz9l5FTr617BjKIYR1mJmxXgph7 CrrI55RryypVRZ3WYlYZERnn3uUrkEx9CQ8xjflLNh1msAutr4+cYNHKUkw+qc5n u7GYpMPwKCz6PeYGE37skpPDSr2dWlmAMJVgpg5Q2w926JImF34dvk6mIzsEboLV Fy+N3/XLE5A+iYNkcYDgjpB1zcMvNOzU0BOk3xResD4W8LYwan4=
=xLHb
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Uploaded with some minor changes. Thanks for your contribution.

Thanks Jeroen!

Chiara

<br>&gt; Uploaded with some minor changes. Thanks for your contribution.<br>&gt;<br><br>Thanks Jeroen!<br><br>Chiara

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)