Hello Antonio,
as you initially did the first upload for this package I'm now heading
over to you.
Am 19.09.21 um 09:48 schrieb Debian FTP Masters:
python-django-js-asset_1.2.2-3.dsc: Invalid size hash for python-django-js-asset_1.2.2.orig.tar.gz:
According to the control file the size hash should be 6360,
but python-django-js-asset_1.2.2.orig.tar.gz has 6367.
If you did not include python-django-js-asset_1.2.2.orig.tar.gz in your upload, a different version
might already be known to the archive software.
I've no idea where the size of 6360 for the orig.tar.gz file is coming
from which DAK refers.
If I look at the source package sites or on snapshot.d.o I always see a
size of 6367.
https://packages.debian.org/source/unstable/python-django-js-asset http://snapshot.debian.org/package/python-django-js-asset/1.2.2-1/
And this size was recreated by gbp locally.
But the question is now how to proceed now. A quick & dirty solution
would be to simply use the old tar.gz file (if available).
Another option would be more dramatically and let remove the package completely from the archive. Do you have opinions on that?
Looking from my side, the tarball from the archive (apt source python-django-js-asset) and the one generated by pristine-tar are
identical:
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/python-django-js-asset_1.2.2.orig.tar.gz
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/archive/python-django-js-asset_1.2.2.orig.tar.gz
From reading the REJECT email, I think it implies that the .dsc/.changes
you uploaded refer to an orig tarball with 6360 bytes. Do you still have
the exact artifacts that you uploaded?
Hi Antonio,As pristine-tar is not enabled in debian/gbp.conf you need to enable it explicitly with --git-pristine-tar each time you run a command that uses
thanks for your quick feedback!
Am 19.09.21 um 21:24 schrieb Antonio Terceiro:
Looking from my side, the tarball from the archive (apt source python-django-js-asset) and the one generated by pristine-tar are identical:
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/python-django-js-asset_1.2.2.orig.tar.gz
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/archive/python-django-js-asset_1.2.2.orig.tar.gz
From reading the REJECT email, I think it implies that the .dsc/.changes you uploaded refer to an orig tarball with 6360 bytes. Do you still have the exact artifacts that you uploaded?
No, not completely.
But I played around a bit with gbp and pristine-tar too and I was able to recreate a tarball which has the same size and the same hashes as the *.tar.gz in the archive and the one you've posted by using pristine-tar manually.
If I clean out all completely and build the package from scratch by gbp I
get again a wrong size and of course also different hashes.
Hi Antonio,
thanks for your quick feedback!
Am 19.09.21 um 21:24 schrieb Antonio Terceiro:
Looking from my side, the tarball from the archive (apt source python-django-js-asset) and the one generated by pristine-tar are identical:
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/python-django-js-asset_1.2.2.orig.tar.gz
4b6a2c8625b8e96bbc4ff1588a27238d7d418b03 /tmp/archive/python-django-js-asset_1.2.2.orig.tar.gz
From reading the REJECT email, I think it implies that the .dsc/.changes you uploaded refer to an orig tarball with 6360 bytes. Do you still have the exact artifacts that you uploaded?
No, not completely.
But I played around a bit with gbp and pristine-tar too and I was able to recreate a tarball which has the same size and the same hashes as the *.tar.gz in the archive and the one you've posted by using pristine-tar manually.
If I clean out all completely and build the package from scratch by gbp I
get again a wrong size and of course also different hashes.
Currently I've no real clue why gbp is creating here different results, will look again at this once Guido is around, I'm sure he can blame me that I'm doing something wrong. :P
What's the mechanism to put these options there for everyone who works onThat's because gbp does not use pristine-tar by default, and debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to fix that.I dont think this is the right approach: the default options to work
on DPT packages should be in gbp default config file (or in another,
global, config file), and not live in each and every package
debian/gbp.conf file;
That's because gbp does not use pristine-tar by default, and
debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to
fix that.
That's because gbp does not use pristine-tar by default, and
debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to
fix that.
I dont think this is the right approach: the default options to work
on DPT packages should be in gbp default config file (or in another,
global, config file), and not live in each and every package
debian/gbp.conf file; it is already inconsistently maintained with
several packages having uncommon settings that will take precedence
over the default ones.
On Mon, Sep 20, 2021 at 11:14:44AM -0400, Sandro Tosi wrote:
What's the mechanism to put these options there for everyone who works onThat's because gbp does not use pristine-tar by default, and debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to fix that.I dont think this is the right approach: the default options to work
on DPT packages should be in gbp default config file (or in another, global, config file), and not live in each and every package debian/gbp.conf file;
a DPT package?
Or do you mean just working with whatever is shipped with
gbp?
That's because gbp does not use pristine-tar by default, and debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to fix that.
I dont think this is the right approach: the default options to work
on DPT packages should be in gbp default config file (or in another,
global, config file), and not live in each and every package
debian/gbp.conf file; it is already inconsistently maintained with
several packages having uncommon settings that will take precedence
over the default ones.
On Mon, Sep 20, 2021 at 11:14:44AM -0400, Sandro Tosi wrote:
That's because gbp does not use pristine-tar by default, and debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to fix that.
I dont think this is the right approach: the default options to work
on DPT packages should be in gbp default config file (or in another, global, config file), and not live in each and every package debian/gbp.conf file; it is already inconsistently maintained with
several packages having uncommon settings that will take precedence
over the default ones.
I agree with you in theory; my global gbp.cons enables pristine-tar.
However, having it duplicated in every package means we as a team work consistently regardless of people's global configuration,
and that's one
less detail people need to get just right to be able to contribute effectively.
Also, one's global configuration might not apply to all the packages
they contribute to; it's easier for everyone if gbp just does the
right thing based on per-package configuration than expecting people to remember to switch their defaults, or to pass options explicitly.
However, having it duplicated in every package means we as a team work consistently regardless of people's global configuration, and that's one
less detail people need to get just right to be able to contribute effectively.
Also, one's global configuration might not apply to all the packages
they contribute to
it's easier for everyone if gbp just does the
right thing based on per-package configuration than expecting people to remember to switch their defaults, or to pass options explicitly.
| Sysop: | Keyop |
|---|---|
| Location: | Huddersfield, West Yorkshire, UK |
| Users: | 350 |
| Nodes: | 16 (2 / 14) |
| Uptime: | 09:28:03 |
| Calls: | 7,625 |
| Files: | 12,793 |
| Messages: | 5,686,482 |