Hi!
Sorry for the late reply.
On Thu, Nov 09, 2023 at 11:31:29AM +0100, Jeroen Ploemen wrote:
hi Bo,
I took a look at the riscemu package, put up for sponsorship in the
Python team. Some (mostly minor) issues came up:
* copyright:
+ upstream years are incorrect (license file, sources have 2021-2022
resp. 2023).
+ leftover boilerplate comments.
+ empty line (dot) at the start of the license paragraph.
Done.
* control:
+ no need to mention -doc/-examples pkgs in the long description,
that's what a suggested dependency is for.
+ tiny (< 10kB) examples package is probably best merged into the
documentation package.
Okay, I have merged examples into -doc package.
* rules:
+ weird comment at the top of the file (leftover TODO?).
+ variables for doc and example dirs defined but not used?
+ documentation dir /usr/share/doc/riscemu-doc/; did you mean
/usr/share/doc/riscemu/?
Yeah, I think it should be later too.
* d/riscemu-examples.install used for examples; these should be
handled by dh_installexamples instead.
Thanks, done.
* lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].
At first I thought there is no manual for the binary because I searched
a lot online. In fact if you `--help` you can get basic manual for it.
Fixed it.
Please let me know if there is any issue:
https://salsa.debian.org/python-team/packages/riscemu
Thanks for your reviewing it.
BR,
Bo
--
Regards,
--
Bo YU
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmVR6+4ACgkQ+RVP3hQ+ S69ghw/8DxjaqPLkrmAZ0FrAh+cWZvunp8YqMoBQ6aFY+vNct0kgF1409e4UpTLx eiIrTHfQAnYOiPxEtzt4qUw5U/55nP0j8kFv0jGC0hze0e/23oxYjVx4V+Wlgt/T RAI9EFKGGaZGLMMKqlNJJx+SdN2QUF3sz8a3FdUeJrSUbMmwoxIkzQ3zRtrALHo6 mkjlQcbYWcVjXjuv1NcGx03AEGOILyBYaAwbnA3cUKAUP5adg4uCT2Vq3plF28J3 7BxwPUfGns8stmar6D9FOdQjHcVqp3sW2cdBHqJDfVZSqgzj+tkVf20+vcEEi1zC 3K6uIYA1l99QaQHU5zaU7DlmZ+SVIZGvK3zenta3iAXOt/+U3yvH1G+9ObavGXeb qiO4OJ7+X14EWnypZwLE5bj55qRbYB7IC6c/3QN820ZJWja3Pc/F/GOsjQ0i1LoY YQKYOqDIDUBXJVQu69seIhzE/waeaAmZoXh0lzvillgwdmF9ANEFpV/juyCTJapI z040jUnfE5Cyg1WIFfdpzOm/DP/ehFKMWC4rSn4JzRaug0SO5QDH3Qth4/Dl+02C UiLb0J00tF/lMuX4mPVqAPmm16qYWA5PPruxRSJwhXyLV/gFKUnRv8NhscmN3g+H eDyqgjWhjb3GaYzUzYC7kX4BBvwDPr+uqJfzqL6ZgvebcWzO7SA=
=gtEO
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)