1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.PYTHON

  • review for riscemu/2.2.5-1

    From Jeroen Ploemen@21:1/5 to All on Thu Nov 9 11:40:01 2023
    hi Bo,

    I took a look at the riscemu package, put up for sponsorship in the
    Python team. Some (mostly minor) issues came up:

    * copyright:
    + upstream years are incorrect (license file, sources have 2021-2022
    resp. 2023).
    + leftover boilerplate comments.
    + empty line (dot) at the start of the license paragraph.

    * control:
    + no need to mention -doc/-examples pkgs in the long description,
    that's what a suggested dependency is for.
    + tiny (< 10kB) examples package is probably best merged into the
    documentation package.

    * rules:
    + weird comment at the top of the file (leftover TODO?).
    + variables for doc and example dirs defined but not used?
    + documentation dir /usr/share/doc/riscemu-doc/; did you mean
    /usr/share/doc/riscemu/?

    * d/riscemu-examples.install used for examples; these should be
    handled by dh_installexamples instead.

    * lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].

    --Sig_/Lzcw6tndXfpa53meK9EWRfContent-Type: application/pgp-signature Content-Description: OpenPGP digital signature

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmVMtQEACgkQQoMEoXSN zHq+GA//Wj0ZQa8IOwz8tgvB5AW6t/6ZzhnttiJRea4toYxOS1anOwK6QrQwAuo0 z/gNIfxfepYC5/aG2OqK3rM8wgEXlvSTAdj6RTcTxfwFpHcTcMkYjLDnsD9CMJvV D3F1xcIz0KqDO+fyFr8DDkU1KuQcF+nM1nzxwPgONW6v9KGGChggUlRZqNjFnvQf 9V+PihhHI1LKeERR3v3IvLxalZ0B/jQnu1vUmGRGcFwx5xhEiLZZmmYrXo0OlUW/ ni4/u+dje/Z52yWnqjxHo8yv16n2B9oUKLstax81dIhkE8sT8fmQSP2+XIcIm3cX MB1bqaeyH5XuA/1PruymgEJ99OB0JhR7EhsLmvna8NiGF4DK+IECcj+nLZZZw84x jGwDT7Qbwt5YeQ0vv8+plD/2t9A/3zM1FjLmxke+VUrSvDWmuLMAnIyVtgnt19+x OJlfa3JlIVe7ZV6ivP2wHVvtmT7ZyX62C/KFBvqDZQjZxYaYkxEXm8LUqPWG1+ix 2YGT3iyyjpWs96psmPC9V2QJbdJFFf+RFLi9KC6UH/9Lmp/l4XeVMNZytAtbWHa/ GWLHdtzsgFXHdflJhqf9cr+xTT4cCArv4q+uZr5n0wzogM2o0CuaHVHEAfKaOeN3 sARwquiTkrNBv97P1KJIfQPtlHwFePCkNi0IzqcBxcJVszcNQNsæeL
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Bo YU@21:1/5 to Jeroen Ploemen on Mon Nov 13 10:30:02 2023
    Hi!

    Sorry for the late reply.

    On Thu, Nov 09, 2023 at 11:31:29AM +0100, Jeroen Ploemen wrote:
    hi Bo,

    I took a look at the riscemu package, put up for sponsorship in the
    Python team. Some (mostly minor) issues came up:

    * copyright:
    + upstream years are incorrect (license file, sources have 2021-2022
    resp. 2023).
    + leftover boilerplate comments.
    + empty line (dot) at the start of the license paragraph.

    Done.


    * control:
    + no need to mention -doc/-examples pkgs in the long description,
    that's what a suggested dependency is for.
    + tiny (< 10kB) examples package is probably best merged into the
    documentation package.

    Okay, I have merged examples into -doc package.


    * rules:
    + weird comment at the top of the file (leftover TODO?).
    + variables for doc and example dirs defined but not used?
    + documentation dir /usr/share/doc/riscemu-doc/; did you mean
    /usr/share/doc/riscemu/?

    Yeah, I think it should be later too.


    * d/riscemu-examples.install used for examples; these should be
    handled by dh_installexamples instead.

    Thanks, done.


    * lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].

    At first I thought there is no manual for the binary because I searched
    a lot online. In fact if you `--help` you can get basic manual for it.
    Fixed it.

    Please let me know if there is any issue: https://salsa.debian.org/python-team/packages/riscemu

    Thanks for your reviewing it.

    BR,
    Bo

    --
    Regards,
    --
    Bo YU


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmVR6+4ACgkQ+RVP3hQ+ S69ghw/8DxjaqPLkrmAZ0FrAh+cWZvunp8YqMoBQ6aFY+vNct0kgF1409e4UpTLx eiIrTHfQAnYOiPxEtzt4qUw5U/55nP0j8kFv0jGC0hze0e/23oxYjVx4V+Wlgt/T RAI9EFKGGaZGLMMKqlNJJx+SdN2QUF3sz8a3FdUeJrSUbMmwoxIkzQ3zRtrALHo6 mkjlQcbYWcVjXjuv1NcGx03AEGOILyBYaAwbnA3cUKAUP5adg4uCT2Vq3plF28J3 7BxwPUfGns8stmar6D9FOdQjHcVqp3sW2cdBHqJDfVZSqgzj+tkVf20+vcEEi1zC 3K6uIYA1l99QaQHU5zaU7DlmZ+SVIZGvK3zenta3iAXOt/+U3yvH1G+9ObavGXeb qiO4OJ7+X14EWnypZwLE5bj55qRbYB7IC6c/3QN820ZJWja3Pc/F/GOsjQ0i1LoY YQKYOqDIDUBXJVQu69seIhzE/waeaAmZoXh0lzvillgwdmF9ANEFpV/juyCTJapI z040jUnfE5Cyg1WIFfdpzOm/DP/ehFKMWC4rSn4JzRaug0SO5QDH3Qth4/Dl+02C UiLb0J00tF/lMuX4mPVqAPmm16qYWA5PPruxRSJwhXyLV/gFKUnRv8NhscmN3g+H eDyqgjWhjb3GaYzUzYC7kX4BBvwDPr+uqJfzqL6ZgvebcWzO7SA=
    =gtEO
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)