Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

BR,
Bo

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm
going to review this package.

Cheers,
Emmanuel

BR,
Bo

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEE3lnVbvHK7ir4q61+p3sXeEcY/EFAmUkPHwACgkQ+p3sXeEc Y/ErmQ//dvv+Nj+O6YXz7E8DmZ/pc0oXS8m78Xz5yWmNPfZFrpEcmRZEvjccyy65 mb6SR0NANsQ1oCU64Sdp6ri0d2dl/zZxNGCvDqXa/sFBhvOADy/UUUR/EMKZmSCM nqsx+Vz1jmGa2jTzt7XQFHUJ6bKIEaLqdmkmK4MbbHzh5Iag6xD6Tdl/wAklRVXx bZ4U6JmAwBVcPe5JrtvgFakCbr7j5RgGnwk+nlDZZvub8AfTczZTIeFkhoXU8jmH uzQ4pkDBXYN9KeaNE5YhIruZ5kOIRjR3U9xlCbSzLusN0ln+v2E7MxHdlBKlTXdn MtlMbnVyLpR6KGJIQZNvho8NAAICrXEJTdf2m/Bo/BDH32HzjwxeWLX39o2ff0ZY UUJt9L/RJFGOijq/QrljsYRS3B++gWFdmBFrUjXMwdOKPqtE18xtSLb48KZDn1PF fa36zBB1DPVO4KIZkDcmK+4cBqh503knVOhNxwNsQ2+awt7B0DAQw1q1LYWnGrDz ISANzbzpqSevLKEIMpsNb7a5dUdBUKxe8JsgROXepeds5+1yf8PBPwmwkkgDjAhh qjj1T6Oelw4Aznsb5jgpMWIDMZN58J6bchVRHLQd4INcn0AlElviUoeVsYqPK0sk mFHPJLpo0Jvi25upQmFNy5+bZpQzPU6jKzj9MH+ViuCVLWabxCU=
=wgA0
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Oct 09, 2023 at 02:46:36PM -0300, Emmanuel Arias wrote:

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm
going to review this package.

Cheers,
Emmanuel

Hi!,

Me again.

I leave you some comments regarding to FileCheck

* Binary package suggests install the docs package, but is not in
d/control.
* Package should depends on python3-poetry-core instead of python3-poetry
* d/copyright: upstream does not specify a range of date 2019-2023, only in
docs/conf.py the copyright says 2019.
* The package synopsis should not finished with a period. Please remove it.
* The binary package should not be python3-filecheck?

Cheers,
Emmanuel

BR,
Bo

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEE3lnVbvHK7ir4q61+p3sXeEcY/EFAmUkWacACgkQ+p3sXeEc Y/FgJQ//RPiR+JoVV+BkrrjwLQmso7KERBzxPcEfvXu0at7eMTH/sPVCQgqK5dZj nUv432EPPL2mZqf5jvTT8cjUk1Xgsq9yevYth//IKr7VZyZ0yF6qAMApT8GAzxm1 ehX2uT07KSMn1PDoirXE1dQG2l+j8aefxJ0jLKnMkO7k2ygsZVF31ODCGBWMVUl9 Ic7e3JUG5dBUvKRWaaImjtdQIGVSPCuvcY0YEJVgrPd1PpS/ErH8xN10ZwxxxO9I PGLuTodA6qOtFORQoACWjpsU1I7mQHCSVnooslDKAvh5V1WbCEEhfznjD4S89Vt8 R9Mqrs0rUJt5HvYngV/bD+Eoz0M0UJ19gAeKhF5Bm66RIPbkCqOxd/IYQcj/SHWN 7YzmefAj63R5OsadfIpdD8NZUU60THrDYEtsVRCP1QYvdBVoYQCBns+dxl7T2y6/ 738L8Ih/JmhTmGBZ6Nu48YTLpIFPhkyJhoYOumf6q9xIbI4rpWFMeTnAjz75ZZi4 U9436DV9fO0vhmAEAx/WaFnTcQewwbcyYUOD1UaZsD+DZPlXaegqx8w8n+1jLPIr ozZ+R4r4DtC1tSNzal8pns/xjqo5f8hvA9nifovneikVXa4TIhyomHINu00QRKvX Y/5svxJrgZiOtu4y84IGf4ukoj1XsKi0FUoe2Zw8sJ7jZV57YkI=
=RaZv
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi！

Thanks for reviewing my package!


On Tue, Oct 10, 2023 at 3:51 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

On Mon, Oct 09, 2023 at 02:46:36PM -0300, Emmanuel Arias wrote:

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm going to review this package.

Cheers,
Emmanuel

Hi!,

Me again.

I leave you some comments regarding to FileCheck

* Binary package suggests install the docs package, but is not in
d/control.

Done. Here the ideal situation should be a docs package on there, but if we use sphinx-build to build its doc, there is one guzzle_sphinx_theme does
not in Debian.
So I package its manpage to binary package.

* Package should depends on python3-poetry-core instead of python3-poetry

Done.

* d/copyright: upstream does not specify a range of date 2019-2023, only in
docs/conf.py the copyright says 2019.

Yeah, although there are only one file flaged its date on 2019, but
how to judge the
whole project copyright date range? I just follow its the first commit:

https://github.com/mull-project/FileCheck.py/commits/main?after=195aa1527a2572b4697ae0d5c604f0baceba805c+419&branch=main&qualified_name=refs%2Fheads%2Fmain

Not sure this is right.

* The package synopsis should not finished with a period. Please remove it.

Sorry, I am not very clear about here. Do you mean here: https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L30
If yes, I think the synopsis solution should be more robust here.
Because it saves more space than
specially descriptions.

please let me know if there is not true.

* The binary package should not be python3-filecheck?

You hint me here. So I spilted the origin package into python3 library
package and
its binary tool binary. this should be working.

I have updated the package on salsa: https://salsa.debian.org/python-team/packages/filecheck

Thanks again for reviewing the package!

BR,
Bo

Cheers,
Emmanuel

BR,
Bo

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi!

On Thu, Oct 12, 2023 at 05:03:45PM +0800, Bo YU wrote:

Hi！

Thanks for reviewing my package!

On Tue, Oct 10, 2023 at 3:51 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

On Mon, Oct 09, 2023 at 02:46:36PM -0300, Emmanuel Arias wrote:

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm going to review this package.

Cheers,
Emmanuel

Hi!,

Me again.

I leave you some comments regarding to FileCheck

* Binary package suggests install the docs package, but is not in
d/control.

Done. Here the ideal situation should be a docs package on there, but if we use
sphinx-build to build its doc, there is one guzzle_sphinx_theme does
not in Debian.
So I package its manpage to binary package.

OK.

* Package should depends on python3-poetry-core instead of python3-poetry

Done.

* d/copyright: upstream does not specify a range of date 2019-2023, only in
docs/conf.py the copyright says 2019.

Yeah, although there are only one file flaged its date on 2019, but
how to judge the
whole project copyright date range? I just follow its the first commit:

https://github.com/mull-project/FileCheck.py/commits/main?after=195aa1527a2572b4697ae0d5c604f0baceba805c+419&branch=main&qualified_name=refs%2Fheads%2Fmain

Not sure this is right.

I'd just use 2019, not a range.

* The package synopsis should not finished with a period. Please remove it.

Sorry, I am not very clear about here. Do you mean here: https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L30
If yes, I think the synopsis solution should be more robust here.
Because it saves more space than
specially descriptions.

please let me know if there is not true.

Sorry, perhaps I was not clear, I mean remove the period at the end of
line 20 [0].

* The binary package should not be python3-filecheck?

You hint me here. So I spilted the origin package into python3 library package and
its binary tool binary. this should be working.

I have updated the package on salsa: https://salsa.debian.org/python-team/packages/filecheck

Thanks again for reviewing the package!

BR,
Bo

Cheers,
Emmanuel

BR,
Bo

The rest looks good to me.

[0] https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L20

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEE3lnVbvHK7ir4q61+p3sXeEcY/EFAmUpth4ACgkQ+p3sXeEc Y/Ew7g//VE0awWPu3mCxDbMnaWRAHcJaFO06Lc3DU7K4kU6Gw55Y94aKHE4WAHor Y7BqcnSJqr3KI4PNQOaKd/VNUKoL/hDR5MoUZkXK08fwfLzd2+3zjrwCZEZclyij /xh79ikZSYrxQpM3JxwZ9wn+RHi+XMAOf2yQ4V4mg2uuibtqmYmue8CCiDdKtx7u 49jE7MOHb1TGbgIoavqPmnARuYjD+m1nOL9Wz+PUnhZXV8XxIyWBz5WfVJvmyv4Z eEfJDa/zdC/akG8Mr4gK6+qaUjlo/94ND852ulKDANtNP6gdwp+G7QCV6uGnnly5 o707qFVKEZPEKg0xBeCx8XX93d1mbRl7P681SLtTXnH5A8faPZmeoaq20wcA8Jyj q4hKC+gsrhJmsHjhsxw21V6MjhgTaEqDp4OMLD+Uz4V6lJWVHcST8PzrpC/RnRqu kNpTqrTcXtOo9WLIxsmIx2jxzPZr5PU/G9CCbnHcKz7D5VviOw/rhqKskEoujinv psLlUNW/3xBpfFOyjv5CYAhEHVMR3nkxS72WvY+0efJLh5nBwRhED9W5LARwZPTZ 5UYRTdOU5OCRrxa4n2f0dkrBRwiRv80enEZ/M2R9f14gkDjtliZMKxu5hVkksdP/ 4F8if6HPjab/zoQcRZexL6lDlINh9uYMY6ZLi6lNNlCar7it/vg=
=kYjN
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi!

On Sat, Oct 14, 2023 at 5:27 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

Hi!

On Thu, Oct 12, 2023 at 05:03:45PM +0800, Bo YU wrote:

Hi！

Thanks for reviewing my package!

On Tue, Oct 10, 2023 at 3:51 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

On Mon, Oct 09, 2023 at 02:46:36PM -0300, Emmanuel Arias wrote:

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm going to review this package.

Cheers,
Emmanuel

Hi!,

Me again.

I leave you some comments regarding to FileCheck

* Binary package suggests install the docs package, but is not in
d/control.

Done. Here the ideal situation should be a docs package on there, but if we use
sphinx-build to build its doc, there is one guzzle_sphinx_theme does
not in Debian.
So I package its manpage to binary package.

OK.

* Package should depends on python3-poetry-core instead of python3-poetry

Done.

* d/copyright: upstream does not specify a range of date 2019-2023, only in
docs/conf.py the copyright says 2019.

Yeah, although there are only one file flaged its date on 2019, but
how to judge the
whole project copyright date range? I just follow its the first commit:

https://github.com/mull-project/FileCheck.py/commits/main?after=195aa1527a2572b4697ae0d5c604f0baceba805c+419&branch=main&qualified_name=refs%2Fheads%2Fmain

Not sure this is right.

I'd just use 2019, not a range.

Ok, done.

* The package synopsis should not finished with a period. Please remove it.

Sorry, I am not very clear about here. Do you mean here: https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L30
If yes, I think the synopsis solution should be more robust here.
Because it saves more space than
specially descriptions.

please let me know if there is not true.

Sorry, perhaps I was not clear, I mean remove the period at the end of
line 20 [0].

Okay, done. :)

* The binary package should not be python3-filecheck?

You hint me here. So I spilted the origin package into python3 library package and
its binary tool binary. this should be working.

I have updated the package on salsa: https://salsa.debian.org/python-team/packages/filecheck

Thanks again for reviewing the package!

BR,
Bo

Cheers,
Emmanuel

BR,
Bo

The rest looks good to me.

Thanks.
I updated the package here: https://salsa.debian.org/python-team/packages/filecheck/-/tree/debian/main/debian

Thanks,
BR,
Bo

[0] https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L20

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi!

Uploaded! Thanks for you contribution to Debian :-)

Cheers,
Emmanuel

On Sun, Oct 15, 2023 at 11:24:20PM +0800, Bo YU wrote:

Hi!

On Sat, Oct 14, 2023 at 5:27 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

Hi!

On Thu, Oct 12, 2023 at 05:03:45PM +0800, Bo YU wrote:

Hi！

Thanks for reviewing my package!

On Tue, Oct 10, 2023 at 3:51 AM Emmanuel Arias <eamanu@yaerobi.com> wrote:

On Mon, Oct 09, 2023 at 02:46:36PM -0300, Emmanuel Arias wrote:

Hi!

On Sat, Oct 07, 2023 at 09:34:43PM +0800, Bo YU wrote:

Hi team!

Due to rfs bot maybe not work on debian-python irc, So I am seeking help
to review/upload my new python package:

https://salsa.debian.org/python-team/packages/filecheck

TIA.

To avoid duplicated work from another team member, I mention here, I'm
going to review this package.

Cheers,
Emmanuel

Hi!,

Me again.

I leave you some comments regarding to FileCheck

* Binary package suggests install the docs package, but is not in
d/control.

Done. Here the ideal situation should be a docs package on there, but if we use
sphinx-build to build its doc, there is one guzzle_sphinx_theme does
not in Debian.
So I package its manpage to binary package.

OK.

* Package should depends on python3-poetry-core instead of python3-poetry

Done.

* d/copyright: upstream does not specify a range of date 2019-2023, only in
docs/conf.py the copyright says 2019.

Yeah, although there are only one file flaged its date on 2019, but
how to judge the
whole project copyright date range? I just follow its the first commit:

https://github.com/mull-project/FileCheck.py/commits/main?after=195aa1527a2572b4697ae0d5c604f0baceba805c+419&branch=main&qualified_name=refs%2Fheads%2Fmain

Not sure this is right.

I'd just use 2019, not a range.

Ok, done.

* The package synopsis should not finished with a period. Please remove it.

Sorry, I am not very clear about here. Do you mean here: https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L30
If yes, I think the synopsis solution should be more robust here.
Because it saves more space than
specially descriptions.

please let me know if there is not true.

Sorry, perhaps I was not clear, I mean remove the period at the end of
line 20 [0].

Okay, done. :)

* The binary package should not be python3-filecheck?

You hint me here. So I spilted the origin package into python3 library package and
its binary tool binary. this should be working.

I have updated the package on salsa: https://salsa.debian.org/python-team/packages/filecheck

Thanks again for reviewing the package!

BR,
Bo

Cheers,
Emmanuel

BR,
Bo

The rest looks good to me.

Thanks.
I updated the package here: https://salsa.debian.org/python-team/packages/filecheck/-/tree/debian/main/debian

Thanks,
BR,
Bo

[0] https://salsa.debian.org/python-team/packages/filecheck/-/blob/debian/main/debian/control#L20

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEE3lnVbvHK7ir4q61+p3sXeEcY/EFAmUtqvMACgkQ+p3sXeEc Y/H73g/+NWa0RM6cULJkHPhKqGAwi+nyM6w/3afWGV3sCkSY+abxdgQ/YURlG07Y o1u8HAque4/UTX3G+jnPFYFhHzPn/8krxETgSaKg9RpwX8TJk794kmJPMI+VRInj mN1nZUamxiAI4u4O2dKLg2MyfAkD/umvXCY1S9rygv6acriPcOxtzQoiB00I/2Qe WdmwrJl1KosoMjuAQ73gz1YCpAm8WuETlpeU0LJnkdFuTJzAB0STyXLBpOWrBR// N8f83PTygRCEgfzaiNs7yPrIBXhYzJz4tqUFVf/lu/GI2BfEAEZVZTz+lfQqJ62N Hwwspp9t2GVQmF4nHRLSbykh+9Qz/XEyeRsE/9GM777YkNlFusDyBPQOcobKMKqi kCFz+x36T3+F7UjlnOamcVxav0f2UgXMLHVLDO1IjAJRQWKMuD0aJC2heL1hJW3K guYzDwy49ywBjvu8RCSCncu3LS7pblxLLvoyYVoIxBhaEHK9Uxm5N7K9lEoJ0pLF BEgdtd31UKc20oH7Pvy7yCuGsU8hMUYncuP8L+DCMeoItKp5/avBjStKmYdAGqtj UzXJzQeqOaMP1BVeyXAKvO8/zOPwgYlvcqM6mbvvN26kK2QjcY5niBEH317EJr3X 9l1VAc26v9FV47TDzgHtxUgR9Du3FZ4w8FnR07QPYHwsRIfDIto=
=/ZaI
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)