Copy: morph@debian.org (Sandro Tosi)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sTIaJHqFfacexwiPxlgt93joYeeFlbqVA
Content-Type: multipart/mixed;
boundary="------------2681AE7249751D64D5811786"
Content-Language: en-US

This is a multi-part message in MIME format. --------------2681AE7249751D64D5811786
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hello everybody,

I want to tell you that I push to salsa an advances of poetry packaging.

Now, we have a complete package of poetry, so I'm requesting some more experienced reviewers.

I need to skip some tests because use a non versioned python, so that
give me some troubles like "python don't exist".

Also, there're some package (or package version) that aren't in Debian
yet. So, to save your time looking which are them I tell you that I run
the buildpackage in this way:

```

gbp buildpackage --git-ignore-new --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb
--extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb

```


Thanks for your help :)

Cheers,


--

Emmanuel Arias
@eamanu
yaerobi.com


--------------2681AE7249751D64D5811786
Content-Type: application/pgp-keys;
name="OpenPGP_0xFA9DEC5DE11C63F1.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
filename="OpenPGP_0xFA9DEC5DE11C63F1.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsFNBFw1x6oBEADBrJOCQvmkffxnUyGkx74a8xifdgEZLu+Xz6hV7CEyl1/71+8xqIZr9s09w++y Pod938Se/gopqgaXpIx46lKp1EI0F0hFoYne5ub6EsIxcyMCCFwbTeR8CQt2EJ86hpS+FYvbSTbw vNPCNT/EZuyE3KXrZk7j8nhoAobQwTZVE6agRULUTrxtH1q6w6OhBMtAyZpxRmq9nhLEYRvtSm++ pyRK+N40pgUED+psPB12NhpHfMpHfSoUyWKMC/7S34XMp1JQtogO4MFjviUpI8iWjWdqJvs/VWQe 0gQqnH/P4DMKyWdbgJbv9S/kj6r00SsGpMRq15wOcLdEPDST8vb7MDOAG77zBJy3kY3U7JbrWgad wnivD/nNHTeJAC6hFY/rfmKvWUKPyKO+Y+H6g6sWHTEjm/duIrvm2essMb08ebGoIcjDQf6q1nX8 6fDY8EM9L0IueN6CqybD2AyVQbifqA8Z8968Vrhl9TQOemNkHdqhhTHC9/H8osGj4pZF7Rqq3OKG oG61kbmti3142mGtfupCVRyRoLeR6BZF1s1TrXxqCXWtueyw0lCidfCcfYQAYsMsFUQ951BijSj6 0I/KeUmdyjgjfgFthzaG47wr9jQ1

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CC5bfAygOEW9YES05jlvfbmcMb9gywGl4
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 2021-07-02 18 h 25, Louis-Philippe Véronneau wrote:

2. d/control:

If you require specific dependencies, you should make it clear in
d/control. It's the kind of thing that helps a lot if people decide to backport it.

Specific _versions_ of dependencies. Sorry, Friday afternoon :)

--
Louis-Philippe Véronneau


--CC5bfAygOEW9YES05jlvfbmcMb9gywGl4--

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQTKp0AHB6gWsCAvw830JXpQshz6hQUCYN+TOQAKCRD0JXpQshz6 hfdvAQCibJbOTj+QVdC7yC9Cpb2HYLOJG6crUKJdL708bpF7bgD+ItmN64pY6oh9 jdmqpKu6Az/YUYIkiMP0k0c1Ipjzcwo=
=AhPh
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QeJbQBOUnoJcbwcxNVRjqpvk9fPKMo2Th
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 2021-06-19 18 h 21, Emmanuel Arias wrote:

Hello everybody,

I want to tell you that I push to salsa an advances of poetry packaging.

Now, we have a complete package of poetry, so I'm requesting some more experienced reviewers.

Sorry, I said I would do this but it took me some time to actually do it :)

Thanks for working on poetry, it's 100% going to make our lives easier.

I have not read the upstream code, so I might be missing things...
That's the kind of thing I only do when a package is ready to be sponsored.

Here are my comments:

1. d/control:

You haven't set the Python Team either in Maintainer or Uploaders.

---------------------------------------------------------------------

2. d/control:

If you require specific dependencies, you should make it clear in
d/control. It's the kind of thing that helps a lot if people decide to
backport it.

---------------------------------------------------------------------

3. tests/repositories/fixtures

This directory contains a bunch of tarballs from other projects. I'm not
sure what should be done with this, as I guess they are used in the testsuite....

My first reflex would be to exclude them from the imported tarball and
disable the tests that require them, but I don't know how much of the
testsuite depends on those tarballs.

Maybe someone else from the team can chime-in?

---------------------------------------------------------------------

4. d/tests

There are no autopkgtests. This being a large project that's kinda hard
to package, I don't really mind for now.

I think it's fair to wait to have at least 1 version in unstable before
working on that.

---------------------------------------------------------------------

5. d/rules

Isn't the step in execute_after_dh_auto_install better suited in execute_after_dh_clean instead? At least, it seems to me you're cleaning
the ./foo dir you patched in.

---------------------------------------------------------------------

6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry

Again, not something that needs to be fixed, but each subcommand of
poetry should probably get a man page:

https://python-poetry.org/docs/cli/

I looked at the code and I have no idea how this website is built (they
don't use sphinx). It seems like they do something manual?

https://github.com/python-poetry/poetry/issues/3382

Anyway, here's an example of how I added man pages to a program with
multiple commands:

https://github.com/spl0k/supysonic/tree/master/docs/man

---------------------------------------------------------------------

Overall it's very good! The trickiest part to fix will likely be #3 :S

I need to skip some tests because use a non versioned python, so that
give me some troubles like "python don't exist".

Also, there're some package (or package version) that aren't in Debian
yet. So, to save your time looking which are them I tell you that I run
the buildpackage in this way:

```

gbp buildpackage --git-ignore-new --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb
--extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb

This package has not been updated on Salsa, or at least, I couldn't find version 1.7.0-1 anywhere. Maybe you forgot to push?

I'm getting test failures on tests/inspection/test_info.py, but I'm
taking for granted it's because I don't have the right version.

--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
⠈⠳⣄


--QeJbQBOUnoJcbwcxNVRjqpvk9fPKMo2Th--

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQTKp0AHB6gWsCAvw830JXpQshz6hQUCYN+SawAKCRD0JXpQshz6 hQDRAP0Y5dQtK4a30ye7hTIJSjATSocgvQhG7Ws2HlXfydo2hAEA5JDAB7SeA3SU QUBahGAArxcrldi7VNfmk2Q6507Btw4=
=/56i
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hello!!!

I just push some updates to salsa


Here are my comments:

1. d/control:

You haven't set the Python Team either in Maintainer or Uploaders.

Ready my bad! Also I note that some dependencies that I package for Poetry

were uploaded and DPT was not the Maintainer, I'll change those.

---------------------------------------------------------------------

2. d/control:

If you require specific dependencies, you should make it clear in
d/control. It's the kind of thing that helps a lot if people decide to backport it.

Ready

---------------------------------------------------------------------

3. tests/repositories/fixtures

This directory contains a bunch of tarballs from other projects. I'm not
sure what should be done with this, as I guess they are used in the testsuite....

My first reflex would be to exclude them from the imported tarball and disable the tests that require them, but I don't know how much of the testsuite depends on those tarballs.

Maybe someone else from the team can chime-in?

I will look at that these days. I can try to remove them and "turn off"

the test
that uses the tarballs. Some days ago, I started to look at the pypy
package,
and it has the suittest in another package (btw, that is new for me).
Maybe poetry can have that approach? Also, I don't know if that makes sense.

---------------------------------------------------------------------

4. d/tests

There are no autopkgtests. This being a large project that's kinda hard
to package, I don't really mind for now.

I think it's fair to wait to have at least 1 version in unstable before working on that.

yes, that was my idea.

---------------------------------------------------------------------

5. d/rules

Isn't the step in execute_after_dh_auto_install better suited in execute_after_dh_clean instead? At least, it seems to me you're cleaning
the ./foo dir you patched in.

yes you're right, that makes more sense, thanks!

---------------------------------------------------------------------

6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry

Again, not something that needs to be fixed, but each subcommand of
poetry should probably get a man page:

https://python-poetry.org/docs/cli/

I looked at the code and I have no idea how this website is built (they
don't use sphinx). It seems like they do something manual?

https://github.com/python-poetry/poetry/issues/3382

Anyway, here's an example of how I added man pages to a program with
multiple commands:

https://github.com/spl0k/supysonic/tree/master/docs/man

thanks for note it, I'll take a look these days.

---------------------------------------------------------------------

Overall it's very good! The trickiest part to fix will likely be #3 :S

I need to skip some tests because use a non versioned python, so that
give me some troubles like "python don't exist".

Also, there're some package (or package version) that aren't in Debian
yet. So, to save your time looking which are them I tell you that I run
the buildpackage in this way:

```

gbp buildpackage --git-ignore-new

--extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb

--extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb

--extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb

This package has not been updated on Salsa, or at least, I couldn't find version 1.7.0-1 anywhere. Maybe you forgot to push?

Oh yes, I'm just psuh to salsa. Sorry!

Cheers!
Emmanuel

<div dir="ltr"><div>Hello!!!</div><div><br></div><div>I just push some updates to salsa<br></div><br><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Here are my comments:<br>

1. d/control:<br>

You haven&#39;t set the Python Team either in Maintainer or Uploaders.<br> <br></blockquote><div>Ready my bad! Also I note that some dependencies that I package for Poetry</div><div>were uploaded and DPT was not the Maintainer, I&#39;ll change those.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;
border-left:1px solid rgb(204,204,204);padding-left:1ex"> ---------------------------------------------------------------------<br>

2. d/control:<br>

If you require specific dependencies, you should make it clear in<br> d/control. It&#39;s the kind of thing that helps a lot if people decide to<br> backport it.<br>
<br></blockquote><div>Ready <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---------------------------------------------------------------------<br>

3. tests/repositories/fixtures<br>

This directory contains a bunch of tarballs from other projects. I&#39;m not<br>
sure what should be done with this, as I guess they are used in the<br> testsuite....<br>

My first reflex would be to exclude them from the imported tarball and<br> disable the tests that require them, but I don&#39;t know how much of the<br> testsuite depends on those tarballs.<br>

Maybe someone else from the team can chime-in?<br>
<br></blockquote><div>I will look at that these days. I can try to remove them and &quot;turn off&quot; the test</div><div>that uses the tarballs.  Some days ago, I started to look at the pypy package,</div><div>and it has the suittest in another
package (btw, that is new for me).</div><div>Maybe poetry can have that approach? Also, I don&#39;t know if that makes sense.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"

---------------------------------------------------------------------<br>

4. d/tests<br>

There are no autopkgtests. This being a large project that&#39;s kinda hard<br> to package, I don&#39;t really mind for now.<br>

I think it&#39;s fair to wait to have at least 1 version in unstable before<br> working on that.<br></blockquote><div>yes, that was my idea.  <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

---------------------------------------------------------------------<br>

5. d/rules<br>

Isn&#39;t the step in execute_after_dh_auto_install better suited in<br> execute_after_dh_clean instead? At least, it seems to me you&#39;re cleaning<br>
the ./foo dir you patched in.<br>
<br></blockquote><div>yes you&#39;re right, that makes more sense, thanks!<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---------------------------------------------------------------------<br>

6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry<br>

Again, not something that needs to be fixed, but each subcommand of<br>
poetry should probably get a man page:<br>

<a href="https://python-poetry.org/docs/cli/" rel="noreferrer" target="_blank">https://python-poetry.org/docs/cli/</a><br>

I looked at the code and I have no idea how this website is built (they<br> don&#39;t use sphinx). It seems like they do something manual?<br>

<a href="https://github.com/python-poetry/poetry/issues/3382" rel="noreferrer" target="_blank">https://github.com/python-poetry/poetry/issues/3382</a><br>

Anyway, here&#39;s an example of how I added man pages to a program with<br> multiple commands:<br>

<a href="https://github.com/spl0k/supysonic/tree/master/docs/man" rel="noreferrer" target="_blank">https://github.com/spl0k/supysonic/tree/master/docs/man</a><br>
<br></blockquote><div><br></div><div>thanks for note it, I&#39;ll take a look these days. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---------------------------------------------------------------------<br>

Overall it&#39;s very good! The trickiest part to fix will likely be #3 :S<br>

&gt; I need to skip some tests because use a non versioned python, so that<br> &gt; give me some troubles like &quot;python don&#39;t exist&quot;.<br>
&gt; <br>
&gt; Also, there&#39;re some package (or package version) that aren&#39;t in Debian<br>
&gt; yet. So, to save your time looking which are them I tell you that I run<br>
&gt; the buildpackage in this way:<br>
&gt; <br>
&gt; ```<br>
&gt; <br>
&gt; gbp buildpackage --git-ignore-new<br>
&gt; --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb<br>
&gt; --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb<br>
&gt; --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb<br>

This package has not been updated on Salsa, or at least, I couldn&#39;t find<br>
version 1.7.0-1 anywhere. Maybe you forgot to push?<br> <br></blockquote><div>Oh yes, I&#39;m just psuh to salsa. Sorry!</div><div><br> </div><div><br></div><div>Cheers!</div><div>Emmanuel<br></div></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:

[5] Some of the error messages from latest package source:

short test summary info ============================ ====================================================
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s --------------------------------------------------------------------- <message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ========== ====================================================================== dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2

Yes, one test fails with 3.10 which isn't unexpected because the package
wasn't tested with it.

--
WBR, wRAR

-----BEGIN PGP SIGNATURE-----

iQJhBAABCgBLFiEEolIP6gqGcKZh3YxVM2L3AxpJkuEFAmGXwIctFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3Jnd3JhckBkZWJpYW4ub3JnAAoJEDNi9wMaSZLh rgUP/izRX8V0CgP2tYHVwgPELlNIVZO77zaBwxUOEdC57TBikLLhAiBF8HVpghoY RJOBVkUKUT6pilb7o4PWx11W7w8kP7x1ZvtqzmRTEZkItnxaElFbl1gN4DyfQ8Nf Q1NSNq+UuXJWQilXt2CU6bz5TLthmdg9rZl2+nHwMbEmxqfQcIsYmhM8tG8g1UH8 WAr2+q5YAzecMAu4WG1lczWA9MHy46QrAA1kQ9PD9jj5TxhT40J0dcOIjPJt61qx V6PFNUh7grY9LCOqJjPW87YflnzU1zCz2ub6F2zB1bczU9wGVP7vDrhSz9LuREL9 bkwaCuCbNDo6w+H/F2lGBrsfV5RWfn4Gi0XXKol3xjaz4acCEo+mqOPzYl6Joi9v d4ckvwZHNqNqeALImJSCf/KRsqRdvF49rTUO7geUxy7myINB2UUTqDzLtcsjoI+R 6btH9UhcYkMi60TBbrg6jHkuzCuuldQLhZuUBoSUypTHqlIj7MyCSGl/iJFNO372 AiSpySn09thHvomjy4pKp4t0tmoNXDylDzrsBdfo7iCzbDJ9z00Sm4SC5X5kJ2+J R34o7wtpt909CmiSH/0LivkEd5wnSfgy+vtOBQPFUgDXvdJThu29HAuzM8WEYB+W AvJlrH7QZdtqZ/AJ7UsWTgtfQYa0wsqWDkZPFXj39nORPeKG
=WxhN
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Andrey,

Thank you for your information. I will have a look at the failure. If
anyone has been working on this error, it would be appreciated to let me
know how I can help.

Besides, I found this thread https://lists.debian.org/debian-python/2021/11/msg00025.html soon after I
sent out my previous email. I believe I have followed up the latest process
and status of poetry packaging for now. My apologies for not checking the
email threads carefully enough.

-tai

On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin <wrar@debian.org> wrote:

On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:

[5] Some of the error messages from latest package source:

short test summary info ============================ ====================================================
FAILED

tests/inspection/test_info.py::test_info_setup_complex_pep517_error

- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s --------------------------------------------------------------------- <message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ========== ====================================================================== dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Yes, one test fails with 3.10 which isn't unexpected because the package wasn't tested with it.

--
WBR, wRAR

<div dir="ltr">Hi Andrey,<div><br></div><div>Thank you for your information. I will have a look at the failure. If anyone has been working on this error, it would be appreciated to let me know how I can help.</div><div><br></div><div>Besides, I found
this thread <a href="https://lists.debian.org/debian-python/2021/11/msg00025.html">https://lists.debian.org/debian-python/2021/11/msg00025.html</a> soon after I sent out my previous email. I believe I have followed up the latest process and status of
poetry packaging for now. My apologies for not checking the email threads carefully enough.</div><div><br></div><div>-tai</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin &lt;<a
href="mailto:wrar@debian.org">wrar@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (
tai271828) wrote:<br>
&gt; [5] Some of the error messages from latest package source:<br>
&gt; <br>
&gt; short test summary info ============================<br>
&gt; ====================================================<br>
&gt; FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error<br>
&gt; - ...<br>
&gt; 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s<br> &gt; ---------------------------------------------------------------------<br> &gt; &lt;message skipped&gt;<br>
&gt; 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========<br> &gt; ======================================================================<br> &gt; dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p<br>
&gt; &quot;3.10 3.9&quot; returned exit code 13<br>
&gt; make: *** [debian/rules:44: binary] Error 25<br>
&gt; <br>
&gt; dpkg-buildpackage: error: debian/rules binary subprocess returned exit<br> &gt; status 2<br>
Yes, one test fails with 3.10 which isn&#39;t unexpected because the package<br>
wasn&#39;t tested with it.<br>

-- <br>
WBR, wRAR<br>
</blockquote></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Emmanuel,

I failed to build the poetry deb with the latest package source[1] for some pytest cases[4][5] since I was aware of this thread https://lists.debian.org/debian-python/2021/06/msg00017.html . Do you
suggest where I should report or record the error messages I found?

By following my build steps[2] I could:

- successfully build the source with the commit "Initial review pass for python-poetry package"[3]
- fail to build the source with the commit "ignore tests that use tar.gz
file instead of skip them"[4]
- fail to build the latest source[1][5]


Would you mind elaborating a bit more regarding the packaging steps or the current packaging status? I walked through the mailing list and the latest update I found is this email https://lists.debian.org/debian-python/2021/08/msg00025.html thread. It
must be me not following the latest status and missing some necessary information.

I will try to fix these pytest errors during package building. It would be
much appreciated that you could let me know if you are aware of anything
that I should know for fixing these errors or regarding the packaging
status. Thank you!


[1] git clone git@salsa.debian.org:python-team/packages/poetry.git

[2] (build environment: ubuntu 20.04 on amd64)
1. Use this script to prepare the build environment https://gitlab.com/tai271828/tool-box/-/blob/dev/scripts/prepare-deb-build-poetry.sh
2. gbp buildpackage --git-ignore-new --git-builder=sbuild --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-cleo_0.8.1-2_all.deb
--extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-httpretty_1.1.4-1_all.deb
--extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-pkginfo_1.4.2-3_all.deb

[3] The source of the commit 92c24884d3d1a67fa5de490520d1baf83dc208bf . Besides, I performed a quick test of the deb I built by installing it on
Sid and trying some basic commands like "poetry init" and "poetry shell".
The basic function behaviors expectedly.

[4] The source of the commit c20a910ab5ca679a362f762f5c317ca3af0e0989 and
some of the error messages:

short test summary info
=======================
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert ['L...
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
- ...
FAILED tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages

### 3 failed, 576 passed, 5 skipped, 21 deselected, 15 warnings in 25.73s <message skipped>
short test summary info ============================ ====================================================
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert ['L...
FAILED tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages

2 failed, 577 passed, 5 skipped, 21 deselected, 14 warnings in 24.09s ---------------------------------------------------------------------
<message skipped>
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:41: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2


[5] Some of the error messages from latest package source:

short test summary info ============================ ====================================================
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s ---------------------------------------------------------------------
<message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ========== ====================================================================== dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2


Kind regards,
Tai

<div dir="ltr">Hi Emmanuel,<br><br>I failed to build the poetry deb with the latest package source[1] for some pytest cases[4][5] since I was aware of this thread <a href="https://lists.debian.org/debian-python/2021/06/msg00017.html">https://lists.debian.
org/debian-python/2021/06/msg00017.html</a> . Do you suggest where I should report or record the error messages I found?<br><br>By following my build steps[2] I could:<br><blockquote style="margin:0 0 0 40px;border:none;padding:0px"> - successfully build
the source with the commit &quot;Initial review pass for python-poetry package&quot;[3]<br> - fail to build the source with the commit &quot;ignore tests that use tar.gz file instead of skip them&quot;[4]<br> - fail to build the latest source[1][5]</
blockquote><br>Would you mind elaborating a bit more regarding the packaging steps or the current packaging status? I walked through the mailing list and the latest update I found is this email <a href="https://lists.debian.org/debian-python/2021/08/
msg00025.html">https://lists.debian.org/debian-python/2021/08/msg00025.html</a> thread. It must be me not following the latest status and missing some necessary information.<br><br>I will try to fix these pytest errors during package building. It would
be much appreciated that you could let me know if you are aware of anything that I should know for fixing these errors or regarding the packaging status. Thank you!<br><br><br>[1] git clone git@salsa.debian.org:python-team/packages/poetry.git<br><br>[2] �
�(build environment: ubuntu 20.04 on amd64)<br>1. Use this script to prepare the build environment <a href="https://gitlab.com/tai271828/tool-box/-/blob/dev/scripts/prepare-deb-build-poetry.sh">https://gitlab.com/tai271828/tool-box/-/blob/dev/scripts/
prepare-deb-build-poetry.sh</a><br>2. gbp buildpackage --git-ignore-new --git-builder=sbuild --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-cleo_0.8.1-2_all.deb --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-
httpretty_1.1.4-1_all.deb --extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-pkginfo_1.4.2-3_all.deb<div><br>[3] The source of the commit 92c24884d3d1a67fa5de490520d1baf83dc208bf . Besides, I performed a quick test of the deb I built by
installing it on Sid and trying some basic commands like &quot;poetry init&quot; and &quot;poetry shell&quot;. The basic function behaviors expectedly.<br><br>[4] The source of the commit c20a910ab5ca679a362f762f5c317ca3af0e0989 and some of the error
messages:<br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>short test summary info</div><div>=======================</div><div>FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert [&#39;L...           �
�                         </div><div>FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error - ...                                     </div><div>FAILED tests/masonry/builders/test_editable_builder.py::
test_builder_installs_proper_files_for_standard_packages     </div><div>### 3 failed, 576 passed, 5 skipped, 21 deselected, 15 warnings in 25.73s</div><div>&lt;message skipped&gt;</div><div>short test summary info ============================</div><div>
====================================================</div><div>FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert [&#39;L...                                     </div><div>FAILED tests/masonry/builders/test_
editable_builder.py::test_builder_installs_proper_files_for_standard_packages     </div><div>2 failed, 577 passed, 5 skipped, 21 deselected, 14 warnings in 24.09s</div><div>---------------------------------------------------------------------</div><div>
&lt;message skipped&gt;</div><div>dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p &quot;3.10 3.9&quot; returned exit code 13             </div><div>make: *** [debian/rules:41: binary] Error 25                      
                                                  </div><div>dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 </div></blockquote><div><br>[5] Some of the error messages from latest package source:<

</div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>short test summary info ============================</div><div>====================================================</div><div>FAILED tests/inspection/test_info.py::test_info_

setup_complex_pep517_error - ...                                     </div><div>1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s</div><div>---------------------------------------------------------------------</div><

&lt;message skipped&gt;</div><div>588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========</div><div>======================================================================</div><div>dh_auto_test: error: pybuild --test --test-pytest -i

python{version} -p &quot;3.10 3.9&quot; returned exit code 13             </div><div>make: *** [debian/rules:44: binary] Error 25                                                                         </div><div>
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2</div></blockquote><div><br>Kind regards,<br>Tai<br></div></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Tai,

First of all thanks for the mail, and for the work in the poetry package.
Very
detailed mail, amazing :)

As mentioned Andrey, yes there's a test that failed with py3.10. The
package is
already in NEW, so we need to wait. In spite of this we can work to fix it.
I didn't investigate yet, So feel free to send a patch if you have one :).

For point [2] , call gbp with the b-depends are no longer needed, because
all of them
are already in Debian.

Cheers,
Emmanuel

On Fri, Nov 19, 2021 at 12:36 PM Taihsiang Ho (tai271828) <e@tai271828.me> wrote:

Hi Andrey,

Thank you for your information. I will have a look at the failure. If
anyone has been working on this error, it would be appreciated to let me
know how I can help.

Besides, I found this thread https://lists.debian.org/debian-python/2021/11/msg00025.html soon after I sent out my previous email. I believe I have followed up the latest process and status of poetry packaging for now. My apologies for not checking the email threads carefully enough.

-tai

On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin <wrar@debian.org>
wrote:

On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:

[5] Some of the error messages from latest package source:

short test summary info ============================
====================================================
FAILED

tests/inspection/test_info.py::test_info_setup_complex_pep517_error

- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
---------------------------------------------------------------------
<message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========
======================================================================
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2

Yes, one test fails with 3.10 which isn't unexpected because the package
wasn't tested with it.

--
WBR, wRAR

<div dir="ltr">Hi Tai, <div><br></div><div>First of all thanks for the mail, and for the work in the poetry package. Very</div><div>detailed mail, amazing  :) </div><div><br></div><div>As mentioned Andrey, yes there&#39;s a test that failed with py3.
10. The package is</div><div>already in NEW, so we need to wait. In spite of this we can work to fix it. </div><div>I didn&#39;t investigate yet, So feel free to send a patch if you have one :).</div><div><br></div><div>For point [2] , call gbp with
the b-depends are no longer needed, because all of them</div><div>are already in Debian. </div><div><br></div><div>Cheers, </div><div>Emmanuel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 12:36 PM
Taihsiang Ho (tai271828) &lt;<a href="mailto:e@tai271828.me">e@tai271828.me</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Andrey,<div><br>
</div><div>Thank you for your information. I will have a look at the failure. If anyone has been working on this error, it would be appreciated to let me know how I can help.</div><div><br></div><div>Besides, I found this thread <a href="https://lists.
debian.org/debian-python/2021/11/msg00025.html" target="_blank">https://lists.debian.org/debian-python/2021/11/msg00025.html</a> soon after I sent out my previous email. I believe I have followed up the latest process and status of poetry packaging for
now. My apologies for not checking the email threads carefully enough.</div><div><br></div><div>-tai</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin &lt;<a href="mailto:wrar@
debian.org" target="_blank">wrar@debian.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828)
wrote:<br>
&gt; [5] Some of the error messages from latest package source:<br>
&gt; <br>
&gt; short test summary info ============================<br>
&gt; ====================================================<br>
&gt; FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error<br>
&gt; - ...<br>
&gt; 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s<br> &gt; ---------------------------------------------------------------------<br> &gt; &lt;message skipped&gt;<br>
&gt; 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========<br> &gt; ======================================================================<br> &gt; dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p<br>
&gt; &quot;3.10 3.9&quot; returned exit code 13<br>
&gt; make: *** [debian/rules:44: binary] Error 25<br>
&gt; <br>
&gt; dpkg-buildpackage: error: debian/rules binary subprocess returned exit<br> &gt; status 2<br>
Yes, one test fails with 3.10 which isn&#39;t unexpected because the package<br>
wasn&#39;t tested with it.<br>

-- <br>
WBR, wRAR<br>
</blockquote></div>
</blockquote></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Emmanuel,

Thank you for your tip : )

Cheers,
Ta

On Fri, Nov 19, 2021 at 9:39 PM Emmanuel Arias <eamanu@yaerobi.com> wrote:

Hi Tai,

First of all thanks for the mail, and for the work in the poetry package. Very
detailed mail, amazing :)

As mentioned Andrey, yes there's a test that failed with py3.10. The
package is
already in NEW, so we need to wait. In spite of this we can work to fix
it.
I didn't investigate yet, So feel free to send a patch if you have one :).

For point [2] , call gbp with the b-depends are no longer needed, because
all of them
are already in Debian.

Cheers,
Emmanuel

On Fri, Nov 19, 2021 at 12:36 PM Taihsiang Ho (tai271828) <e@tai271828.me> wrote:

Hi Andrey,

Thank you for your information. I will have a look at the failure. If
anyone has been working on this error, it would be appreciated to let me
know how I can help.

Besides, I found this thread
https://lists.debian.org/debian-python/2021/11/msg00025.html soon after
I sent out my previous email. I believe I have followed up the latest
process and status of poetry packaging for now. My apologies for not
checking the email threads carefully enough.

-tai

On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin <wrar@debian.org>
wrote:

On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote: >>> > [5] Some of the error messages from latest package source:

short test summary info ============================
====================================================
FAILED

tests/inspection/test_info.py::test_info_setup_complex_pep517_error

- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
---------------------------------------------------------------------
<message skipped>
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ========== >>> > ====================================================================== >>> > dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p >>> > "3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit >>> > status 2

Yes, one test fails with 3.10 which isn't unexpected because the package >>> wasn't tested with it.

--
WBR, wRAR

<div dir="ltr">Hi Emmanuel,<div><br></div><div>Thank you for your tip : )</div><div><br></div><div>Cheers,</div><div>Ta</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 9:39 PM Emmanuel Arias &lt;<a href="
mailto:eamanu@yaerobi.com">eamanu@yaerobi.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Tai, <div><br></div><div>First of all thanks
for the mail, and for the work in the poetry package. Very</div><div>detailed mail, amazing  :) </div><div><br></div><div>As mentioned Andrey, yes there&#39;s a test that failed with py3.10. The package is</div><div>already in NEW, so we need to wait.
In spite of this we can work to fix it. </div><div>I didn&#39;t investigate yet, So feel free to send a patch if you have one :).</div><div><br></div><div>For point [2] , call gbp with the b-depends are no longer needed, because all of them</div><div>
are already in Debian. </div><div><br></div><div>Cheers, </div><div>Emmanuel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 12:36 PM Taihsiang Ho (tai271828) &lt;<a href="mailto:e@tai271828.me" target="
_blank">e@tai271828.me</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Andrey,<div><br></div><div>Thank you for your information. I will
have a look at the failure. If anyone has been working on this error, it would be appreciated to let me know how I can help.</div><div><br></div><div>Besides, I found this thread <a href="https://lists.debian.org/debian-python/2021/11/msg00025.html"
target="_blank">https://lists.debian.org/debian-python/2021/11/msg00025.html</a> soon after I sent out my previous email. I believe I have followed up the latest process and status of poetry packaging for now. My apologies for not checking the email
threads carefully enough.</div><div><br></div><div>-tai</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin &lt;<a href="mailto:wrar@debian.org" target="_blank">wrar@debian.org</a>&
gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:<br>
&gt; [5] Some of the error messages from latest package source:<br>
&gt; <br>
&gt; short test summary info ============================<br>
&gt; ====================================================<br>
&gt; FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error<br>
&gt; - ...<br>
&gt; 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s<br> &gt; ---------------------------------------------------------------------<br> &gt; &lt;message skipped&gt;<br>
&gt; 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==========<br> &gt; ======================================================================<br> &gt; dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p<br>
&gt; &quot;3.10 3.9&quot; returned exit code 13<br>
&gt; make: *** [debian/rules:44: binary] Error 25<br>
&gt; <br>
&gt; dpkg-buildpackage: error: debian/rules binary subprocess returned exit<br> &gt; status 2<br>
Yes, one test fails with 3.10 which isn&#39;t unexpected because the package<br>
wasn&#39;t tested with it.<br>

-- <br>
WBR, wRAR<br>
</blockquote></div>
</blockquote></div>
</blockquote></div>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)