• request for review: python-pyglfw

    From =?utf-8?Q?=C3=89tienne?= Mollier@21:1/5 to All on Sun Dec 4 12:50:01 2022
    Hi,

    I'm a DD, but since this is my first DPT package, I wouldn't be
    against having a second pair of eyeballs having a look at the
    python-pyglfw package I produced this morning[1]. The packaging
    in itself was super smooth, I just wanted to make sure I didn't
    miss team specific bits; I had the policy and guide under the
    eyes while packaging, but one never knows.

    [1]: https://salsa.debian.org/python-team/packages/python-pyglfw

    Have a nice day, :)
    --
    Étienne Mollier <emollier@emlwks999.eu>
    Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
    Sent from /dev/pts/2, please excuse my verbosity.
    On air: The Tangent - The World We Drive Through

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmOMiH4ACgkQeTz2fo8N EdqQAQ//dUQaXctXGN4n24HTc3v/4FwQYUIrOxXR9OJxE4SNculKGqelO3+fU323 MI9aKQKIMXOXmsUg70i9VCYJYrzybyvxrPTqkBt5ovF6+3brtFckMKBPMhsSpHu4 fV+70Ub5SDzcWhMpyNvXCicb2EiiBE2qKBwe+vF6v9TJrE4LEk43DP82CWs+ssFU paMuATIXGOdxBNT1cetiEQ/xD7nxSwhKYqi5nA+vNcFS7yNFuc52KrsgyuJ+Bgnf rKjblmjDA7xSZ08gmqjOFq7rEImlH8EQD2nEuKU7DRlCNs88XF2vtk8ZogJ/B9nK ok8vsSENidUCWypMCmYhwIgHTE94fwIwO9MDwJPx4kapoljK9izSrZLgpAJsJICE 9H3VMClBBVioOawgI8NO4QLdF5do5tqZLSdsDVTG3N8r3VbZSNifxZHjCxV7m9e0 AYcpNUGfnduahlxuj5CfQIwe9Dbe1VkD28qTlJVakzrOd2as/kOihfflYvt0C7k+ Wz7ARpTWvW641GAxAOXRSVTAJee5cprRKOynLL3I1kjRWP3RTTXhm3u3Yz91mpoR ZJDzpHBz+EqlXF/Dc9es0v3gT6ubv+EgtX19VNMwBbM+rzuicXB5Ar8nvTlZeneY rbAjuUxZT0k3NPP1PAnMqcOXL5xYEgapXwhK1P+V0ryxMK0lW
  • From Timo =?utf-8?Q?R=C3=B6hling?=@21:1/5 to All on Sun Dec 4 14:30:01 2022
    Hi Étienne,

    * Étienne Mollier <emollier@emlwks999.eu> [2022-12-04 12:46]:
    I'm a DD, but since this is my first DPT package, I wouldn't be
    against having a second pair of eyeballs having a look at the
    python-pyglfw package I produced this morning[1]. The packaging
    in itself was super smooth, I just wanted to make sure I didn't
    miss team specific bits; I had the policy and guide under the
    eyes while packaging, but one never knows.

    [1]: https://salsa.debian.org/python-team/packages/python-pyglfw
    - You forgot to push the upstream and pristine-tar branches, the
    upstream/2.5.5+dfsg tag, and you should set
    "debian-branch = debian/master" in d/gbp.conf

    - I think the package can be arch:all, as the package will be
    identical an all architectures, with all architecture-specific
    bits hidden behind the ctypes indirection.

    - The "Build-Depends: libglfw3 <!nocheck>" seems unnecessary, because
    AFAICT, there is no test suite in the package at all.

    - There is no "Testsuite: autopkgtest-pkg-python" in d/control. I'm
    really not sure if this is an issue, because I usually have more
    intrusive tests and seldomly rely on the default one. Besides, you
    did add a config in d/tests, which may also suffice? I really
    don't know, but wanted to mention it just in case.

    - I've never set LC_ALL in d/rules. Is there a particular reason
    why it is necessary?

    - Personally, I prefer having dh-sequence-python3 in Build-Depends,
    so I don't have to add --with python3 in d/rules.

    Everything else looks good to me, with the caveat that I did not
    actually test-build the package, because of the missing pushes.

    Oh, and welcome to the team, nice to have you here!


    Cheers
    Timo


    --
    ⢀⣴⠾⠻⢶⣦⠀ ╭────────────────────────────────────────────────────╮
    ⣾⠁⢠⠒⠀⣿⡁ │ Timo Röhling │
    ⢿⡄⠘⠷⠚⠋⠀ │ 9B03 EBB9 8300 DF97 C2B1 23BF CC8C 6BDD 1403 F4CA │
    ⠈⠳⣄⠀⠀⠀⠀ ╰────────────────────────────────────────────────────╯

    -----BEGIN PGP SIGNATURE-----

    iQGzBAEBCgAdFiEEJvtDgpxjkjCIVtam+C8H+466LVkFAmOMn7cACgkQ+C8H+466 LVl2PQv8DkxvsC1dswpH5XnmhILgNAZ3G/sDjMOK7/HdlaeZD2w/2XRNrLRXKQVS Kkfg/9hTy+Prrm/6mXRXewnHfTvCPtcpuiklIGkCk7q3kxk4R16xmw9hzLNFv/MJ nW/MnpQ7UH2Y4rvkmI8v4CWcJwPi3KLKdtI93F0kuLQ99zjadFz1pq9aHZCLCtcs m+xohSQs6jfU9sZCaH/StbIGQ/h/bgWebeFr1dmlCo5WCLamoKm6lxDxf8K1TL80 sSKHx1VK3mb8ioP237oFKjCV4daXveojMmCDLgE0hAstyP8a0dI9KxlcZzH11JIQ bKFhKhZKJzwt2Bvmf7J3rcTX5wSo0hs3UWveeI1zfBl
  • From =?utf-8?Q?=C3=89tienne?= Mollier@21:1/5 to All on Sun Dec 4 15:50:01 2022
    Hi Timo,

    Timo Röhling, on 2022-12-04:
    * Étienne Mollier <emollier@emlwks999.eu> [2022-12-04 12:46]:
    I'm a DD, but since this is my first DPT package, I wouldn't be
    against having a second pair of eyeballs having a look at the
    python-pyglfw package I produced this morning[1]. The packaging
    in itself was super smooth, I just wanted to make sure I didn't
    miss team specific bits; I had the policy and guide under the
    eyes while packaging, but one never knows.

    [1]: https://salsa.debian.org/python-team/packages/python-pyglfw
    - You forgot to push the upstream and pristine-tar branches, the
    upstream/2.5.5+dfsg tag, and you should set
    "debian-branch = debian/master" in d/gbp.conf

    Ack, these look like an oversight of mine. These should be
    fixed now. Sorry for the mess.

    - I think the package can be arch:all, as the package will be
    identical an all architectures, with all architecture-specific
    bits hidden behind the ctypes indirection.

    Ack, I did some further testing, and it seems to be fine to move
    to arch all, unless I missed a bit.

    - The "Build-Depends: libglfw3 <!nocheck>" seems unnecessary, because
    AFAICT, there is no test suite in the package at all.

    If I remove it, the test scanner seems to catch something which
    in turn fails to load the module:

    I: pybuild base:240: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build; python3.11 -m unittest discover -v
    glfw (unittest.loader._FailedTest.glfw) ... ERROR

    ======================================================================
    ERROR: glfw (unittest.loader._FailedTest.glfw)
    ----------------------------------------------------------------------
    ImportError: Failed to import test module: glfw
    Traceback (most recent call last):
    File "/usr/lib/python3.11/unittest/loader.py", line 440, in _find_test_path
    package = self._get_module_from_name(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/lib/python3.11/unittest/loader.py", line 350, in _get_module_from_name
    __import__(name)
    File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11/build/glfw/__init__.py", line 43, in <module>
    raise ImportError("Failed to load GLFW3 shared library.")
    ImportError: Failed to load GLFW3 shared library.

    In doubt, I'll keep the test dependency for now. For some
    reason, I still witness this error in spite of the library
    installed on riscv64, but arm64 build went alright; there might
    be something wrong with the dependency.

    - There is no "Testsuite: autopkgtest-pkg-python" in d/control. I'm
    really not sure if this is an issue, because I usually have more
    intrusive tests and seldomly rely on the default one. Besides, you
    did add a config in d/tests, which may also suffice? I really
    don't know, but wanted to mention it just in case.

    I forcefully run it when running sbuild, so I tend to forget to
    append it. I have a more in-depth test in preparation, but it's
    commented out due to #1025312. Anyway, I added the necessary
    statement to d/control, shouldn't hurt.

    - I've never set LC_ALL in d/rules. Is there a particular reason
    why it is necessary?

    That's a safety precaution for reproducible builds, when some
    artifacts are locale dependent. This may not be 100% necessary
    in the present case, but I tend to keep it around just in case.

    - Personally, I prefer having dh-sequence-python3 in Build-Depends,
    so I don't have to add --with python3 in d/rules.

    I was not aware of that (or just overheard it exists), I give it
    a try. Thanks!

    Everything else looks good to me, with the caveat that I did not
    actually test-build the package, because of the missing pushes.

    Oh, and welcome to the team, nice to have you here!

    Thanks for your time and the warm welcome! :)

    Have a nice day, :)
    --
    Étienne Mollier <emollier@emlwks999.eu>
    Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
    Sent from /dev/pts/2, please excuse my verbosity.

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmOMsxIACgkQeTz2fo8N EdrEUw/6Ai+92DlTnMOr757Rr1Q8nTtT4Eq/WM5kWsrxmHzTLvb2w8qyxjBvb/iU eJ1q19zAsntvDBlfcyxx4YHGz+kgVkPzHN+Un1xLY7pdcnlM98NDhS/axT8YefUq ghm33L5zFHmuBFie33iuSkA+pLAXseVlVL5mTTKd3YZPx1TyN0WTICpdQ0KnBXQG pHGxNRSCdsX3L+NN8KBd3ab7ja/f3z7O0iH5ngDIFLZB7BQ45Wi/KGjNuCQ5PqBc mXAolDksd2xFSSzvRRS29bcGYCikSRO/MUnvBcezT7tXBokjCcEMGGplqr+igVcR Dppqc8xP9XfxFID2k05COZBTIbA9aW1q4I2yrm7J4YAfsuIuuK01NnudMJA0asYQ iRWduXjh4EOlRty9U/aJZv6YQCyriPmtRW3taE8OyzPfb0lPhc1qiAIOKb59cSxN IbWBKiOfwsRxY+4P3lMEZvFK9leYV0+73uz1v5uFylZfmC451NAU5W+vNwonfPvH gd7KOfN0OblOSIOLfWntGqPT4hIaubIbtI3yyrJIYG7mkfwXkYZGeE+RSuyLs2Yf vFYHeUFk9p4LTzx5Iumf7kdqrXEoG8CLl/uS00fS8/OPqODsiZdEnJRc+yyIeBUo I0VsWRO6iKqU8QMdbZ/yvsqN4arz14vychaAapua//rbEFFXk6A=
    =pvLJ
    -----END PGP SIGNATURE-----

    --- Sou