Hello,

This is my review of the lazy-loader package you asked the Debian Python
Team to sponsor in the Debian archive.

1. In d/control, I'm not sure to understand why the binary package is
marked as "Multi-Arch: foreign", as this package isn't arch dependent?

2. In d/control, your list of build-dependencies for the source package
should be reviewed.

* Why do you need 'python3-setuptools' when this package uses flit?
* Why the dependency on 'python3-toml'?
* You should build-depend on 'pybuild-plugin-pyproject', as this is a
PEP517 compatible package. The 'old' flit plugin for pybuild is being deprecated in favor of this one.
* since 'python3-pytest' is only used for tests, it should be marked as
so using <!nocheck>

3. In d/control, although Stefan van der Walt is the author, the
copyright should only be "Scientific Python project", as that's the only licensing information in this package.

4. There are many commented lines in d/rules that should just be
removed. Note that you do not need 'export DH_VERBOSE = 1' nor 'export PYBUILD_SYSTEM=flit' (since you'll now build with
'pybuild-plugin-pyproject')

5. The autopkgtests you are running in d/tests are redundant. autodep8
already does this for python.

You should instead run the upstream test suite as autopkgtests: they are
much more meaningful.

Have a look at this example:

https://salsa.debian.org/python-team/packages/metalfinder/-/tree/debian/master/debian/tests

6. In d/changelog, you marked your entry as "unstable", whereas it
should be UNRELEASED. Please re-read the DPT's policy with regards to this.

7. Although I have not listed them here, pretty much all of the lintian
tags raised are relevant errors that you should fix.

----------------------------------

You're 90% there!

I've removed your package from the sponsor queue for now, but feel free
to re-add it when you feel like you've dealt with my review. I'll be
happy to sponsor it then.

Thanks for your contribution to Debian.

--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau
⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org
⠈⠳⣄

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi,
On Fri, Oct 21, 2022 at 11:58:38PM -0400, Louis-Philippe V�ronneau wrote: >Hello,

This is my review of the lazy-loader package you asked the Debian
Python Team to sponsor in the Debian archive.

1. In d/control, I'm not sure to understand why the binary package is
marked as "Multi-Arch: foreign", as this package isn't arch dependent?

The binary package is arch dependent as it was marked as "Architecture: all"
I think. There is more knowledge for me to here: https://wiki.debian.org/MultiArch/Hints#set_Multi-Arch:_foreign

Fixed it.




[...]

You should instead run the upstream test suite as autopkgtests: they
are much more meaningful.

Have a look at this example:

https://salsa.debian.org/python-team/packages/metalfinder/-/tree/debian/master/debian/tests

Ok, The package now is updated according to the all above review comments.

6. In d/changelog, you marked your entry as "unstable", whereas it
should be UNRELEASED. Please re-read the DPT's policy with regards to
this.

Ok, this is different entry with previous package that has been
sponsored by others DD. But I think 'UNRELEASED' entry is right:)

7. Although I have not listed them here, pretty much all of the
lintian tags raised are relevant errors that you should fix.

Yeah, I run lintian the package this time and it got nothing from my
chroot build. The only error from mentor is:
```
Package uploaded for the UNRELEASED distribution
````
I think it should be ok this time.

----------------------------------

You're 90% there!

I've removed your package from the sponsor queue for now, but feel
free to re-add it when you feel like you've dealt with my review. I'll
be happy to sponsor it then.

Thanks you very much! I have updated it from your valueable review.
Please let me know if there is any issues.

--
Regards,
--
Bo YU


-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmNT3LAACgkQ+RVP3hQ+ S6/C/g/+MlHh5Q42IPQMS6/ThKqwR2bVsUrfg9aR7GNbD5NttT/CRJc6RjIrL4ab pnYHduaqXrLUH8cCYsiIyhhrzCrp6Z5owBFLMHrRs4ekwFAYjNrJkxTTL3fwd5GB 9SvcqoKd50mlNLiTkEGb0rlsjIF5AeJL7uRTlWdUgQ2A+tY7Re/b3/SvCpTPI2FW AtjNsafH7A+bmQB4M5xK1giy/L3AyPgXVXX2xhKm9p0/IPtw3v2OIGWvj7R5kD/d X1jy35GvPBag46WmD0Ryo4/gw2gYsHlYVQbrlOkvMJ8D+/jZ6n0Jugdqwlk56GO/ QNExtc0TEU0QunHWwPgpa2C2MwXGHrJNvQBUYxtnFlLGHOBOvgSSaUZ2s2QcfXE9 ZkzkXcyFHYG2HeU+yfUnaL9KR+U1AjEO724QGQdZOOg0AUMeCw++YL6Fd9dhvKxN lHo/y4oXVY3Iwf+uhj+JQT6Chi6YiigSLHXOWhS05TANpR4DqL8WIR0luvoY+WsT wO0O4EeHkRzNtdTy+U01ekCGsfiZx9AEP4Co+hS7QHQIbSVZ973F7YImZUBekPzW 5CO+1Q5q34MAlDBnm3V63bnJ5JL/lZxgsmOL8oeevb0k/m3slHqTmMvqC1MHxcMH rGgmU1VQSe14FhzvLugyckwxePUcT47D0m4X7GIP51bOtxJRhs0=
=P71E
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)