1. Forum
  2. Usenet
  3. COMP.MAIL.SENDMAIL

  • Milter "time command".

    From G.W. Haywood@21:1/5 to All on Sun Oct 24 13:43:27 2021
    A little over 20 years ago (8th September 2001, the release of 8.12.0)
    amongst other things some logging was added to .../sendmail/milter.c:

    + if (MilterLogLevel > 21)
    + tn = curtime();
    +
    response = milter_send_command(m, command, data ... );
    +
    + if (MilterLogLevel > 21)
    + {
    + /* log the time it took for the command per filter */
    + sm_syslog(LOG_INFO, e->e_id,
    + "Milter (%s): time command (%c), %d",
    + m->mf_name, command, (int) (tn - curtime()));

    The intention appears to be to log the duration of a milter call.

    The code in this area in version 8.17.1 is almost unchanged.

    There are two problems with it.

    1. If the time logged is non-zero, it will be negative.

    2. In the last 20 years things have moved on a little, and an integer
    seconds value isn't as useful as it might once have been. Less than
    20% of the values in my logs are negative, the remainder being zero.

    At first I wondered if a patch might break things for people, but now
    I reason that if nobody has worried about this for two decades, then
    that probably won't be a widespread issue.

    Would a patch to address the precision of the result - microseconds
    might be more appropriate - and its sign be welcomed? Perhaps the
    version with greater precision should be FFR.

    73,
    Ged.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Claus =?iso-8859-1?Q?A=DFmann?= @21:1/5 to G.W. Haywood on Tue Oct 26 07:19:13 2021
    G.W. Haywood wrote:

    Would a patch to address the precision of the result - microseconds
    might be more appropriate - and its sign be welcomed?

    You could just send a patch to the support address and ask.

    --
    Note: please read the netiquette before posting. I will almost never
    reply to top-postings which include a full copy of the previous
    article(s) at the end because it's annoying, shows that the poster
    is too lazy to trim his article, and it's wasting the time of all readers.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From G.W. Haywood@21:1/5 to Claus Assmann on Tue Oct 26 15:56:53 2021
    On Tue, 26 Oct 2021, Claus Assmann wrote:

    G.W. Haywood wrote:

    Would a patch to address the precision of the result - microseconds
    might be more appropriate - and its sign be welcomed?

    You could just send a patch to the support address and ask.

    Done.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Claus =?iso-8859-1?Q?A=DFmann?= @21:1/5 to G.W. Haywood on Tue Oct 26 12:24:41 2021
    G.W. Haywood wrote:
    On Tue, 26 Oct 2021, Claus Assmann wrote:

    You could just send a patch to the support address and ask.

    Done.

    rcpt=<support-2021@support.sendmail.org>,status=550 5.1.1 Recipient rejected.

    Didn't you get an error from your MUA or MTA?

    --
    Note: please read the netiquette before posting. I will almost never
    reply to top-postings which include a full copy of the previous
    article(s) at the end because it's annoying, shows that the poster
    is too lazy to trim his article, and it's wasting the time of all readers.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From G.W. Haywood@21:1/5 to Claus Assmann on Fri Oct 29 12:21:20 2021
    On Tue, 26 Oct 2021, Claus Assmann wrote:

    G.W. Haywood wrote:
    On Tue, 26 Oct 2021, Claus Assmann wrote:

    You could just send a patch to the support address and ask.

    Done.

    rcpt=<support-2021@support.sendmail.org>,status=550 5.1.1 Recipient rejected.

    Didn't you get an error from your MUA or MTA?

    Yes, but I didn't have time to jump through any more hoops just yet.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)