2023-12-17 16:10 UTC+0100 Enrico Maria Giordano <e.m.giordano@emagsoftware.it>
* contrib\hbhpdf\hpdf_fontdef_tt.c
* contrib\hbhpdf\hpdf_fontdef_type1.c
* contrib\hbhpdf\hpdf_fontdef_cid.c
* contrib\hbhpdf\hpdf_font_type1.c
* contrib\hbhpdf\hpdf_font_tt.c
* contrib\hbhpdf\hpdf_font_cid.c
* contrib\hbhpdf\hpdf_doc.c
* contrib\hbhpdf\hpdf_info
* contrib\hbhpdf\hpdf_catalog.c
* contrib\hbhpdf\hpdf_gstate.c
* contrib\hbhpdf\hpdf_pages.c
* contrib\hbhpdf\hpdf_page_operator.c
* contrib\hbhpdf\hpdf_annotation.c
* contrib\hbhpdf\hpdf_image.c
* contrib\hbhpdf\hpdf_image_png.c
* contrib\hbhpdf\hpdf_doc_png.c
* contrib\hbhpdf\hpdf_namedict.c
* contrib\hbhpdf\hpdf_pdfa.c
* contrib\hbhpdf\hpdf_encoder_utf.c
* contrib\hbhpdf\hpdf_image_ccitt.c
! fixed compiler warnings

Thx Enrico. Please review my comment in the replly to your first fix
of the harupdf contrib. Let's decide how to soolve those issues.

Il 19/12/2023 03:57, Ron Pinkas ha scritto:

Thx Enrico. Please review my comment in the replly to your first fix
of the harupdf contrib. Let's decide how to soolve those issues.

They are only simple casts.

Enrico, there is nothing wroong with such fixes, and your efforts are
greatly appreciated. In the special case of 3rd party code we simply
avoid ALL DIRECT modifications except if absolute bug and the code is no longer maintained. We usually avoid such modifications in favor of
INDIRECT modifications by means of defines.

In general its safer to ignore warnings in 3rd party code except when
the warning implies real bug and then its bestt too report it to the
project maintainers.