Le vendredi 22 juillet 2022 à 14:15:34 UTC+2, Zbig a écrit :
New listing: https://github.com/MPETREMANN11/ESP32forth/blob/main/DAC/tones.txt
Yes, I'm aware that „The purpose of the article is not to make "good FORTH code" ” — but
allow me, please, to propose changes at least for its wo... I mean: for its least good place;
(line 125 onwards). What do you think about:
: note ( n -- n+1 )
dup 1- get.note CHANNEL0 swap ledcWriteTone drop sustain.note constant 1+ ;
\ notes in english notation
1 \ starting value
note C
note C#
note D
note D#
note E
note F
note F#
note G
note G#
note A
note A#
note B
drop
Also, please note, most probably „get.note” leaves some value on the stack?
Hello,
Your code cannot work.
You create a constant.....
I think you didn't quite grasp the concept of the CREATE cup....DOES>
The CREATE part defines the way we build the word, here we store a constant. But, at runtime, the DOES> part is executed by the word that is defined:
: create-note
\ compile position in octave
create ( position -- )
,
\ get note frequency in current octave
does>
@ 1- get.note
CHANNEL0 swap ledcWriteTone drop
sustain.note
;
The word create-note creates a structure which appears to be equivalent to a constant.
But when the word created by create-note is executed, it is the part of code located after DOES> which will be executed, but not during the creation of the word.
Example:
8 create-note G
creates the word G in the music vocabulary.
Then, you have to call the music vocabulary:
forth also music also
4 set.octave
G D C# C# C G
And there the notes are played.
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)