• Comment on Commit: Just parse VER using /^VER (.*) ([^ ]*?)$/

    From Rob Swindell@1:103/705 to Synchronet note on Thu Nov 26 12:21:10 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/b846192f8b436fac248fd9d9f5f638adb a6b35ce#note_967

    Out of curiosity, I looked up how BinkD does the protocol version parsing:```#define PRTCLNAME "binkp"... if (!memcmp (s, "VER ", 4) && (a = strstr (s, PRTCLNAME "/")) != 0 && (b = strstr (a, ".")) != 0) { state->major = atoi (a + 6); state->minor = atoi (b + 1); Log (6, "remote uses " PRTCLNAME " v.%i.%i", state->major, state->minor);```So... that would match "binkp/1.1" *anywhere* in the VER string (even in parenthesis), likely explaining why IRex never had a problem with BinkD in this regard.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Altere@1:103/705 to Rob Swindell on Thu Nov 26 20:16:49 2020
    Re: Comment on Commit: Just parse VER using /^VER (.*) ([^ ]*?)$/
    By: Rob Swindell to Synchronet note on Thu Nov 26 2020 12:21 pm

    So... that would match "binkp/1.1" *anywhere* in the VER string (even in parenthesis), likely explaining why IRex never had a problem with BinkD
    in
    this regard.

    I had one more dropped connection this morning but already had debugging off. It did print deuce's warning msg on assuming binkp/1.1 so the matching is working but other then that, I don't know why it dropped. I haven't noticed any additional connection drops since, although I'm catching an earful on the MSGID now which I sent them to the wiki.

    -altere

    ---
    þ Synchronet þ Athelstan BBS þ athelstan.org þ telnet:23 / ssh:2222
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)