Andrew Alt wrote to All <=-
Was wondering if anyone could give me some additional feedback on this small patch I submitted for MultiMail?
https://github.com/wmcbrine/MultiMail/pull/20
That shows the feedback I got so far, clicking the "files changed" tab shows the actual patch.
Alan Ianson wrote to Andrew Alt <=-
Andrew Alt wrote to All <=-
Was wondering if anyone could give me some additional feedback on this small patch I submitted for MultiMail?
https://github.com/wmcbrine/MultiMail/pull/20
That shows the feedback I got so far, clicking the "files changed" tab shows the actual patch.
What's the patch do? I'll have look soonish.. :)
toWhat's the patch do? I'll have look soonish.. :)
Not much of anything really xD It's pretty trivial.. but thought it was worth doing. I narrowed the scope of newtag and put the fopen statement next to the declaration of the file descriptor, and made a slight change
the condition (which probably could just be "flag = (fd);" but the PR was closed so... guess I won't make any more changes to it...
mark lewis wrote to Andrew Alt <=-
the main thing i noted was no real explanation of why the changes were made... your above says a lot more than the report on the repository
but it still leaves some "why?"...
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 296 |
Nodes: | 16 (2 / 14) |
Uptime: | 44:17:42 |
Calls: | 6,648 |
Files: | 12,193 |
Messages: | 5,329,704 |